From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752677AbcF1Utg (ORCPT <rfc822;w@1wt.eu>);
	Tue, 28 Jun 2016 16:49:36 -0400
Received: from mail-qk0-f170.google.com ([209.85.220.170]:36294 "EHLO
	mail-qk0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752482AbcF1Utd (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 28 Jun 2016 16:49:33 -0400
Subject: Re: [PATCH 23/23] [AARCH64] Take utmp{,x}.h from s390 port
To: Yury Norov <ynorov@caviumnetworks.com>,
        Joseph Myers <joseph@codesourcery.com>
References: <1467131978-669-1-git-send-email-ynorov@caviumnetworks.com>
 <1467131978-669-24-git-send-email-ynorov@caviumnetworks.com>
 <alpine.DEB.2.20.1606281717410.25214@digraph.polyomino.org.uk>
 <20160628175107.GA2262@yury-N73SV>
Cc: libc-alpha@sourceware.org, linux-kernel@vger.kernel.org, arnd@arndb.de,
        catalin.marinas@arm.com, marcus.shawcroft@arm.com, philb@gnu.org,
        davem@davemloft.net, szabolcs.nagy@arm.com, maxim.kuvyrkov@linaro.org,
        pinskia@gmail.com, bamvor.zhangjian@huawei.com, schwab@suse.de,
        fweimer@redhat.com, Prasun.Kapoor@cavium.com, cmetcalf@mellanox.com,
        hjl.tools@gmail.com
From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Message-ID: <5772E166.2040707@linaro.org>
Date: Tue, 28 Jun 2016 17:43:18 -0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.8.0
MIME-Version: 1.0
In-Reply-To: <20160628175107.GA2262@yury-N73SV>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 28/06/2016 14:59, Yury Norov wrote:
> On Tue, Jun 28, 2016 at 05:18:04PM +0000, Joseph Myers wrote:
>> On Tue, 28 Jun 2016, Yury Norov wrote:
>>
>>> aarch64 and ilp32 has different size of time_t. So to have common
>>> layout for struct utmp and utmpx, corresponding headers are taken
>>> from s390 port.
>>
>> You can't #include installed headers from other ports like this; it 
>> wouldn't work when using an installed library.
>>
>> -- 
>> Joseph S. Myers
>> joseph@codesourcery.com
> 
> So I should copy? Hmm...
> 

In this case yes, since the reference will be broken because the s390
won't be installed.