From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yakir Yang Subject: Re: [PATCH v3 10/10] drm/bridge: analogix_dp: fix no drm hpd event when panel plug in Date: Wed, 29 Jun 2016 11:35:57 +0800 Message-ID: <5773421D.4070202@rock-chips.com> References: <1465904718-663-1-git-send-email-ykk@rock-chips.com> <1465904802-1164-1-git-send-email-ykk@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sean Paul Cc: Krzysztof Kozlowski , linux-samsung-soc , Javier Martinez Canillas , Mark Yao , Jingoo Han , Emil Velikov , Douglas Anderson , dri-devel , Linux Kernel Mailing List , linux-rockchip@lists.infradead.org, Daniel Vetter , Tomasz Figa , =?UTF-8?Q?St=c3=a9phane_Marchesin?= , Thierry Reding , Dan Carpenter List-Id: linux-rockchip.vger.kernel.org U2VhbiwKCk9uIDA2LzIzLzIwMTYgMTA6MjQgUE0sIFNlYW4gUGF1bCB3cm90ZToKPiBPbiBUdWUs IEp1biAxNCwgMjAxNiBhdCA3OjQ2IEFNLCBZYWtpciBZYW5nIDx5a2tAcm9jay1jaGlwcy5jb20+ IHdyb3RlOgo+PiBUaGUgZW51bSB2YWx1ZSBvZiBEUF9JUlFfVFlQRV9IUF9DQUJMRV9JTiBpcyB6 ZXJvLCBidXQgZHJpdmVyIG9ubHkKPj4gc2VuZCBkcm0gaHAgZXZlbnQgd2hlbiB0aGUgaXJxX3R5 cGUgYW5kIHRoZSBlbnVtIHZhbHVlIGlzIHRydWUuCj4+Cj4+IGlmIChpcnFfdHlwZSAmIERQX0lS UV9UWVBFX0hQX0NBQkxFX0lOIHx8IC4uLikKPj4gICAgICAgICAgZHJtX2hlbHBlcl9ocGRfaXJx X2V2ZW50KGRwLT5kcm1fZGV2KTsKPj4KPj4gU28gdGhlcmUgd291bGQgbm8gZHJtIGhwZCBldmVu dCB3aGVuIGNhYmxlIHBsdWcgaW4sIHRvIGZpeCB0aGF0Cj4+IGp1c3QgbmVlZCB0byBhc3NpZ24g YWxsIGhvdHBsdWcgZW51bSB3aXRoIG5vLXplcm8gdmFsdWVzLgo+Pgo+PiBSZXBvcnRlZC1ieTog RGFuIENhcnBlbnRlciA8ZGFuLmNhcnBlbnRlckBvcmFjbGUuY29tPgo+PiBTaWduZWQtb2ZmLWJ5 OiBZYWtpciBZYW5nIDx5a2tAcm9jay1jaGlwcy5jb20+Cj4+IFJldmlld2VkLWJ5OiBTdMOpcGhh bmUgTWFyY2hlc2luIDxtYXJjaGV1QGNocm9taXVtLm9yZz4KPj4gVGVzdGVkLWJ5OiBKYXZpZXIg TWFydGluZXogQ2FuaWxsYXMgPGphdmllckBvc2cuc2Ftc3VuZy5jb20+Cj4gUmV2aWV3ZWQtYnk6 IFNlYW4gUGF1bCA8c2VhbnBhdWxAY2hyb21pdW0ub3JnPgo+CgpUaGFua3MgIDspCgo+PiAtLS0K Pj4gQ2hhbmdlcyBpbiB2MzoKPj4gLSBBZGQgcmV2aWV3ZWQgZmxhZyBmcm9tIFN0w6lwaGFuZS4K Pj4gICAgICBbaHR0cHM6Ly9jaHJvbWl1bS1yZXZpZXcuZ29vZ2xlc291cmNlLmNvbS8jL2MvMzQ2 MzE5LzE1XQo+PiAtIEFkZCB0ZXN0ZWQgZmxhZyBmcm9tIEphdmllcgo+Pgo+PiBDaGFuZ2VzIGlu IHYyOiBOb25lCj4+Cj4+ICAgZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9hbmFsb2dpeC9hbmFsb2dp eF9kcF9jb3JlLmggfCA4ICsrKystLS0tCj4+ICAgMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9u cygrKSwgNCBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9i cmlkZ2UvYW5hbG9naXgvYW5hbG9naXhfZHBfY29yZS5oIGIvZHJpdmVycy9ncHUvZHJtL2JyaWRn ZS9hbmFsb2dpeC9hbmFsb2dpeF9kcF9jb3JlLmgKPj4gaW5kZXggZjA5Mjc1ZC4uYjQ1NjM4MCAx MDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9hbmFsb2dpeC9hbmFsb2dpeF9k cF9jb3JlLmgKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9hbmFsb2dpeC9hbmFsb2dp eF9kcF9jb3JlLmgKPj4gQEAgLTEyNywxMCArMTI3LDEwIEBAIGVudW0gYW5hbG9nX3Bvd2VyX2Js b2NrIHsKPj4gICB9Owo+Pgo+PiAgIGVudW0gZHBfaXJxX3R5cGUgewo+PiAtICAgICAgIERQX0lS UV9UWVBFX0hQX0NBQkxFX0lOLAo+PiAtICAgICAgIERQX0lSUV9UWVBFX0hQX0NBQkxFX09VVCwK Pj4gLSAgICAgICBEUF9JUlFfVFlQRV9IUF9DSEFOR0UsCj4+IC0gICAgICAgRFBfSVJRX1RZUEVf VU5LTk9XTiwKPj4gKyAgICAgICBEUF9JUlFfVFlQRV9IUF9DQUJMRV9JTiAgPSBCSVQoMCksCj4+ ICsgICAgICAgRFBfSVJRX1RZUEVfSFBfQ0FCTEVfT1VUID0gQklUKDEpLAo+PiArICAgICAgIERQ X0lSUV9UWVBFX0hQX0NIQU5HRSAgICA9IEJJVCgyKSwKPj4gKyAgICAgICBEUF9JUlFfVFlQRV9V TktOT1dOICAgICAgPSBCSVQoMyksCj4+ICAgfTsKPj4KPj4gICBzdHJ1Y3QgdmlkZW9faW5mbyB7 Cj4+IC0tCj4+IDEuOS4xCj4+Cj4+Cj4+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCj4+IGRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKPj4gZHJpLWRldmVsQGxp c3RzLmZyZWVkZXNrdG9wLm9yZwo+PiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo+Cj4KCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752755AbcF2DgI (ORCPT ); Tue, 28 Jun 2016 23:36:08 -0400 Received: from lucky1.263xmail.com ([211.157.147.132]:45957 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752548AbcF2DgG (ORCPT ); Tue, 28 Jun 2016 23:36:06 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: ykk@rock-chips.com X-FST-TO: dan.carpenter@oracle.com X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: ykk@rock-chips.com X-UNIQUE-TAG: <2047813e416cd7dbf61317ca3635df63> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v3 10/10] drm/bridge: analogix_dp: fix no drm hpd event when panel plug in To: Sean Paul References: <1465904718-663-1-git-send-email-ykk@rock-chips.com> <1465904802-1164-1-git-send-email-ykk@rock-chips.com> Cc: Mark Yao , Inki Dae , Jingoo Han , Heiko Stuebner , Krzysztof Kozlowski , linux-samsung-soc , linux-rockchip@lists.infradead.org, Daniel Vetter , Emil Velikov , Douglas Anderson , dri-devel , Linux Kernel Mailing List , Javier Martinez Canillas , Tomasz Figa , =?UTF-8?Q?St=c3=a9phane_Marchesin?= , Thierry Reding , Dan Carpenter From: Yakir Yang Message-ID: <5773421D.4070202@rock-chips.com> Date: Wed, 29 Jun 2016 11:35:57 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sean, On 06/23/2016 10:24 PM, Sean Paul wrote: > On Tue, Jun 14, 2016 at 7:46 AM, Yakir Yang wrote: >> The enum value of DP_IRQ_TYPE_HP_CABLE_IN is zero, but driver only >> send drm hp event when the irq_type and the enum value is true. >> >> if (irq_type & DP_IRQ_TYPE_HP_CABLE_IN || ...) >> drm_helper_hpd_irq_event(dp->drm_dev); >> >> So there would no drm hpd event when cable plug in, to fix that >> just need to assign all hotplug enum with no-zero values. >> >> Reported-by: Dan Carpenter >> Signed-off-by: Yakir Yang >> Reviewed-by: Stéphane Marchesin >> Tested-by: Javier Martinez Canillas > Reviewed-by: Sean Paul > Thanks ;) >> --- >> Changes in v3: >> - Add reviewed flag from Stéphane. >> [https://chromium-review.googlesource.com/#/c/346319/15] >> - Add tested flag from Javier >> >> Changes in v2: None >> >> drivers/gpu/drm/bridge/analogix/analogix_dp_core.h | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.h b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.h >> index f09275d..b456380 100644 >> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.h >> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.h >> @@ -127,10 +127,10 @@ enum analog_power_block { >> }; >> >> enum dp_irq_type { >> - DP_IRQ_TYPE_HP_CABLE_IN, >> - DP_IRQ_TYPE_HP_CABLE_OUT, >> - DP_IRQ_TYPE_HP_CHANGE, >> - DP_IRQ_TYPE_UNKNOWN, >> + DP_IRQ_TYPE_HP_CABLE_IN = BIT(0), >> + DP_IRQ_TYPE_HP_CABLE_OUT = BIT(1), >> + DP_IRQ_TYPE_HP_CHANGE = BIT(2), >> + DP_IRQ_TYPE_UNKNOWN = BIT(3), >> }; >> >> struct video_info { >> -- >> 1.9.1 >> >> >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/dri-devel > >