All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jongsung Kim <neidhard.kim@lge.com>
To: Michael Turquette <mturquette@baylibre.com>,
	Rob Herring <robh@kernel.org>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>,
	Stephen Boyd <sboyd@codeaurora.org>,
	linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, Chanho Min <chanho.min@lge.com>
Subject: Re: [PATCH v2] clk: fixed-factor: add optional dt-binding clock-flags
Date: Wed, 29 Jun 2016 16:06:21 +0900	[thread overview]
Message-ID: <5773736D.3060405@lge.com> (raw)
In-Reply-To: <146714872010.89261.1969853552594659808@resonance>

On 2016년 06월 29일 06:18, Michael Turquette wrote:
> Quoting Rob Herring (2016-06-28 13:55:18)
>> On Fri, Jun 24, 2016 at 01:12:52PM +0900, Jongsung Kim wrote:
>>> There is no way to set additional flags for a DT-initialized fixed-
>>> factor-clock, and it can be problematic i.e., when the clock rate
>>> needs to be changed. [1][2]
>>>
>>> This patch introduces an optional dt-binding named "clock-flags" to
>>> be used for passing any needed flags from dts.
>> I don't think we want this in DT. If we did, the flags would need some 
>> documentation about what the flags mean.
> Flags are specific to Linux implementation, so I agree with Rob. Better
> to create a compatible string for your hardware that bakes in the flags.

Thank you for your comment, Mike. This conversation starts from lacking method to set CLK_SET_RATE_PARENT from DT. I understand compatible string can be a solution. But.. if someone starts talking about lacking method to set another flag, i.e., CLK_SET_PARENT_GATE, then we'll need another compatible string list.
How do you think about defining possible required subset of the flags and using some more neutral flag-names acceptable in DT?

  reply	other threads:[~2016-06-29  7:06 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-13  9:08 [RESEND][PATCH] clk: fixed-factor: set CLK_SET_RATE_PARENT Jongsung Kim
2016-06-21  0:59 ` Stephen Boyd
2016-06-24  3:49   ` [PATCH] clk: fixed-factor: add optional dt-binding clock-flags Jongsung Kim
2016-06-24  3:49     ` Jongsung Kim
2016-06-24  5:11     ` kbuild test robot
2016-06-24  5:11       ` kbuild test robot
2016-06-24  5:57     ` kbuild test robot
2016-06-24  5:57       ` kbuild test robot
2016-06-24  4:12   ` [PATCH v2] " Jongsung Kim
2016-06-24  4:12     ` Jongsung Kim
2016-06-28 20:55     ` Rob Herring
2016-06-28 21:18       ` Michael Turquette
2016-06-28 21:18         ` Michael Turquette
2016-06-29  7:06         ` Jongsung Kim [this message]
2016-07-02  0:20           ` Stephen Boyd
2016-07-04  1:48             ` Jongsung Kim
2016-08-25  0:52               ` Stephen Boyd
2016-06-29  5:04       ` Jongsung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5773736D.3060405@lge.com \
    --to=neidhard.kim@lge.com \
    --cc=chanho.min@lge.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxime.ripard@free-electrons.com \
    --cc=mturquette@baylibre.com \
    --cc=robh@kernel.org \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.