From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752579AbcF2PhT (ORCPT ); Wed, 29 Jun 2016 11:37:19 -0400 Received: from mx2.suse.de ([195.135.220.15]:50793 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752082AbcF2PhR (ORCPT ); Wed, 29 Jun 2016 11:37:17 -0400 Subject: Re: [Xen-devel] [PATCH] x86/xen: Use DIV_ROUND_UP To: Jan Beulich , Amitoj Kaur Chawla References: <20160629150038.GA13956@amitoj-Inspiron-3542> <5774068C02000078000F9DCB@suse.com> Cc: david.vrabel@citrix.com, x86@kernel.org, tglx@linutronix.de, julia.lawall@lip6.fr, xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com, mingo@redhat.com, linux-kernel@vger.kernel.org, hpa@zytor.com From: Juergen Gross Message-ID: <5773EADE.70600@suse.com> Date: Wed, 29 Jun 2016 17:35:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.0 MIME-Version: 1.0 In-Reply-To: <5774068C02000078000F9DCB@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/06/16 17:34, Jan Beulich wrote: >>>> On 29.06.16 at 17:00, wrote: >> --- a/arch/x86/xen/enlighten.c >> +++ b/arch/x86/xen/enlighten.c >> @@ -591,7 +591,7 @@ static void xen_load_gdt(const struct desc_ptr *dtr) >> { >> unsigned long va = dtr->address; >> unsigned int size = dtr->size + 1; >> - unsigned pages = (size + PAGE_SIZE - 1) / PAGE_SIZE; >> + unsigned pages = DIV_ROUND_UP(size, PAGE_SIZE); >> unsigned long frames[pages]; >> int f; >> >> @@ -640,7 +640,7 @@ static void __init xen_load_gdt_boot(const struct desc_ptr *dtr) >> { >> unsigned long va = dtr->address; >> unsigned int size = dtr->size + 1; >> - unsigned pages = (size + PAGE_SIZE - 1) / PAGE_SIZE; >> + unsigned pages = DIV_ROUND_UP(size, PAGE_SIZE); >> unsigned long frames[pages]; >> int f; >> > > Perhaps even more readable would be PFN_DOWN()? Or PFN_UP() to be correct? Juergen From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juergen Gross Subject: Re: [PATCH] x86/xen: Use DIV_ROUND_UP Date: Wed, 29 Jun 2016 17:35:58 +0200 Message-ID: <5773EADE.70600@suse.com> References: <20160629150038.GA13956@amitoj-Inspiron-3542> <5774068C02000078000F9DCB@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bIHX0-0007Ma-Mt for xen-devel@lists.xenproject.org; Wed, 29 Jun 2016 15:36:02 +0000 In-Reply-To: <5774068C02000078000F9DCB@suse.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jan Beulich , Amitoj Kaur Chawla Cc: x86@kernel.org, linux-kernel@vger.kernel.org, julia.lawall@lip6.fr, mingo@redhat.com, david.vrabel@citrix.com, hpa@zytor.com, xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com, tglx@linutronix.de List-Id: xen-devel@lists.xenproject.org T24gMjkvMDYvMTYgMTc6MzQsIEphbiBCZXVsaWNoIHdyb3RlOgo+Pj4+IE9uIDI5LjA2LjE2IGF0 IDE3OjAwLCA8YW1pdG9qMTYwNkBnbWFpbC5jb20+IHdyb3RlOgo+PiAtLS0gYS9hcmNoL3g4Ni94 ZW4vZW5saWdodGVuLmMKPj4gKysrIGIvYXJjaC94ODYveGVuL2VubGlnaHRlbi5jCj4+IEBAIC01 OTEsNyArNTkxLDcgQEAgc3RhdGljIHZvaWQgeGVuX2xvYWRfZ2R0KGNvbnN0IHN0cnVjdCBkZXNj X3B0ciAqZHRyKQo+PiAgewo+PiAgCXVuc2lnbmVkIGxvbmcgdmEgPSBkdHItPmFkZHJlc3M7Cj4+ ICAJdW5zaWduZWQgaW50IHNpemUgPSBkdHItPnNpemUgKyAxOwo+PiAtCXVuc2lnbmVkIHBhZ2Vz ID0gKHNpemUgKyBQQUdFX1NJWkUgLSAxKSAvIFBBR0VfU0laRTsKPj4gKwl1bnNpZ25lZCBwYWdl cyA9IERJVl9ST1VORF9VUChzaXplLCBQQUdFX1NJWkUpOwo+PiAgCXVuc2lnbmVkIGxvbmcgZnJh bWVzW3BhZ2VzXTsKPj4gIAlpbnQgZjsKPj4gIAo+PiBAQCAtNjQwLDcgKzY0MCw3IEBAIHN0YXRp YyB2b2lkIF9faW5pdCB4ZW5fbG9hZF9nZHRfYm9vdChjb25zdCBzdHJ1Y3QgZGVzY19wdHIgKmR0 cikKPj4gIHsKPj4gIAl1bnNpZ25lZCBsb25nIHZhID0gZHRyLT5hZGRyZXNzOwo+PiAgCXVuc2ln bmVkIGludCBzaXplID0gZHRyLT5zaXplICsgMTsKPj4gLQl1bnNpZ25lZCBwYWdlcyA9IChzaXpl ICsgUEFHRV9TSVpFIC0gMSkgLyBQQUdFX1NJWkU7Cj4+ICsJdW5zaWduZWQgcGFnZXMgPSBESVZf Uk9VTkRfVVAoc2l6ZSwgUEFHRV9TSVpFKTsKPj4gIAl1bnNpZ25lZCBsb25nIGZyYW1lc1twYWdl c107Cj4+ICAJaW50IGY7Cj4+ICAKPiAKPiBQZXJoYXBzIGV2ZW4gbW9yZSByZWFkYWJsZSB3b3Vs ZCBiZSBQRk5fRE9XTigpPwoKT3IgUEZOX1VQKCkgdG8gYmUgY29ycmVjdD8KCgpKdWVyZ2VuCgoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y Zy94ZW4tZGV2ZWwK