From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Wang Subject: Re: [PATCH net-next V3 5/6] net: introduce NETDEV_CHANGE_TX_QUEUE_LEN Date: Thu, 30 Jun 2016 13:12:38 +0800 Message-ID: <5774AA46.3090604@redhat.com> References: <1467258779-3539-1-git-send-email-jasowang@redhat.com> <1467258779-3539-6-git-send-email-jasowang@redhat.com> <5774A67B.1060802@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <5774A67B.1060802@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: John Fastabend , mst@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, davem@davemloft.net Cc: brouer@redhat.com, eric.dumazet@gmail.com, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org List-Id: virtualization@lists.linuxfoundation.org CgpPbiAyMDE25bm0MDbmnIgzMOaXpSAxMjo1NiwgSm9obiBGYXN0YWJlbmQgd3JvdGU6Cj4gT24g MTYtMDYtMjkgMDg6NTIgUE0sIEphc29uIFdhbmcgd3JvdGU6Cj4+IFRoaXMgcGF0Y2ggaW50cm9k dWNlcyBhIG5ldyBldmVudCAtIE5FVERFVl9DSEFOR0VfVFhfUVVFVUVfTEVOLCB0aGlzCj4+IHdp bGwgYmUgdHJpZ2dlcmVkIHdoZW4gdHhfcXVldWVfbGVuLiBJdCBjb3VsZCBiZSB1c2VkIGJ5IG5l dCBkZXZpY2UKPj4gd2hvIHdhbnQgdG8gZG8gc29tZSBwcm9jZXNzaW5nIGF0IHRoYXQgdGltZS4g QW4gZXhhbXBsZSBpcyB0dW4gd2hvIG1heQo+PiB3YW50IHRvIHJlc2l6ZSB0eCBhcnJheSB3aGVu IHR4X3F1ZXVlX2xlbiBpcyBjaGFuZ2VkLgo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBKYXNvbiBXYW5n IDxqYXNvd2FuZ0ByZWRoYXQuY29tPgo+PiAtLS0KPj4gICBpbmNsdWRlL2xpbnV4L25ldGRldmlj ZS5oIHwgIDEgKwo+PiAgIG5ldC9jb3JlL25ldC1zeXNmcy5jICAgICAgfCAxNSArKysrKysrKysr KysrKy0KPj4gICAyIGZpbGVzIGNoYW5nZWQsIDE1IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24o LSkKPj4KPj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvbGludXgvbmV0ZGV2aWNlLmggYi9pbmNsdWRl L2xpbnV4L25ldGRldmljZS5oCj4+IGluZGV4IGU4NGQ5ZDIuLjdkYzJlYzcgMTAwNjQ0Cj4+IC0t LSBhL2luY2x1ZGUvbGludXgvbmV0ZGV2aWNlLmgKPj4gKysrIGIvaW5jbHVkZS9saW51eC9uZXRk ZXZpY2UuaAo+PiBAQCAtMjIzNyw2ICsyMjM3LDcgQEAgc3RydWN0IG5ldGRldl9sYWdfbG93ZXJf c3RhdGVfaW5mbyB7Cj4+ICAgI2RlZmluZSBORVRERVZfUFJFQ0hBTkdFVVBQRVIJMHgwMDFBCj4+ ICAgI2RlZmluZSBORVRERVZfQ0hBTkdFTE9XRVJTVEFURQkweDAwMUIKPj4gICAjZGVmaW5lIE5F VERFVl9VRFBfVFVOTkVMX1BVU0hfSU5GTwkweDAwMUMKPj4gKyNkZWZpbmUgTkVUREVWX0NIQU5H RV9UWF9RVUVVRV9MRU4JMHgwMDFFCj4+ICAgCj4+ICAgaW50IHJlZ2lzdGVyX25ldGRldmljZV9u b3RpZmllcihzdHJ1Y3Qgbm90aWZpZXJfYmxvY2sgKm5iKTsKPj4gICBpbnQgdW5yZWdpc3Rlcl9u ZXRkZXZpY2Vfbm90aWZpZXIoc3RydWN0IG5vdGlmaWVyX2Jsb2NrICpuYik7Cj4+IGRpZmYgLS1n aXQgYS9uZXQvY29yZS9uZXQtc3lzZnMuYyBiL25ldC9jb3JlL25ldC1zeXNmcy5jCj4+IGluZGV4 IDdhMGI2MTYuLjZlNGYzNDcgMTAwNjQ0Cj4+IC0tLSBhL25ldC9jb3JlL25ldC1zeXNmcy5jCj4+ ICsrKyBiL25ldC9jb3JlL25ldC1zeXNmcy5jCj4+IEBAIC0zMjIsNyArMzIyLDIwIEBAIE5FVERF VklDRV9TSE9XX1JXKGZsYWdzLCBmbXRfaGV4KTsKPj4gICAKPj4gICBzdGF0aWMgaW50IGNoYW5n ZV90eF9xdWV1ZV9sZW4oc3RydWN0IG5ldF9kZXZpY2UgKmRldiwgdW5zaWduZWQgbG9uZyBuZXdf bGVuKQo+PiAgIHsKPj4gLQlkZXYtPnR4X3F1ZXVlX2xlbiA9IG5ld19sZW47Cj4+ICsJaW50IHJl cywgb3JpZ19sZW4gPSBkZXYtPnR4X3F1ZXVlX2xlbjsKPj4gKwo+PiArCWlmIChuZXdfbGVuICE9 IG9yaWdfbGVuKSB7Cj4+ICsJCWRldi0+dHhfcXVldWVfbGVuID0gbmV3X2xlbjsKPj4gKwkJcmVz ID0gY2FsbF9uZXRkZXZpY2Vfbm90aWZpZXJzKE5FVERFVl9DSEFOR0VfVFhfUVVFVUVfTEVOLCBk ZXYpOwo+PiArCQlyZXMgPSBub3RpZmllcl90b19lcnJubyhyZXMpOwo+PiArCQlpZiAocmVzKSB7 Cj4+ICsJCQluZXRkZXZfZXJyKGRldiwKPj4gKwkJCQkgICAicmVmdXNlZCB0byBjaGFuZ2UgZGV2 aWNlIHR4X3F1ZXVlX2xlblxuIik7Cj4+ICsJCQlkZXYtPnR4X3F1ZXVlX2xlbiA9IG9yaWdfbGVu Owo+PiArCQkJcmV0dXJuIC1FRkFVTFQ7Cj4+ICsJCX0KPj4gKwl9Cj4+ICsKPj4gICAJcmV0dXJu IDA7Cj4+ICAgfQo+PiAgIAo+Pgo+IEFja2VkLWJ5OiBKb2huIEZhc3RhYmVuZCA8am9obi5yLmZh c3RhYmVuZEBpbnRlbC5jb20+Cj4KPiBHcmVhdCB0aW1pbmcgSSB3YXMganVzdCBsb29raW5nIGlu dG8gdGhpcyBiZWNhdXNlIEkgbmVlZCBpdCBmb3IgdGhlCj4gcWRpc2Mgc2lkZS4KPgo+IEl0IGxv b2tzIGxpa2UgdGhpcyBjb3ZlcnMgdGhlIHN5c2ZzIGNoYW5nZSBidXQgdGhlIHR4X3F1ZXVlX2xl biBjYW4KPiBhbHNvIGJlIGNoYW5nZWQgdmlhIHJ0bmV0bGluayBhcyB3ZWxsLiBTbyB3ZSBuZWVk IGFub3RoZXIgcGF0Y2ggZm9yCj4gdGhhdCBwYXRoIHJpZ2h0Pwo+Cj4gICAgICAgICAgaWYgKHRi W0lGTEFfVFhRTEVOXSkgewo+ICAgICAgICAgICAgICAgICAgdW5zaWduZWQgbG9uZyB2YWx1ZSA9 IG5sYV9nZXRfdTMyKHRiW0lGTEFfVFhRTEVOXSk7Cj4KPiAgICAgICAgICAgICAgICAgIGlmIChk ZXYtPnR4X3F1ZXVlX2xlbiBeIHZhbHVlKQo+ICAgICAgICAgICAgICAgICAgICAgICAgICBzdGF0 dXMgfD0gRE9fU0VUTElOS19OT1RJRlk7Cj4KPiAgICAgICAgICAgICAgICAgIGRldi0+dHhfcXVl dWVfbGVuID0gdmFsdWU7Cj4gICAgICAgICAgfQo+Cj4gVGhhbmtzLAo+IEpvaG4KPgoKUmlnaHQs IHdpbGwgZG8gdGhpcyBpbiBuZXh0IHZlcnNpb24uCgpUaGFua3MKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KVmlydHVhbGl6YXRpb24gbWFpbGluZyBsaXN0 ClZpcnR1YWxpemF0aW9uQGxpc3RzLmxpbnV4LWZvdW5kYXRpb24ub3JnCmh0dHBzOi8vbGlzdHMu bGludXhmb3VuZGF0aW9uLm9yZy9tYWlsbWFuL2xpc3RpbmZvL3ZpcnR1YWxpemF0aW9u From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751704AbcF3FNO (ORCPT ); Thu, 30 Jun 2016 01:13:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42301 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750709AbcF3FNM (ORCPT ); Thu, 30 Jun 2016 01:13:12 -0400 Subject: Re: [PATCH net-next V3 5/6] net: introduce NETDEV_CHANGE_TX_QUEUE_LEN To: John Fastabend , mst@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, davem@davemloft.net References: <1467258779-3539-1-git-send-email-jasowang@redhat.com> <1467258779-3539-6-git-send-email-jasowang@redhat.com> <5774A67B.1060802@gmail.com> Cc: kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, eric.dumazet@gmail.com, brouer@redhat.com From: Jason Wang Message-ID: <5774AA46.3090604@redhat.com> Date: Thu, 30 Jun 2016 13:12:38 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <5774A67B.1060802@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Thu, 30 Jun 2016 05:12:44 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016年06月30日 12:56, John Fastabend wrote: > On 16-06-29 08:52 PM, Jason Wang wrote: >> This patch introduces a new event - NETDEV_CHANGE_TX_QUEUE_LEN, this >> will be triggered when tx_queue_len. It could be used by net device >> who want to do some processing at that time. An example is tun who may >> want to resize tx array when tx_queue_len is changed. >> >> Signed-off-by: Jason Wang >> --- >> include/linux/netdevice.h | 1 + >> net/core/net-sysfs.c | 15 ++++++++++++++- >> 2 files changed, 15 insertions(+), 1 deletion(-) >> >> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h >> index e84d9d2..7dc2ec7 100644 >> --- a/include/linux/netdevice.h >> +++ b/include/linux/netdevice.h >> @@ -2237,6 +2237,7 @@ struct netdev_lag_lower_state_info { >> #define NETDEV_PRECHANGEUPPER 0x001A >> #define NETDEV_CHANGELOWERSTATE 0x001B >> #define NETDEV_UDP_TUNNEL_PUSH_INFO 0x001C >> +#define NETDEV_CHANGE_TX_QUEUE_LEN 0x001E >> >> int register_netdevice_notifier(struct notifier_block *nb); >> int unregister_netdevice_notifier(struct notifier_block *nb); >> diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c >> index 7a0b616..6e4f347 100644 >> --- a/net/core/net-sysfs.c >> +++ b/net/core/net-sysfs.c >> @@ -322,7 +322,20 @@ NETDEVICE_SHOW_RW(flags, fmt_hex); >> >> static int change_tx_queue_len(struct net_device *dev, unsigned long new_len) >> { >> - dev->tx_queue_len = new_len; >> + int res, orig_len = dev->tx_queue_len; >> + >> + if (new_len != orig_len) { >> + dev->tx_queue_len = new_len; >> + res = call_netdevice_notifiers(NETDEV_CHANGE_TX_QUEUE_LEN, dev); >> + res = notifier_to_errno(res); >> + if (res) { >> + netdev_err(dev, >> + "refused to change device tx_queue_len\n"); >> + dev->tx_queue_len = orig_len; >> + return -EFAULT; >> + } >> + } >> + >> return 0; >> } >> >> > Acked-by: John Fastabend > > Great timing I was just looking into this because I need it for the > qdisc side. > > It looks like this covers the sysfs change but the tx_queue_len can > also be changed via rtnetlink as well. So we need another patch for > that path right? > > if (tb[IFLA_TXQLEN]) { > unsigned long value = nla_get_u32(tb[IFLA_TXQLEN]); > > if (dev->tx_queue_len ^ value) > status |= DO_SETLINK_NOTIFY; > > dev->tx_queue_len = value; > } > > Thanks, > John > Right, will do this in next version. Thanks