From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Wang Subject: Re: [PATCH net-next V3 5/6] net: introduce NETDEV_CHANGE_TX_QUEUE_LEN Date: Thu, 30 Jun 2016 14:43:00 +0800 Message-ID: <5774BF74.9000508@redhat.com> References: <1467258779-3539-1-git-send-email-jasowang@redhat.com> <1467258779-3539-6-git-send-email-jasowang@redhat.com> <5774A67B.1060802@gmail.com> <5774AA46.3090604@redhat.com> <5774B553.5070701@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <5774B553.5070701@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: John Fastabend , mst@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, davem@davemloft.net Cc: brouer@redhat.com, eric.dumazet@gmail.com, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org List-Id: virtualization@lists.linuxfoundation.org CgpPbiAyMDE25bm0MDbmnIgzMOaXpSAxMzo1OSwgSmFzb24gV2FuZyB3cm90ZToKPgo+Cj4gT24g MjAxNuW5tDA25pyIMzDml6UgMTM6MTIsIEphc29uIFdhbmcgd3JvdGU6Cj4+Cj4+Cj4+IE9uIDIw MTblubQwNuaciDMw5pelIDEyOjU2LCBKb2huIEZhc3RhYmVuZCB3cm90ZToKPj4+IE9uIDE2LTA2 LTI5IDA4OjUyIFBNLCBKYXNvbiBXYW5nIHdyb3RlOgo+Pj4+IFRoaXMgcGF0Y2ggaW50cm9kdWNl cyBhIG5ldyBldmVudCAtIE5FVERFVl9DSEFOR0VfVFhfUVVFVUVfTEVOLCB0aGlzCj4+Pj4gd2ls bCBiZSB0cmlnZ2VyZWQgd2hlbiB0eF9xdWV1ZV9sZW4uIEl0IGNvdWxkIGJlIHVzZWQgYnkgbmV0 IGRldmljZQo+Pj4+IHdobyB3YW50IHRvIGRvIHNvbWUgcHJvY2Vzc2luZyBhdCB0aGF0IHRpbWUu IEFuIGV4YW1wbGUgaXMgdHVuIHdobyBtYXkKPj4+PiB3YW50IHRvIHJlc2l6ZSB0eCBhcnJheSB3 aGVuIHR4X3F1ZXVlX2xlbiBpcyBjaGFuZ2VkLgo+Pj4+Cj4+Pj4gU2lnbmVkLW9mZi1ieTogSmFz b24gV2FuZyA8amFzb3dhbmdAcmVkaGF0LmNvbT4KPj4+PiAtLS0KPj4+PiAgIGluY2x1ZGUvbGlu dXgvbmV0ZGV2aWNlLmggfCAgMSArCj4+Pj4gICBuZXQvY29yZS9uZXQtc3lzZnMuYyAgICAgIHwg MTUgKysrKysrKysrKysrKystCj4+Pj4gICAyIGZpbGVzIGNoYW5nZWQsIDE1IGluc2VydGlvbnMo KyksIDEgZGVsZXRpb24oLSkKPj4+Pgo+Pj4+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2xpbnV4L25l dGRldmljZS5oIGIvaW5jbHVkZS9saW51eC9uZXRkZXZpY2UuaAo+Pj4+IGluZGV4IGU4NGQ5ZDIu LjdkYzJlYzcgMTAwNjQ0Cj4+Pj4gLS0tIGEvaW5jbHVkZS9saW51eC9uZXRkZXZpY2UuaAo+Pj4+ ICsrKyBiL2luY2x1ZGUvbGludXgvbmV0ZGV2aWNlLmgKPj4+PiBAQCAtMjIzNyw2ICsyMjM3LDcg QEAgc3RydWN0IG5ldGRldl9sYWdfbG93ZXJfc3RhdGVfaW5mbyB7Cj4+Pj4gICAjZGVmaW5lIE5F VERFVl9QUkVDSEFOR0VVUFBFUiAgICAweDAwMUEKPj4+PiAgICNkZWZpbmUgTkVUREVWX0NIQU5H RUxPV0VSU1RBVEUgICAgMHgwMDFCCj4+Pj4gICAjZGVmaW5lIE5FVERFVl9VRFBfVFVOTkVMX1BV U0hfSU5GTyAgICAweDAwMUMKPj4+PiArI2RlZmluZSBORVRERVZfQ0hBTkdFX1RYX1FVRVVFX0xF TiAgICAweDAwMUUKPj4+PiAgICAgaW50IHJlZ2lzdGVyX25ldGRldmljZV9ub3RpZmllcihzdHJ1 Y3Qgbm90aWZpZXJfYmxvY2sgKm5iKTsKPj4+PiAgIGludCB1bnJlZ2lzdGVyX25ldGRldmljZV9u b3RpZmllcihzdHJ1Y3Qgbm90aWZpZXJfYmxvY2sgKm5iKTsKPj4+PiBkaWZmIC0tZ2l0IGEvbmV0 L2NvcmUvbmV0LXN5c2ZzLmMgYi9uZXQvY29yZS9uZXQtc3lzZnMuYwo+Pj4+IGluZGV4IDdhMGI2 MTYuLjZlNGYzNDcgMTAwNjQ0Cj4+Pj4gLS0tIGEvbmV0L2NvcmUvbmV0LXN5c2ZzLmMKPj4+PiAr KysgYi9uZXQvY29yZS9uZXQtc3lzZnMuYwo+Pj4+IEBAIC0zMjIsNyArMzIyLDIwIEBAIE5FVERF VklDRV9TSE9XX1JXKGZsYWdzLCBmbXRfaGV4KTsKPj4+PiAgICAgc3RhdGljIGludCBjaGFuZ2Vf dHhfcXVldWVfbGVuKHN0cnVjdCBuZXRfZGV2aWNlICpkZXYsIHVuc2lnbmVkIAo+Pj4+IGxvbmcg bmV3X2xlbikKPj4+PiAgIHsKPj4+PiAtICAgIGRldi0+dHhfcXVldWVfbGVuID0gbmV3X2xlbjsK Pj4+PiArICAgIGludCByZXMsIG9yaWdfbGVuID0gZGV2LT50eF9xdWV1ZV9sZW47Cj4+Pj4gKwo+ Pj4+ICsgICAgaWYgKG5ld19sZW4gIT0gb3JpZ19sZW4pIHsKPj4+PiArICAgICAgICBkZXYtPnR4 X3F1ZXVlX2xlbiA9IG5ld19sZW47Cj4+Pj4gKyAgICAgICAgcmVzID0gY2FsbF9uZXRkZXZpY2Vf bm90aWZpZXJzKE5FVERFVl9DSEFOR0VfVFhfUVVFVUVfTEVOLCAKPj4+PiBkZXYpOwo+Pj4+ICsg ICAgICAgIHJlcyA9IG5vdGlmaWVyX3RvX2Vycm5vKHJlcyk7Cj4+Pj4gKyAgICAgICAgaWYgKHJl cykgewo+Pj4+ICsgICAgICAgICAgICBuZXRkZXZfZXJyKGRldiwKPj4+PiArICAgICAgICAgICAg ICAgICAgICJyZWZ1c2VkIHRvIGNoYW5nZSBkZXZpY2UgdHhfcXVldWVfbGVuXG4iKTsKPj4+PiAr ICAgICAgICAgICAgZGV2LT50eF9xdWV1ZV9sZW4gPSBvcmlnX2xlbjsKPj4+PiArICAgICAgICAg ICAgcmV0dXJuIC1FRkFVTFQ7Cj4+Pj4gKyAgICAgICAgfQo+Pj4+ICsgICAgfQo+Pj4+ICsKPj4+ PiAgICAgICByZXR1cm4gMDsKPj4+PiAgIH0KPj4+Pgo+Pj4gQWNrZWQtYnk6IEpvaG4gRmFzdGFi ZW5kIDxqb2huLnIuZmFzdGFiZW5kQGludGVsLmNvbT4KPj4+Cj4+PiBHcmVhdCB0aW1pbmcgSSB3 YXMganVzdCBsb29raW5nIGludG8gdGhpcyBiZWNhdXNlIEkgbmVlZCBpdCBmb3IgdGhlCj4+PiBx ZGlzYyBzaWRlLgo+Pj4KPj4+IEl0IGxvb2tzIGxpa2UgdGhpcyBjb3ZlcnMgdGhlIHN5c2ZzIGNo YW5nZSBidXQgdGhlIHR4X3F1ZXVlX2xlbiBjYW4KPj4+IGFsc28gYmUgY2hhbmdlZCB2aWEgcnRu ZXRsaW5rIGFzIHdlbGwuIFNvIHdlIG5lZWQgYW5vdGhlciBwYXRjaCBmb3IKPj4+IHRoYXQgcGF0 aCByaWdodD8KPj4+Cj4+PiAgICAgICAgICBpZiAodGJbSUZMQV9UWFFMRU5dKSB7Cj4+PiAgICAg ICAgICAgICAgICAgIHVuc2lnbmVkIGxvbmcgdmFsdWUgPSBubGFfZ2V0X3UzMih0YltJRkxBX1RY UUxFTl0pOwo+Pj4KPj4+ICAgICAgICAgICAgICAgICAgaWYgKGRldi0+dHhfcXVldWVfbGVuIF4g dmFsdWUpCj4+PiAgICAgICAgICAgICAgICAgICAgICAgICAgc3RhdHVzIHw9IERPX1NFVExJTktf Tk9USUZZOwo+Pj4KPj4+ICAgICAgICAgICAgICAgICAgZGV2LT50eF9xdWV1ZV9sZW4gPSB2YWx1 ZTsKPj4+ICAgICAgICAgIH0KPj4+Cj4+PiBUaGFua3MsCj4+PiBKb2huCj4+Pgo+Pgo+PiBSaWdo dCwgd2lsbCBkbyB0aGlzIGluIG5leHQgdmVyc2lvbi4KPj4KPj4gVGhhbmtzCj4KPiBPaywgc2lu Y2UgTWljaGFlbCBoYXMgYWNrZWQgb24gdGhlIHNlcmllcywgd2lsbCBwcmVwYXJlIGEgcGF0Y2gg b24gdG9wLgo+Cj4gVGhhbmtzIAoKU2luY2Uga2J1aWxkIHRlc3Qgcm9ib3QgaGFzIGZvdW5kIGEg bWlub3IgaXNzdWUgb24gdGhpcyBzZXJpZXMsIEkgd2lsbCAKcG9zdCB2NCB3aXRoIHRoaXMgZml4 ZWQuCgpUaGFua3MKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KVmlydHVhbGl6YXRpb24gbWFpbGluZyBsaXN0ClZpcnR1YWxpemF0aW9uQGxpc3RzLmxpbnV4 LWZvdW5kYXRpb24ub3JnCmh0dHBzOi8vbGlzdHMubGludXhmb3VuZGF0aW9uLm9yZy9tYWlsbWFu L2xpc3RpbmZvL3ZpcnR1YWxpemF0aW9u From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751845AbcF3Gvu (ORCPT ); Thu, 30 Jun 2016 02:51:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56793 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750969AbcF3Gvs (ORCPT ); Thu, 30 Jun 2016 02:51:48 -0400 Subject: Re: [PATCH net-next V3 5/6] net: introduce NETDEV_CHANGE_TX_QUEUE_LEN To: John Fastabend , mst@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, davem@davemloft.net References: <1467258779-3539-1-git-send-email-jasowang@redhat.com> <1467258779-3539-6-git-send-email-jasowang@redhat.com> <5774A67B.1060802@gmail.com> <5774AA46.3090604@redhat.com> <5774B553.5070701@redhat.com> Cc: kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, eric.dumazet@gmail.com, brouer@redhat.com From: Jason Wang Message-ID: <5774BF74.9000508@redhat.com> Date: Thu, 30 Jun 2016 14:43:00 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <5774B553.5070701@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Thu, 30 Jun 2016 06:43:06 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016年06月30日 13:59, Jason Wang wrote: > > > On 2016年06月30日 13:12, Jason Wang wrote: >> >> >> On 2016年06月30日 12:56, John Fastabend wrote: >>> On 16-06-29 08:52 PM, Jason Wang wrote: >>>> This patch introduces a new event - NETDEV_CHANGE_TX_QUEUE_LEN, this >>>> will be triggered when tx_queue_len. It could be used by net device >>>> who want to do some processing at that time. An example is tun who may >>>> want to resize tx array when tx_queue_len is changed. >>>> >>>> Signed-off-by: Jason Wang >>>> --- >>>> include/linux/netdevice.h | 1 + >>>> net/core/net-sysfs.c | 15 ++++++++++++++- >>>> 2 files changed, 15 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h >>>> index e84d9d2..7dc2ec7 100644 >>>> --- a/include/linux/netdevice.h >>>> +++ b/include/linux/netdevice.h >>>> @@ -2237,6 +2237,7 @@ struct netdev_lag_lower_state_info { >>>> #define NETDEV_PRECHANGEUPPER 0x001A >>>> #define NETDEV_CHANGELOWERSTATE 0x001B >>>> #define NETDEV_UDP_TUNNEL_PUSH_INFO 0x001C >>>> +#define NETDEV_CHANGE_TX_QUEUE_LEN 0x001E >>>> int register_netdevice_notifier(struct notifier_block *nb); >>>> int unregister_netdevice_notifier(struct notifier_block *nb); >>>> diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c >>>> index 7a0b616..6e4f347 100644 >>>> --- a/net/core/net-sysfs.c >>>> +++ b/net/core/net-sysfs.c >>>> @@ -322,7 +322,20 @@ NETDEVICE_SHOW_RW(flags, fmt_hex); >>>> static int change_tx_queue_len(struct net_device *dev, unsigned >>>> long new_len) >>>> { >>>> - dev->tx_queue_len = new_len; >>>> + int res, orig_len = dev->tx_queue_len; >>>> + >>>> + if (new_len != orig_len) { >>>> + dev->tx_queue_len = new_len; >>>> + res = call_netdevice_notifiers(NETDEV_CHANGE_TX_QUEUE_LEN, >>>> dev); >>>> + res = notifier_to_errno(res); >>>> + if (res) { >>>> + netdev_err(dev, >>>> + "refused to change device tx_queue_len\n"); >>>> + dev->tx_queue_len = orig_len; >>>> + return -EFAULT; >>>> + } >>>> + } >>>> + >>>> return 0; >>>> } >>>> >>> Acked-by: John Fastabend >>> >>> Great timing I was just looking into this because I need it for the >>> qdisc side. >>> >>> It looks like this covers the sysfs change but the tx_queue_len can >>> also be changed via rtnetlink as well. So we need another patch for >>> that path right? >>> >>> if (tb[IFLA_TXQLEN]) { >>> unsigned long value = nla_get_u32(tb[IFLA_TXQLEN]); >>> >>> if (dev->tx_queue_len ^ value) >>> status |= DO_SETLINK_NOTIFY; >>> >>> dev->tx_queue_len = value; >>> } >>> >>> Thanks, >>> John >>> >> >> Right, will do this in next version. >> >> Thanks > > Ok, since Michael has acked on the series, will prepare a patch on top. > > Thanks Since kbuild test robot has found a minor issue on this series, I will post v4 with this fixed. Thanks