From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp08.smtpout.orange.fr ([80.12.242.130]:54453 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751223AbcF3HXd (ORCPT ); Thu, 30 Jun 2016 03:23:33 -0400 Message-ID: <5774C8F2.5030802@wanadoo.fr> Date: Thu, 30 Jun 2016 09:23:30 +0200 From: =?UTF-8?Q?Jean-Pierre_Andr=c3=a9?= MIME-Version: 1.0 To: "Eric W. Biederman" , Michael j Theall CC: fuse-devel@lists.sourceforge.net, Seth Forshee , linux-fsdevel@vger.kernel.org, Miklos Szeredi Subject: Re: [fuse-devel] [RFC] fuse: Support posix ACLs References: <20160629190731.GF53123@ubuntu-hedt> <87vb0rhhpr.fsf@x220.int.ebiederm.org> In-Reply-To: <87vb0rhhpr.fsf@x220.int.ebiederm.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org List-ID: ebiederm@xmission.com (Eric W. Biederman) wrote: > "Michael j Theall" writes: > >> Going by the patch I posted a couple of years ago: >> https://sourceforge.net/p/fuse/mailman/message/33033653/ >> >> The only hole I see in your patch is that in setattr() you are not >> updating the cached acl if the ATTR_MODE is updated. The other major >> difference is that my version uses the get_acl/set_acl inode >> operations but you use that plus the xattr handlers. I'm not >> up-to-speed on the kernel so I'm not sure if you actually need to >> implement both. > > That makes an interesting question. Is it desirable to keep > inode->i_mode in sync with the posix acls in fuse or should a filesystem > that supports posix acls worry about that? Using a former implementation of ACLs within fuse at the kernel level, I got the result below. File systems expect consistency. # Using the low level interface of fuse, with use of ACLs # intended to be checked in the kernel, but not related to # access control rm -rf trydir mkdir trydir echo file > trydir/file ls -l trydir/file setfacl -m 'u::7,g::5,o::5' trydir/file ls -l trydir/file sleep 1 ls -l trydir/file -rw-r--r-- 1 root root 5 2009-09-12 12:02 trydir/file -rw-r--r-- 1 root root 5 2009-09-12 12:02 trydir/file -rwxr-xr-x 1 root root 5 2009-09-12 12:02 trydir/file Jean-Pierre