From: Peter Lieven <pl@kamp.de>
To: Cornelia Huck <cornelia.huck@de.ibm.com>, qemu-devel@nongnu.org
Cc: mst@redhat.com, famz@redhat.com, stefanha@redhat.com,
jasowang@redhat.com, marcandre.lureau@gmail.com,
pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2] virtio: Fix setting up host notifiers for vhost
Date: Thu, 30 Jun 2016 14:04:13 +0200 [thread overview]
Message-ID: <57750ABD.50102@kamp.de> (raw)
In-Reply-To: <1467287567-2632-1-git-send-email-cornelia.huck@de.ibm.com>
Am 30.06.2016 um 13:52 schrieb Cornelia Huck:
> When setting up host notifiers, virtio_bus_set_host_notifier()
> simply switches the handler. This will only work, however, if
> the ioeventfd has already been setup; this is true for dataplane,
> but not for vhost, and will completely break things if the
> ioeventfd is disabled for the device.
>
> Fix this by starting the ioeventfd on assign if that has not
> happened before, and only switch the handler if the ioeventfd
> has really been started.
>
> While we're at it, also fixup the unsetting path of
> set_host_notifier_internal().
This fixes also iSCSI + dataplane.
Peter.
next prev parent reply other threads:[~2016-06-30 12:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-30 11:52 [Qemu-devel] [PATCH v2] virtio: Fix setting up host notifiers for vhost Cornelia Huck
2016-06-30 12:04 ` Peter Lieven [this message]
2016-06-30 14:12 ` Marc-André Lureau
2016-06-30 15:07 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57750ABD.50102@kamp.de \
--to=pl@kamp.de \
--cc=cornelia.huck@de.ibm.com \
--cc=famz@redhat.com \
--cc=jasowang@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.