[Qemu-devel] REGRESSION: pcspk: convert "pit" property type from ptr to link

[Peter Lieven <pl@kamp.de>]

The above patch:

commit 873b4d3f0571a1e415cf089a67a230ea8a12d059
Author: Efimov Vasily <real@ispras.ru>
Date:   Wed Jun 22 15:24:46 2016 +0300

     pcspk: convert "pit" property type from ptr to link

adds a regression (segfault). Was this patch actually tested?

Cmdline:
x86_64-softmmu/qemu-system-x86_64 -enable-kvm

Backtrace:
#0  object_get_class (obj=obj@entry=0x0) at qom/object.c:744
No locals.
#1  0x00005555559aa061 in pit_get_channel_info (dev=<optimized out>, channel=<optimized out>, info=0x7ffff0d1d840) at hw/timer/i8254_common.c:147
         pit = 0x0
         __func__ = "pit_get_channel_info"
         s = 0x1f0
         c = <optimized out>
#2  0x00005555558d7b2c in pcspk_io_read (opaque=0x555557db4e30, addr=<optimized out>, size=<optimized out>) at hw/audio/pcspk.c:136
         ch = {gate = 255, mode = 0, initial_count = 1528560384, out = -1873283211}
#3  0x000055555579202c in memory_region_read_accessor (mr=0x555557db4eb0, addr=0, value=0x7ffff0d1da30, size=1, shift=0, mask=255, attrs=...) at /home/lieven/git/qemu/memory.c:434
         tmp = <optimized out>
#4  0x000055555578fa4b in access_with_adjusted_size (addr=addr@entry=0, value=value@entry=0x7ffff0d1da30, size=size@entry=1, access_size_min=<optimized out>, access_size_max=<optimized out>,
     access=access@entry=0x555555791ff0 <memory_region_read_accessor>, mr=mr@entry=0x555557db4eb0, attrs=attrs@entry=...) at /home/lieven/git/qemu/memory.c:591
         access_mask = 255
         access_size = 1
         i = <optimized out>
         r = 0
#5  0x00005555557940de in memory_region_dispatch_read1 (attrs=..., size=1, pval=0x7ffff0d1da30, addr=0, mr=0x555557db4eb0) at /home/lieven/git/qemu/memory.c:1181
No locals.
#6  memory_region_dispatch_read (mr=mr@entry=0x555557db4eb0, addr=addr@entry=0, pval=pval@entry=0x7ffff0d1da30, size=size@entry=1, attrs=attrs@entry=...) at /home/lieven/git/qemu/memory.c:1212
No locals.
#7  0x000055555574cf9a in address_space_read_continue (as=as@entry=0x5555560c1080 <address_space_io>, addr=addr@entry=97, attrs=..., attrs@entry=..., buf=buf@entry=0x7ffff7fef000 " \030", len=len@entry=1,
     addr1=0, l=1, mr=0x555557db4eb0) at /home/lieven/git/qemu/exec.c:2680
         ptr = <optimized out>
         val = 0
         result = 0
         release_lock = true
#8  0x000055555574d047 in address_space_read_full (as=0x5555560c1080 <address_space_io>, addr=97, addr@entry=93824994760285, attrs=..., buf=0x7ffff7fef000 " \030", len=1, len@entry=0)
     at /home/lieven/git/qemu/exec.c:2725
         l = 1
         addr1 = 0
         mr = <optimized out>
         result = 0
#9  0x000055555574d1be in address_space_read (len=0, buf=<optimized out>, attrs=..., addr=93824994760285, as=<optimized out>) at /home/lieven/git/qemu/include/exec/memory.h:1454
         result = 0
#10 address_space_rw (as=<optimized out>, addr=addr@entry=97, attrs=..., attrs@entry=..., buf=<optimized out>, len=len@entry=1, is_write=is_write@entry=false) at /home/lieven/git/qemu/exec.c:2739
No locals.
#11 0x000055555578e675 in kvm_handle_io (count=1, size=1, direction=<optimized out>, data=<optimized out>, attrs=..., port=97) at /home/lieven/git/qemu/kvm-all.c:1772
         i = 0
         ptr = <optimized out>
#12 kvm_cpu_exec (cpu=cpu@entry=0x5555565b0c60) at /home/lieven/git/qemu/kvm-all.c:1936
         attrs = {unspecified = 0, secure = 0, user = 0, requester_id = 0}
         run = 0x7ffff7fee000
         ret = <optimized out>
         run_ret = <optimized out>


Peter