From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36558) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bIbIa-000896-4H for qemu-devel@nongnu.org; Thu, 30 Jun 2016 08:42:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bIbIT-0002pk-T9 for qemu-devel@nongnu.org; Thu, 30 Jun 2016 08:42:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36734) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bIbIT-0002ol-Mn for qemu-devel@nongnu.org; Thu, 30 Jun 2016 08:42:21 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6E0E27F6B1 for ; Thu, 30 Jun 2016 12:42:20 +0000 (UTC) References: <1467289387-47575-1-git-send-email-imammedo@redhat.com> <1467289387-47575-2-git-send-email-imammedo@redhat.com> From: Marcel Apfelbaum Message-ID: <577513A9.2070300@redhat.com> Date: Thu, 30 Jun 2016 15:42:17 +0300 MIME-Version: 1.0 In-Reply-To: <1467289387-47575-2-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/4] tests: acpi: add CPU hotplug testcase List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , qemu-devel@nongnu.org Cc: mst@redhat.com On 06/30/2016 03:23 PM, Igor Mammedov wrote: > Test with: > > -smp 2,cores=3,sockets=2,maxcpus=6 > > to capture sparse APIC ID values that default > AMD CPU has in above configuration. > > Signed-off-by: Igor Mammedov > --- > NOTE to maintainer: > > following table blobs should be added to git tree as poart of this commit > after running ./tests/acpi-test-data/rebuild-expected-aml.sh > > tests/acpi-test-data/q35/APIC.cphp > tests/acpi-test-data/q35/DSDT.cphp > tests/acpi-test-data/pc/APIC.cphp > tests/acpi-test-data/pc/DSDT.cphp > --- > tests/bios-tables-test.c | 28 ++++++++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > > diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c > index 92c90dd..de4019e 100644 > --- a/tests/bios-tables-test.c > +++ b/tests/bios-tables-test.c > @@ -801,6 +801,32 @@ static void test_acpi_q35_tcg_bridge(void) > free_test_data(&data); > } > > +static void test_acpi_piix4_tcg_cphp(void) > +{ > + test_data data; > + > + memset(&data, 0, sizeof(data)); > + data.machine = MACHINE_PC; > + data.variant = ".cphp"; > + test_acpi_one("-machine accel=tcg" > + " -smp 2,cores=3,sockets=2,maxcpus=6", > + &data); > + free_test_data(&data); > +} > + > +static void test_acpi_q35_tcg_cphp(void) > +{ > + test_data data; > + > + memset(&data, 0, sizeof(data)); > + data.machine = MACHINE_Q35; > + data.variant = ".cphp"; > + test_acpi_one("-machine q35,accel=tcg" > + " -smp 2,cores=3,sockets=2,maxcpus=6", > + &data); > + free_test_data(&data); > +} > + > static uint8_t ipmi_required_struct_types[] = { > 0, 1, 3, 4, 16, 17, 19, 32, 38, 127 > }; > @@ -856,6 +882,8 @@ int main(int argc, char *argv[]) > qtest_add_func("acpi/q35/tcg/bridge", test_acpi_q35_tcg_bridge); > qtest_add_func("acpi/piix4/tcg/ipmi", test_acpi_piix4_tcg_ipmi); > qtest_add_func("acpi/q35/tcg/ipmi", test_acpi_q35_tcg_ipmi); > + qtest_add_func("acpi/piix4/tcg/cpuhp", test_acpi_piix4_tcg_cphp); > + qtest_add_func("acpi/q35/tcg/cpuhp", test_acpi_q35_tcg_cphp); > } > ret = g_test_run(); > boot_sector_cleanup(disk); > Reviewed-by: Marcel Apfelbaum Thanks, Marcel