From: Guenter Roeck <linux@roeck-us.net>
To: Thomas Pedersen <twp@codeaurora.org>, linux-watchdog@vger.kernel.org
Cc: Matthew McClintock <mmcclint@codeaurora.org>,
Wim Van Sebroeck <wim@iguana.be>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Russell King <linux@armlinux.org.uk>
Subject: Re: [PATCH v3 1/3] watchdog: qcom: update device tree bindings
Date: Thu, 30 Jun 2016 06:42:45 -0700 [thread overview]
Message-ID: <577521D5.6000800@roeck-us.net> (raw)
In-Reply-To: <1467222602-18362-1-git-send-email-twp@codeaurora.org>
On 06/29/2016 10:50 AM, Thomas Pedersen wrote:
> From: Matthew McClintock <mmcclint@codeaurora.org>
>
> Update the compatible string to align with driver and also
> add SoC specific string to DTS.
>
> CC: linux-watchdog@vger.kernel.org
> Signed-off-by: Matthew McClintock <mmcclint@codeaurora.org>
> Signed-off-by: Thomas Pedersen <twp@codeaurora.org>
>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> v2:
> Keep SoC specific compatible and add it to DTS.
> ---
> Documentation/devicetree/bindings/watchdog/qcom-wdt.txt | 2 ++
> arch/arm/boot/dts/qcom-apq8064.dtsi | 3 ++-
> arch/arm/boot/dts/qcom-ipq8064.dtsi | 3 ++-
> arch/arm/boot/dts/qcom-msm8960.dtsi | 3 ++-
> 4 files changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt b/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
> index 4726924..6b7b5ce 100644
> --- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
> +++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
> @@ -7,6 +7,8 @@ Required properties :
> "qcom,kpss-wdt-msm8960"
> "qcom,kpss-wdt-apq8064"
> "qcom,kpss-wdt-ipq8064"
> + "qcom,kpss-timer"
> + "qcom,scss-timer"
>
> - reg : shall contain base register location and length
> - clocks : shall contain the input clock
> diff --git a/arch/arm/boot/dts/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom-apq8064.dtsi
> index df96ccd..e318d04 100644
> --- a/arch/arm/boot/dts/qcom-apq8064.dtsi
> +++ b/arch/arm/boot/dts/qcom-apq8064.dtsi
> @@ -247,7 +247,8 @@
> };
>
> timer@200a000 {
> - compatible = "qcom,kpss-timer", "qcom,msm-timer";
> + compatible = "qcom,kpss-timer",
> + "qcom,kpss-wdt-apq8064", "qcom,msm-timer";
> interrupts = <1 1 0x301>,
> <1 2 0x301>,
> <1 3 0x301>;
> diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi
> index 2601a90..2e37557 100644
> --- a/arch/arm/boot/dts/qcom-ipq8064.dtsi
> +++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi
> @@ -122,7 +122,8 @@
> };
>
> timer@200a000 {
> - compatible = "qcom,kpss-timer", "qcom,msm-timer";
> + compatible = "qcom,kpss-timer",
> + "qcom,kpss-wdt-ipq8064", "qcom,msm-timer";
> interrupts = <1 1 0x301>,
> <1 2 0x301>,
> <1 3 0x301>,
> diff --git a/arch/arm/boot/dts/qcom-msm8960.dtsi b/arch/arm/boot/dts/qcom-msm8960.dtsi
> index da05e28..288f56e 100644
> --- a/arch/arm/boot/dts/qcom-msm8960.dtsi
> +++ b/arch/arm/boot/dts/qcom-msm8960.dtsi
> @@ -87,7 +87,8 @@
> };
>
> timer@200a000 {
> - compatible = "qcom,kpss-timer", "qcom,msm-timer";
> + compatible = "qcom,kpss-timer",
> + "qcom,kpss-wdt-msm8960", "qcom,msm-timer";
> interrupts = <1 1 0x301>,
> <1 2 0x301>,
> <1 3 0x301>;
>
next prev parent reply other threads:[~2016-06-30 13:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 17:50 [PATCH v3 1/3] watchdog: qcom: update device tree bindings Thomas Pedersen
2016-06-29 17:50 ` [PATCH v3 2/3] watchdog: qcom: add option for standalone watchdog not in timer block Thomas Pedersen
2016-06-30 13:44 ` Guenter Roeck
2016-07-17 20:21 ` Wim Van Sebroeck
2016-06-29 17:50 ` [PATCH v3 3/3] watchdog: qcom: configure BARK time in addition to BITE time Thomas Pedersen
2016-07-17 20:20 ` Wim Van Sebroeck
2016-06-30 13:42 ` Guenter Roeck [this message]
2016-07-17 20:20 ` [PATCH v3 1/3] watchdog: qcom: update device tree bindings Wim Van Sebroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=577521D5.6000800@roeck-us.net \
--to=linux@roeck-us.net \
--cc=andy.gross@linaro.org \
--cc=david.brown@linaro.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mmcclint@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=twp@codeaurora.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.