From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] SPL: sunxi: don't force .BSS into DRAM
Date: Thu, 30 Jun 2016 23:09:44 +0200 [thread overview]
Message-ID: <57758A98.2000204@denx.de> (raw)
In-Reply-To: <874m8afucb.fsf@dell.be.48ers.dk>
On 06/30/2016 07:40 PM, Peter Korsgaard wrote:
>>>>>> "Andre" == Andre Przywara <andre.przywara@arm.com> writes:
>
> Hi,
>
> > I really don't know. This simple bug has cost me at least two hours
> > yesterday, since it was the rather innocent access to a variable that
> > caused the issue. And if it wouldn't have been for Siarhei to point me
> > in the right direction I'd have spend even more time to find a fix.
>
> Agreed. The toolchain will complain loudly about an overflow of SRAM
> space, but not about BSS access before DRAM is available.
>
I see two problems:
- this fixes sunxi and possibly leaves other platforms unfixed
- when the spl on sunxi grows some more, the bss won't fit and you'll
have a problem again, except much bigger this time
I'd rather have this fixed on tiny-printf level with a bit of
documentation on why that's done the way it's done.
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2016-06-30 21:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160630002500.2817-1-andre.przywara@arm.com>
[not found] ` <af86054b-8fcc-3b58-6889-7af02cd7a9fc@redhat.com>
2016-06-30 15:43 ` [U-Boot] [PATCH] SPL: sunxi: don't force .BSS into DRAM Andre Przywara
2016-06-30 17:40 ` Peter Korsgaard
2016-06-30 21:09 ` Marek Vasut [this message]
[not found] ` <CAPnjgZ2ajoU90kSNMoHVhbXN4CdeKzs5-SQ-Hq-xePfC0brJ3A@mail.gmail.com>
2016-07-02 11:49 ` Hans de Goede
2016-07-03 21:15 ` Simon Glass
2016-07-03 22:24 ` André Przywara
2016-06-30 0:29 Andre Przywara
2016-06-30 1:54 ` Marek Vasut
2016-06-30 8:50 ` Andre Przywara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57758A98.2000204@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.