From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Wang Subject: Re: [PATCH net-next V4 0/6] switch to use tx skb array in tun Date: Fri, 1 Jul 2016 14:04:01 +0800 Message-ID: <577607D1.9070307@redhat.com> References: <1467269136-8082-1-git-send-email-jasowang@redhat.com> <20160630184242-mutt-send-email-mst@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20160630184242-mutt-send-email-mst@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: "Michael S. Tsirkin" Cc: kvm@vger.kernel.org, eric.dumazet@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, brouer@redhat.com, davem@davemloft.net List-Id: virtualization@lists.linuxfoundation.org CgpPbiAyMDE25bm0MDbmnIgzMOaXpSAyMzo0NSwgTWljaGFlbCBTLiBUc2lya2luIHdyb3RlOgo+ IE9uIFRodSwgSnVuIDMwLCAyMDE2IGF0IDAyOjQ1OjMwUE0gKzA4MDAsIEphc29uIFdhbmcgd3Jv dGU6Cj4+ID5IaSBhbGw6Cj4+ID4KPj4gPlRoaXMgc2VyaWVzIHRyaWVzIHRvIHN3aXRjaCB0byB1 c2Ugc2tiIGFycmF5IGluIHR1bi4gVGhpcyBpcyB1c2VkIHRvCj4+ID5lbGltaW5hdGUgdGhlIHNw aW5sb2NrIGNvbnRlbnRpb24gYmV0d2VlbiBwcm9kdWNlciBhbmQgY29uc3VtZXIuIFRoZQo+PiA+ Y29udmVyc2lvbiB3YXMgc3RyYWlnaHRmb3J3YXJkOiBqdXN0IGludHJvZGNlIGEgdHggc2tiIGFy cmF5IGFuZCB1c2UKPj4gPml0IGluc3RlYWQgb2Ygc2tfcmVjZWl2ZV9xdWV1ZS4KPj4gPgo+PiA+ QSBtaW5vciBpc3N1ZSBpcyB0byBrZWVwIHRoZSB0eF9xdWV1ZV9sZW4gYmVoYXZpb3VyLCBzaW5j ZSB0dW4gdXNlZCB0bwo+PiA+dXNlIGl0IGZvciB0aGUgbGVuZ3RoIG9mIHNrX3JlY2VpdmVfcXVl dWUuIFRoaXMgaXMgZG9uZSB0aHJvdWdoOgo+PiA+Cj4+ID4tIGFkZCB0aGUgYWJpbGl0eSB0byBy ZXNpemUgbXVsdGlwbGUgcmluZ3MgYXQgb25jZSB0byBhdm9pZCBoYW5kbGluZwo+PiA+ICAgcGFy dGlhbCByZXNpemUgZmFpbHVyZSBmb3IgbXV0aXBsZSByaW5ncy4KPj4gPi0gYWRkIHRoZSBzdXBw b3J0IGZvciB6ZXJvIGxlbmd0aCByaW5nLgo+PiA+LSBpbnRyb2R1Y2UgYSBub3RpZmllciB3aGlj aCB3YXMgdHJpZ2dlcmVkIHdoZW4gdHhfcXVldWVfbGVuIHdhcwo+PiA+ICAgY2hhbmdlZCBmb3Ig YSBuZXRkZXYuCj4+ID4tIHJlc2l6ZSBhbGwgcXVldWVzIGR1cmluZyB0aGUgdHhfcXVldWVfbGVu IGNoYW5naW5nLgo+PiA+Cj4+ID5UZXN0cyBzaG93cyBhYm91dCAxNSUgaW1wcm92ZW1lbnQgb24g Z3Vlc3QgcnggcHBzOgo+PiA+Cj4+ID5CZWZvcmU6IH4xMzAwMDAwcHBzCj4+ID5BZnRlciA6IH4x NTAwMDAwcHBzCj4gQWNrZWQtYnk6IE1pY2hhZWwgUy4gVHNpcmtpbjxtc3RAcmVkaGF0LmNvbT4K Pgo+IEFja2VkLWZyb20tYWx0aXR1ZGU6IDM0Njk3IGZlZXQuCgpXb3csIHRoYW5rcyBhIGxvdCEK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KVmlydHVhbGl6 YXRpb24gbWFpbGluZyBsaXN0ClZpcnR1YWxpemF0aW9uQGxpc3RzLmxpbnV4LWZvdW5kYXRpb24u b3JnCmh0dHBzOi8vbGlzdHMubGludXhmb3VuZGF0aW9uLm9yZy9tYWlsbWFuL2xpc3RpbmZvL3Zp cnR1YWxpemF0aW9u From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752160AbcGAGGV (ORCPT ); Fri, 1 Jul 2016 02:06:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38350 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751674AbcGAGGS (ORCPT ); Fri, 1 Jul 2016 02:06:18 -0400 Subject: Re: [PATCH net-next V4 0/6] switch to use tx skb array in tun To: "Michael S. Tsirkin" References: <1467269136-8082-1-git-send-email-jasowang@redhat.com> <20160630184242-mutt-send-email-mst@redhat.com> Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, davem@davemloft.net, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, eric.dumazet@gmail.com, brouer@redhat.com From: Jason Wang Message-ID: <577607D1.9070307@redhat.com> Date: Fri, 1 Jul 2016 14:04:01 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <20160630184242-mutt-send-email-mst@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Fri, 01 Jul 2016 06:04:07 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016年06月30日 23:45, Michael S. Tsirkin wrote: > On Thu, Jun 30, 2016 at 02:45:30PM +0800, Jason Wang wrote: >> >Hi all: >> > >> >This series tries to switch to use skb array in tun. This is used to >> >eliminate the spinlock contention between producer and consumer. The >> >conversion was straightforward: just introdce a tx skb array and use >> >it instead of sk_receive_queue. >> > >> >A minor issue is to keep the tx_queue_len behaviour, since tun used to >> >use it for the length of sk_receive_queue. This is done through: >> > >> >- add the ability to resize multiple rings at once to avoid handling >> > partial resize failure for mutiple rings. >> >- add the support for zero length ring. >> >- introduce a notifier which was triggered when tx_queue_len was >> > changed for a netdev. >> >- resize all queues during the tx_queue_len changing. >> > >> >Tests shows about 15% improvement on guest rx pps: >> > >> >Before: ~1300000pps >> >After : ~1500000pps > Acked-by: Michael S. Tsirkin > > Acked-from-altitude: 34697 feet. Wow, thanks a lot!