From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Zyngier Subject: Re: [PATCH] updated: arm64: KVM: vgic: deal with GIC sub-page alignment Date: Fri, 1 Jul 2016 10:20:46 +0100 Message-ID: <577635EE.1010002@arm.com> References: <5775F854.3060306@riken.jp> <57762C8A.8060105@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id D525C49B1A for ; Fri, 1 Jul 2016 05:15:31 -0400 (EDT) Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CkU6RZaxIE3e for ; Fri, 1 Jul 2016 05:15:30 -0400 (EDT) Received: from foss.arm.com (foss.arm.com [217.140.101.70]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 89A9349AF5 for ; Fri, 1 Jul 2016 05:15:30 -0400 (EDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu To: Itaru Kitayama Cc: kvmarm@lists.cs.columbia.edu List-Id: kvmarm@lists.cs.columbia.edu On 01/07/16 09:59, Itaru Kitayama wrote: > Marc, > That's good news. Can I assume you'd keep the > KVM_DEV_ARM_VGIC_GRP_ADDR_OFFSET attribute, or would you introduce new > ones? I ask because either way we need the userland support, be it QEMU > or kvmtool. I'm carrying the small QEMU patch at this moment. You can look at the kvm-arm64/gicv-align branch in my tree, which contains some of the stuff. At the moment, the attribute is named KVM_DEV_ARM_VGIC_GRP_GICC_OFFSET, but I don't mind changing the name. Thanks, M. > > > On 7/1/16 5:40 PM, Marc Zyngier wrote: >> Itaru, >> >> On 01/07/16 05:57, Itaru Kitayama wrote: >>> This is merely an update to the patch Marc posted in 2014: >>> >>> https://lists.cs.columbia.edu/pipermail/kvmarm/2014-June/010055.html >>> >>> This updated patch is against today's current kvmarm git tree tag, >>> kvm-for-arm-v4.7-rc6. >>> >>> The GIC CPU interface is always 4k aligned. If the host is using >>> 64k pages, it is critical to place the guest's GICC interface at the >>> same relative alignment as the host's GICV. Failure to do so results >>> in an impossibility for the guest to deal with interrupts. >>> >>> Add a KVM_DEV_ARM_VGIC_GRP_ADDR_OFFSET attribute for the VGIC, allowing >>> userspace to retrieve the GICV offset in a page. It becomes then trivial >>> to adjust the GICC base address for the guest. >>> >>> Signed-off-by: Marc Zyngier > >>> Signed-off-by: Itaru Kitayama >> >> I'm working on a much more complete patch series that deals with this >> and a bit more. Hopefully for the 4.9 time frame. >> >> Thanks, >> >> M. >> > -- Jazz is not dead. It just smells funny...