From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58437) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bJ635-0005E1-Tm for qemu-devel@nongnu.org; Fri, 01 Jul 2016 17:32:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bJ631-0003QU-Kf for qemu-devel@nongnu.org; Fri, 01 Jul 2016 17:32:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54519) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bJ631-0003QK-Cg for qemu-devel@nongnu.org; Fri, 01 Jul 2016 17:32:27 -0400 References: <1467215765-22981-1-git-send-email-armbru@redhat.com> <1467215765-22981-2-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <5776E169.8080404@redhat.com> Date: Fri, 1 Jul 2016 15:32:25 -0600 MIME-Version: 1.0 In-Reply-To: <1467215765-22981-2-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="TqmEFUwkwkLTNNqgN739PVFgkRxKGmBWS" Subject: Re: [Qemu-devel] [PATCH 01/18] Use #include "..." for our own headers, <...> for others List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, rth@twiddle.net, riku.voipio@iki.fi, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --TqmEFUwkwkLTNNqgN739PVFgkRxKGmBWS From: Eric Blake To: Markus Armbruster , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, rth@twiddle.net, riku.voipio@iki.fi, pbonzini@redhat.com Message-ID: <5776E169.8080404@redhat.com> Subject: Re: [Qemu-devel] [PATCH 01/18] Use #include "..." for our own headers, <...> for others References: <1467215765-22981-1-git-send-email-armbru@redhat.com> <1467215765-22981-2-git-send-email-armbru@redhat.com> In-Reply-To: <1467215765-22981-2-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/29/2016 09:55 AM, Markus Armbruster wrote: > Tracked down with an ugly, brittle and probably buggy Perl script. >=20 > Also move includes converted to <...> up so they get included before > ours where that's obviously okay. >=20 > Signed-off-by: Markus Armbruster > --- > +++ b/qga/vss-win32/provider.cpp > @@ -12,8 +12,8 @@ > =20 > #include "qemu/osdep.h" > #include "vss-common.h" > -#include "inc/win2003/vscoordint.h" > -#include "inc/win2003/vsprov.h" > +#include > +#include Worth hoisting <> before "" in this file? > =20 > #define VSS_TIMEOUT_MSEC (60*1000) > =20 > diff --git a/qga/vss-win32/requester.cpp b/qga/vss-win32/requester.cpp > index 889052d..0cd2f0e 100644 > --- a/qga/vss-win32/requester.cpp > +++ b/qga/vss-win32/requester.cpp > @@ -13,8 +13,8 @@ > #include "qemu/osdep.h" > #include "vss-common.h" > #include "requester.h" > -#include "inc/win2003/vswriter.h" > -#include "inc/win2003/vsbackup.h" > +#include > +#include Ditto. > +++ b/tests/tcg/xtensa/linker.ld.S > @@ -1,4 +1,4 @@ > -#include > +#include "core-isa.h" > =20 Just making sure that "" vs. <> isn't going to hurt assembler files, since the rules on preprocessing those may be different. Reviewed-by: Eric Blake Tested-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --TqmEFUwkwkLTNNqgN739PVFgkRxKGmBWS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXduFpAAoJEKeha0olJ0NqHmUH/2doaCZMSo04s7i6KdcHtnCb N3VbXrpYwy67MNj2NJvuoNNOilDEW1WZ+K8wd7PiJWRnTCDq8vxSr7Hi9EKh5Rk3 IGJg9Vx6SfJvvpLO/vVqS1SpmfNRGmxC6vwiuvSkamiagl+YL08EMjm0KgVtAL8z pCVIh0IDglQG1HEMPMa92HK1hOawm4GLHQ172GPvDW2ue25RG3pPBm0+zK80MrWo teOna0fkdKzy1iR5RGAqWfhUBgArTGNb1/MqsSRP/K2A+nZVqdHpkh/u+kHt+b6e /21epj1XaXQXLGNRu4mBjoUn4Mj7fniCtoD48zKKFEc7mKhDG93KUdBFj1CZFm4= =EPf2 -----END PGP SIGNATURE----- --TqmEFUwkwkLTNNqgN739PVFgkRxKGmBWS--