From mboxrd@z Thu Jan 1 00:00:00 1970 From: Caesar Wang Subject: Re: [PATCH v2] arm64: dts: rockchip: add the power domain node for rk3399 Date: Sat, 02 Jul 2016 09:34:49 +0800 Message-ID: <57771A39.8060606@rock-chips.com> References: <1467347575-11806-1-git-send-email-wxt@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Doug Anderson , =?UTF-8?B?5ZC06Imv5bOw?= Cc: Tao Huang , =?UTF-8?B?SGVpa28gU3TDvGJuZXI=?= , Elaine Zhang , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "open list:ARM/Rockchip SoC..." , Eddie Cai , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , Caesar Wang List-Id: linux-rockchip.vger.kernel.org Ck9uIDIwMTblubQwN+aciDAy5pelIDAwOjU2LCBEb3VnIEFuZGVyc29uIHdyb3RlOgo+IENhZXNh cgo+Cj4gT24gVGh1LCBKdW4gMzAsIDIwMTYgYXQgOTozMiBQTSwgQ2Flc2FyIFdhbmcgPHd4dEBy b2NrLWNoaXBzLmNvbT4gd3JvdGU6Cj4+IEZyb206IEVsYWluZSBaaGFuZyA8emhhbmdxaW5nQHJv Y2stY2hpcHMuY29tPgo+Pgo+PiBJbiBvcmRlciB0byBtZWV0IGxvdyBwb3dlciByZXF1aXJlbWVu dHMsIGEgcG93ZXIgbWFuYWdlbWVudCB1bml0IChQTVUpIGlzCj4+IGRlc2lnbmVkIGZvciBjb250 cm9sbGluZyBwb3dlciByZXNvdXJjZXMgaW4gUkszMzk5LiBUaGUgUkszMzk5IFBNVSBpcwo+PiBk ZWRpY2F0ZWQgZm9yIG1hbmFnaW5nIHRoZSBwb3dlciBvZiB0aGUgd2hvbGUgY2hpcC4KPj4KPj4g MS4gYWRkIHBkIG5vZGUgZm9yIFJLMzM5OSBTb2MKPj4gMi4gY3JlYXRlIHBvd2VyIGRvbWFpbiB0 cmVlCj4+IDMuIGFkZCBxb3Mgbm9kZSBmb3IgZG9tYWluCj4+Cj4+ICBGcm9tIHRoZSBEVC9iaW5k cyBhbmQgZHJpdmVyIGNhbiBnZXQgbW9yZSBkZXRhaWwgaW5mb3JtYXRpb246Cj4+IFRoZSBkcml2 ZXI6Cj4+ICAgICAgICAgIGRyaXZlcnMvc29jL3JvY2tjaGlwL3BtX2RvbWFpbnMuYwo+PiBUaGUg ZG9jdW1lbnQ6Cj4+ICAgICAgICAgIERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9z b2Mvcm9ja2NoaXAvcG93ZXJfZG9tYWluLnR4dAo+PiAtLS0KPj4KPj4gQ2hhbmdlcyBpbiB2MjoK Pj4gLSBBcyBEb3VnL0hlaWtvIGNvbW1uZXRzIG9uIGh0dHBzOi8vcGF0Y2h3b3JrLmtlcm5lbC5v cmcvcGF0Y2gvOTIwNjQxNS8uCj4+ICAgIGRyb3AgdGhlIGRlYnVnZnMtZHVtcCBhbmQgQWRkIHRo ZSBjb21tZW50cyBmb3IgYWxwaGFiZXRpY2FsIG9yZGVyLgo+Pgo+PiBOb3RlOiBBcyB0aGUgVFJN IGxpc3RzIG1hbnkgdm9sdGFnZSBkb21haW5zIGFuZCBwb3dlciBkb21haW5zLCB0aGVuCj4+IGlu IGFjdHVhbCB3ZSBqdXN0IG5lZWQgY29udHJvbCBzb21lIGRvbWFpbnMgZm9yIGRyaXZlci4KPj4g RHVlIHRvIHNvbWUgZG9tYWlucyAoZS5nLiBlbW1jLCB1c2IsIGNvcmUpLi4uV2UgY2FuJ3QgdHVy biBvZmYgaXQgb24KPj4gYm9vdHVwLgo+IEknbSBjdXJpb3VzOiB3aHkgY2FuJ3QgeW91IHR1cm4g b2ZmIFVTQiBwb3dlciBkb21haW5zIGlmIGEgYm9hcmQKPiBkb2Vzbid0IHVzYiBVU0I/ICAuLi5v ciBHTUFDIG9uIGJvYXJkcyB0aGF0IGRvbid0IHVzZSBFdGhlcm5ldD8gIC4uLm9yCj4gZURQIG9u IGJvYXJkcyB0aGF0IGRvbid0IHVzZSBFRFA/Cj4KPiBNYXliZSB0aGUgZHJpdmVyIGZvciB0aGVz ZSB0aGluZ3MgaXNuJ3QgcmVhZHkgdG8gaGFuZGxlIHBvd2VyIGRvbWFpbnMKPiB5ZXQgc28gdGhh dCdzIHdoeSB0aGV5IGFyZSBsZWZ0IG91dCBmb3Igbm93Pwo+Cj4gSXQgc2VlbXMgbGlrZSBHTUFD IGNvdWxkIGF0IGxlYXN0IGJlIGFkZGVkIGJlY2F1c2Ugd2UgZG9uJ3QgZXZlbiBoYXZlCj4gdGhl IEdNQUMgbGlzdGVkIGluIHRoZSBjdXJyZW50IGRldmljZSB0cmVlIHNvIHRoZXJlZm9yZSB0aGVy ZSBjYW4ndCBiZQo+IGFueSB1c2VycyBvZiBpdC4gIFdoZW4gaXQncyBhZGRlZCB3ZSBjYW4gbWFr ZSBzdXJlIHRoYXQgdGhlIHBvd2VyCj4gZG9tYWlucyBhcmUgYWRkZWQuCgpBdCBsZWFzdCwgdGhl IGdtYWMgaGFkIGJlZW4gc3VwcG9ydGVkIGluIHJvY2tjaGlwIGluc2lkZS4KVGhhdCdzIHNlZW0g dGhlIGdtYWMgZHJpdmVyIGNhbid0IGhhbmRsZSB0aGUgcG93ZXIgZG9tYWluIGVub3VnaC4KLS0K CkZyYW5rbHksIEknbSBubyB0ZXN0IHRoZSBHTUFD77yMdGhlbiB0aGlzIHBhdGNoIHNob3VsZCBz dXBwb3J0IG1vc3Qgb2YgCmRldmljZXMuCldlIGNhbiBzZW5kIGFub3RoZXIgcGF0Y2ggdG8gc3Vw cG9ydCBpdCBpZiBzb21lb25l77yIdXNiL2dtYWMpIGNhbiBoYW5kbGUgCnRoZSBwb3dlciBkb21h aW4uCgo+Cj4gSSB0aGluayBpbiB0aGUgY3VycmVudCB1cHN0cmVhbSBkdHNpIGZpbGUgdGhlcmUg aXMgYWxzbyBubyB4aGNpIG5vZGUsCj4gc28gZG9lcyB0aGF0IG1lYW4geW91IGNvdWxkIGFkZCB0 aGUgVVNCMyBwb3dlciBkb21haW4/Cj4KPgoKd2lsbGFtQFJLLCB3aGF0J3MgdGhpbmsgb2YgaXTv vJ8KCj4+IFNpZ25lZC1vZmYtYnk6IEVsYWluZSBaaGFuZyA8emhhbmdxaW5nQHJvY2stY2hpcHMu Y29tPgo+PiBTaWduZWQtb2ZmLWJ5OiBDYWVzYXIgV2FuZyA8d3h0QHJvY2stY2hpcHMuY29tPgo+ PiBDYzogbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCj4+IENjOiBsaW51eC1y b2NrY2hpcEBsaXN0cy5pbmZyYWRlYWQub3JnCj4+IENjOiBIZWlrbyBTdHVlYm5lciA8aGVpa29A c250ZWNoLmRlPgo+Pgo+PiAtLS0KPj4gICBhcmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlwL3Jr MzM5OS5kdHNpIHwgMTc5ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKPj4gICAxIGZp bGUgY2hhbmdlZCwgMTc5IGluc2VydGlvbnMoKykKPj4KPj4gZGlmZiAtLWdpdCBhL2FyY2gvYXJt NjQvYm9vdC9kdHMvcm9ja2NoaXAvcmszMzk5LmR0c2kgYi9hcmNoL2FybTY0L2Jvb3QvZHRzL3Jv Y2tjaGlwL3JrMzM5OS5kdHNpCj4+IGluZGV4IGE2ZGQ2MjMuLjEwM2UxODUgMTAwNjQ0Cj4+IC0t LSBhL2FyY2gvYXJtNjQvYm9vdC9kdHMvcm9ja2NoaXAvcmszMzk5LmR0c2kKPj4gKysrIGIvYXJj aC9hcm02NC9ib290L2R0cy9yb2NrY2hpcC9yazMzOTkuZHRzaQo+PiBAQCAtNDUsNiArNDUsNyBA QAo+PiAgICNpbmNsdWRlIDxkdC1iaW5kaW5ncy9pbnRlcnJ1cHQtY29udHJvbGxlci9hcm0tZ2lj Lmg+Cj4+ICAgI2luY2x1ZGUgPGR0LWJpbmRpbmdzL2ludGVycnVwdC1jb250cm9sbGVyL2lycS5o Pgo+PiAgICNpbmNsdWRlIDxkdC1iaW5kaW5ncy9waW5jdHJsL3JvY2tjaGlwLmg+Cj4+ICsjaW5j bHVkZSA8ZHQtYmluZGluZ3MvcG93ZXIvcmszMzk5LXBvd2VyLmg+Cj4+ICAgI2luY2x1ZGUgPGR0 LWJpbmRpbmdzL3RoZXJtYWwvdGhlcm1hbC5oPgo+Pgo+PiAgIC8gewo+PiBAQCAtNTk0LDYgKzU5 NSwxODQgQEAKPj4gICAgICAgICAgICAgICAgICBzdGF0dXMgPSAiZGlzYWJsZWQiOwo+PiAgICAg ICAgICB9Owo+Pgo+PiArICAgICAgIHFvc19oZGNwOiBxb3NfaGRjcEBmZmE5MDAwMCB7Cj4+ICsg ICAgICAgICAgICAgICBjb21wYXRpYmxlID0gInN5c2NvbiI7Cj4+ICsgICAgICAgICAgICAgICBy ZWcgPSA8MHgwIDB4ZmZhOTAwMDAgMHgwIDB4MjA+Owo+PiArICAgICAgIH07Cj4+ICsKPj4gKyAg ICAgICBxb3NfaWVwOiBxb3NfaWVwQGZmYTk4MDAwIHsKPj4gKyAgICAgICAgICAgICAgIGNvbXBh dGlibGUgPSAic3lzY29uIjsKPj4gKyAgICAgICAgICAgICAgIHJlZyA9IDwweDAgMHhmZmE5ODAw MCAweDAgMHgyMD47Cj4+ICsgICAgICAgfTsKPj4gKwo+PiArICAgICAgIHFvc19pc3AwX20wOiBx b3NfaXNwMF9tMEBmZmFhMDAwMCB7Cj4+ICsgICAgICAgICAgICAgICBjb21wYXRpYmxlID0gInN5 c2NvbiI7Cj4+ICsgICAgICAgICAgICAgICByZWcgPSA8MHgwIDB4ZmZhYTAwMDAgMHgwIDB4MjA+ Owo+PiArICAgICAgIH07Cj4+ICsKPj4gKyAgICAgICBxb3NfaXNwMF9tMTogcW9zX2lzcDBfbTFA ZmZhYTAwODAgewo+PiArICAgICAgICAgICAgICAgY29tcGF0aWJsZSA9ICJzeXNjb24iOwo+PiAr ICAgICAgICAgICAgICAgcmVnID0gPDB4MCAweGZmYWEwMDgwIDB4MCAweDIwPjsKPj4gKyAgICAg ICB9Owo+PiArCj4+ICsgICAgICAgcW9zX2lzcDFfbTA6IHFvc19pc3AxX20wQGZmYWE4MDAwIHsK Pj4gKyAgICAgICAgICAgICAgIGNvbXBhdGlibGUgPSAic3lzY29uIjsKPj4gKyAgICAgICAgICAg ICAgIHJlZyA9IDwweDAgMHhmZmFhODAwMCAweDAgMHgyMD47Cj4+ICsgICAgICAgfTsKPj4gKwo+ PiArICAgICAgIHFvc19pc3AxX20xOiBxb3NfaXNwMV9tMUBmZmFhODA4MCB7Cj4+ICsgICAgICAg ICAgICAgICBjb21wYXRpYmxlID0gInN5c2NvbiI7Cj4+ICsgICAgICAgICAgICAgICByZWcgPSA8 MHgwIDB4ZmZhYTgwODAgMHgwIDB4MjA+Owo+PiArICAgICAgIH07Cj4+ICsKPj4gKyAgICAgICBx b3NfcmdhX3I6IHFvc19yZ2FfckBmZmFiMDAwMCB7Cj4+ICsgICAgICAgICAgICAgICBjb21wYXRp YmxlID0gInN5c2NvbiI7Cj4+ICsgICAgICAgICAgICAgICByZWcgPSA8MHgwIDB4ZmZhYjAwMDAg MHgwIDB4MjA+Owo+PiArICAgICAgIH07Cj4+ICsKPj4gKyAgICAgICBxb3NfcmdhX3c6IHFvc19y Z2Ffd0BmZmFiMDA4MCB7Cj4+ICsgICAgICAgICAgICAgICBjb21wYXRpYmxlID0gInN5c2NvbiI7 Cj4+ICsgICAgICAgICAgICAgICByZWcgPSA8MHgwIDB4ZmZhYjAwODAgMHgwIDB4MjA+Owo+PiAr ICAgICAgIH07Cj4+ICsKPj4gKyAgICAgICBxb3NfdmlkZW9fbTA6IHFvc192aWRlb19tMEBmZmFi ODAwMCB7Cj4+ICsgICAgICAgICAgICAgICBjb21wYXRpYmxlID0gInN5c2NvbiI7Cj4+ICsgICAg ICAgICAgICAgICByZWcgPSA8MHgwIDB4ZmZhYjgwMDAgMHgwIDB4MjA+Owo+PiArICAgICAgIH07 Cj4+ICsKPj4gKyAgICAgICBxb3NfdmlkZW9fbTFfcjogcW9zX3ZpZGVvX20xX3JAZmZhYzAwMDAg ewo+PiArICAgICAgICAgICAgICAgY29tcGF0aWJsZSA9ICJzeXNjb24iOwo+PiArICAgICAgICAg ICAgICAgcmVnID0gPDB4MCAweGZmYWMwMDAwIDB4MCAweDIwPjsKPj4gKyAgICAgICB9Owo+PiAr Cj4+ICsgICAgICAgcW9zX3ZpZGVvX20xX3c6IHFvc192aWRlb19tMV93QGZmYWMwMDgwIHsKPj4g KyAgICAgICAgICAgICAgIGNvbXBhdGlibGUgPSAic3lzY29uIjsKPj4gKyAgICAgICAgICAgICAg IHJlZyA9IDwweDAgMHhmZmFjMDA4MCAweDAgMHgyMD47Cj4+ICsgICAgICAgfTsKPj4gKwo+PiAr ICAgICAgIHFvc192b3BfYmlnX3I6IHFvc192b3BfYmlnX3JAZmZhYzgwMDAgewo+PiArICAgICAg ICAgICAgICAgY29tcGF0aWJsZSA9ICJzeXNjb24iOwo+PiArICAgICAgICAgICAgICAgcmVnID0g PDB4MCAweGZmYWM4MDAwIDB4MCAweDIwPjsKPj4gKyAgICAgICB9Owo+PiArCj4+ICsgICAgICAg cW9zX3ZvcF9iaWdfdzogcW9zX3ZvcF9iaWdfd0BmZmFjODA4MCB7Cj4+ICsgICAgICAgICAgICAg ICBjb21wYXRpYmxlID0gInN5c2NvbiI7Cj4+ICsgICAgICAgICAgICAgICByZWcgPSA8MHgwIDB4 ZmZhYzgwODAgMHgwIDB4MjA+Owo+PiArICAgICAgIH07Cj4+ICsKPj4gKyAgICAgICBxb3Nfdm9w X2xpdHRsZTogcW9zX3ZvcF9saXR0bGVAZmZhZDAwMDAgewo+PiArICAgICAgICAgICAgICAgY29t cGF0aWJsZSA9ICJzeXNjb24iOwo+PiArICAgICAgICAgICAgICAgcmVnID0gPDB4MCAweGZmYWQw MDAwIDB4MCAweDIwPjsKPj4gKyAgICAgICB9Owo+PiArCj4+ICsgICAgICAgcW9zX2dwdTogcW9z X2dwdUBmZmFlMDAwMCB7Cj4+ICsgICAgICAgICAgICAgICBjb21wYXRpYmxlID0gInN5c2NvbiI7 Cj4+ICsgICAgICAgICAgICAgICByZWcgPSA8MHgwIDB4ZmZhZTAwMDAgMHgwIDB4MjA+Owo+PiAr ICAgICAgIH07Cj4+ICsKPj4gKyAgICAgICBwbXU6IHBvd2VyLW1hbmFnZW1lbnRAZmYzMTAwMDAg ewo+PiArICAgICAgICAgICAgICAgY29tcGF0aWJsZSA9ICJyb2NrY2hpcCxyazMzOTktcG11Iiwg InN5c2NvbiIsICJzaW1wbGUtbWZkIjsKPj4gKyAgICAgICAgICAgICAgIHJlZyA9IDwweDAgMHhm ZjMxMDAwMCAweDAgMHgxMDAwPjsKPj4gKwo+PiArICAgICAgICAgICAgICAgLyoKPj4gKyAgICAg ICAgICAgICAgICAqIE5vdGU6IFJLMzM5OSBzdXBwb3J0cyA2IHZvbHRhZ2UgZG9tYWlucyBpbmNs dWRpbmcgVkRfQ09SRV9MLAo+PiArICAgICAgICAgICAgICAgICogVkRfQ09SRV9CLCBWRF9DRU5U RVIsIFZEX0dQVSwgVkRfTE9HSUMgYW5kIFZEX1BNVS4KPj4gKyAgICAgICAgICAgICAgICAqIFNv bWUgb2YgdGhlIHBvd2VyIGRvbWFpbnMgYXJlIGdyb3VwZWQgdG9nZXRoZXIgZm9yIGV2ZXJ5Cj4+ ICsgICAgICAgICAgICAgICAgKiB2b2x0YWdlIGRvbWFpbi4KPj4gKyAgICAgICAgICAgICAgICAq IFRoZSBkZXRhaWwgY29udGVudHMgYXMgYmVsb3cuCj4+ICsgICAgICAgICAgICAgICAgKi8KPj4g KyAgICAgICAgICAgICAgIHBvd2VyOiBwb3dlci1jb250cm9sbGVyIHsKPj4gKyAgICAgICAgICAg ICAgICAgICAgICAgc3RhdHVzID0gIm9rYXkiOwo+PiArICAgICAgICAgICAgICAgICAgICAgICBj b21wYXRpYmxlID0gInJvY2tjaGlwLHJrMzM5OS1wb3dlci1jb250cm9sbGVyIjsKPj4gKyAgICAg ICAgICAgICAgICAgICAgICAgI3Bvd2VyLWRvbWFpbi1jZWxscyA9IDwxPjsKPj4gKyAgICAgICAg ICAgICAgICAgICAgICAgI2FkZHJlc3MtY2VsbHMgPSA8MT47Cj4+ICsgICAgICAgICAgICAgICAg ICAgICAgICNzaXplLWNlbGxzID0gPDA+Owo+PiArCj4+ICsgICAgICAgICAgICAgICAgICAgICAg IC8qIFRoZXNlIHBvd2VyIGRvbWFpbnMgYXJlIGdyb3VwZWQgYnkgVkRfTE9HSUMgKi8KPj4gKyAg ICAgICAgICAgICAgICAgICAgICAgcGRfdmlvQFJLMzM5OV9QRF9WSU8gewo+PiArICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIHJlZyA9IDxSSzMzOTlfUERfVklPPjsKPj4gKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAjYWRkcmVzcy1jZWxscyA9IDwxPjsKPj4gKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAjc2l6ZS1jZWxscyA9IDwwPjsKPj4gKwo+PiArICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIHBkX2lzcDBAUkszMzk5X1BEX0lTUDAgewo+PiArICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmVnID0gPFJLMzM5OV9QRF9JU1Aw PjsKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNsb2NrcyA9IDwm Y3J1IEFDTEtfSVNQMD4sCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICA8JmNydSBIQ0xLX0lTUDA+Owo+PiArICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgcG1fcW9zID0gPCZxb3NfaXNwMF9tMD4sCj4+ICsgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA8JnFvc19pc3AwX20xPjsKPj4gKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICB9Owo+PiArICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIHBkX2lzcDFAUkszMzk5X1BEX0lTUDEgewo+PiArICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgcmVnID0gPFJLMzM5OV9QRF9JU1AxPjsKPj4gKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNsb2NrcyA9IDwmY3J1IEFDTEtfSVNQMT4s Cj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA8JmNy dSBIQ0xLX0lTUDE+Owo+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg cG1fcW9zID0gPCZxb3NfaXNwMV9tMD4sCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICA8JnFvc19pc3AxX20xPjsKPj4gKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICB9Owo+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBkX3Zv QFJLMzM5OV9QRF9WTyB7Cj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICByZWcgPSA8UkszMzk5X1BEX1ZPPjsKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICNhZGRyZXNzLWNlbGxzID0gPDE+Owo+PiArICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgI3NpemUtY2VsbHMgPSA8MD47Cj4+ICsKPj4gKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBkX3ZvcGJAUkszMzk5X1BEX1ZPUEIgewo+PiAr ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICByZWcgPSA8Uksz Mzk5X1BEX1ZPUEI+Owo+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBjbG9ja3MgPSA8JmNydSBBQ0xLX1ZPUDA+LAo+PiArICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA8JmNydSBIQ0xLX1ZPUDA+Owo+ PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwbV9xb3Mg PSA8JnFvc192b3BfYmlnX3I+LAo+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICA8JnFvc192b3BfYmlnX3c+Owo+PiArICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgfTsKPj4gKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHBkX3ZvcGxAUkszMzk5X1BEX1ZPUCB7Cj4+ICsgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJlZyA9IDxSSzMzOTlfUERfVk9QTD47 Cj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNsb2Nr cyA9IDwmY3J1IEFDTEtfVk9QMT4sCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIDwmY3J1IEhDTEtfVk9QMT47Cj4+ICsgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBtX3FvcyA9IDwmcW9zX3ZvcF9s aXR0bGU+Owo+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfTsKPj4g KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB9Owo+PiArICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHBkX2hkY3BAUkszMzk5X1BEX0hEQ1Agewo+PiArICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgcmVnID0gPFJLMzM5OV9QRF9IRENQPjsKPj4gKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNsb2NrcyA9IDwmY3J1IEFDTEtfSERD UD4sCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA8 JmNydSBIQ0xLX0hEQ1A+LAo+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgPCZjcnUgUENMS19IRENQPjsKPj4gKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHBtX3FvcyA9IDwmcW9zX2hkY3A+Owo+PiArICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIH07Cj4gSERDUCBzb3J0cyBlYXJsaWVyIHRoYW4gSVNQMCwgc28gc2hv dWxkIGJlIGFib3ZlIHRoYXQuICBCYXNpY2FsbHk6Cj4gYW55dGhpbmcgaW4gdGhlIHNhbWUgYXJl YSBzaG91bGQgYmUgc29ydGVkIGFscGhhYmV0aWNhbGx5LgoKVGhlIHNvcnQgaXMgZm9sbG93IHVw IHRoZSBUUk0uICBBdCBsZWFzdCBJJ20gYWNjb3JkaW5nIHRvIGV2ZXJ5IHZvbHRhZ2UgCmRvbWFp bi4KCj4KPj4gKyAgICAgICAgICAgICAgICAgICAgICAgfTsKPj4gKwo+PiArICAgICAgICAgICAg ICAgICAgICAgICAvKiBUaGVzZSBwb3dlciBkb21haW5zIGFyZSBncm91cGVkIGJ5IFZEX0NFTlRF UiAqLwo+PiArICAgICAgICAgICAgICAgICAgICAgICBwZF92Y29kZWNAUkszMzk5X1BEX1ZDT0RF QyB7Cj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmVnID0gPFJLMzM5OV9QRF9W Q09ERUM+Owo+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNsb2NrcyA9IDwmY3J1 IEFDTEtfVkNPREVDPiwKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICA8JmNydSBIQ0xLX1ZDT0RFQz47Cj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg cG1fcW9zID0gPCZxb3NfdmlkZW9fbTA+Owo+PiArICAgICAgICAgICAgICAgICAgICAgICB9Owo+ PiArICAgICAgICAgICAgICAgICAgICAgICBwZF92ZHVAUkszMzk5X1BEX1ZEVSB7Cj4+ICsgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgcmVnID0gPFJLMzM5OV9QRF9WRFU+Owo+PiArICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNsb2NrcyA9IDwmY3J1IEFDTEtfVkRVPiwKPj4g KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA8JmNydSBIQ0xLX1ZEVT47 Cj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcG1fcW9zID0gPCZxb3NfdmlkZW9f bTFfcj4sCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgPCZxb3Nf dmlkZW9fbTFfdz47Cj4+ICsgICAgICAgICAgICAgICAgICAgICAgIH07Cj4+ICsgICAgICAgICAg ICAgICAgICAgICAgIHBkX3JnYUBSSzMzOTlfUERfUkdBIHsKPj4gKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICByZWcgPSA8UkszMzk5X1BEX1JHQT47Cj4+ICsgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgY2xvY2tzID0gPCZjcnUgQUNMS19SR0E+LAo+PiArICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIDwmY3J1IEhDTEtfUkdBPjsKPj4gKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBwbV9xb3MgPSA8JnFvc19yZ2Ffcj4sCj4+ICsgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgPCZxb3NfcmdhX3c+Owo+PiArICAgICAg ICAgICAgICAgICAgICAgICB9Owo+PiArICAgICAgICAgICAgICAgICAgICAgICBwZF9pZXBAUksz Mzk5X1BEX0lFIHsKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICByZWcgPSA8Uksz Mzk5X1BEX0lFUD47Cj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY2xvY2tzID0g PCZjcnUgQUNMS19JRVA+LAo+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIDwmY3J1IEhDTEtfSUVQPjsKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBw bV9xb3MgPSA8JnFvc19pZXA+Owo+PiArICAgICAgICAgICAgICAgICAgICAgICB9Owo+IElFIHNv cnRzIGJlZm9yZSBSR0EuICAuLi5hbmQgYm90aCBjb21lIGJlZm9yZSBWQ09ERUMgLyBWRFUuCgpE aXR0bwo+Cj4+ICsKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgLyogVGhlc2UgcG93ZXIgZG9t YWlucyBhcmUgZ3JvdXBlZCBieSBWRF9HUFUgKi8KPj4gKyAgICAgICAgICAgICAgICAgICAgICAg cGRfZ3B1QFJLMzM5OV9QRF9HUFUgewo+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IHJlZyA9IDxSSzMzOTlfUERfR1BVPjsKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBjbG9ja3MgPSA8JmNydSBBQ0xLX0dQVT47Cj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgcG1fcW9zID0gPCZxb3NfZ3B1PjsKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgfTsK Pj4gKyAgICAgICAgICAgICAgIH07Cj4+ICsgICAgICAgfTsKPj4gKwo+PiAgICAgICAgICBwbXVn cmY6IHN5c2NvbkBmZjMyMDAwMCB7Cj4+ICAgICAgICAgICAgICAgICAgY29tcGF0aWJsZSA9ICJy b2NrY2hpcCxyazMzOTktcG11Z3JmIiwgInN5c2NvbiIsICJzaW1wbGUtbWZkIjsKPj4gICAgICAg ICAgICAgICAgICByZWcgPSA8MHgwIDB4ZmYzMjAwMDAgMHgwIDB4MTAwMD47Cj4+IC0tCj4+IDEu OS4xCj4+Cj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K PiBMaW51eC1yb2NrY2hpcCBtYWlsaW5nIGxpc3QKPiBMaW51eC1yb2NrY2hpcEBsaXN0cy5pbmZy YWRlYWQub3JnCj4gaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9s aW51eC1yb2NrY2hpcAoKCi0tIApjYWVzYXIgd2FuZyB8IHNvZnR3YXJlIGVuZ2luZWVyIHwgd3h0 QHJvY2stY2hpcC5jb20KCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KTGludXgtcm9ja2NoaXAgbWFpbGluZyBsaXN0CkxpbnV4LXJvY2tjaGlwQGxpc3Rz LmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5m by9saW51eC1yb2NrY2hpcAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: wxt@rock-chips.com (Caesar Wang) Date: Sat, 02 Jul 2016 09:34:49 +0800 Subject: [PATCH v2] arm64: dts: rockchip: add the power domain node for rk3399 In-Reply-To: References: <1467347575-11806-1-git-send-email-wxt@rock-chips.com> Message-ID: <57771A39.8060606@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2016?07?02? 00:56, Doug Anderson wrote: > Caesar > > On Thu, Jun 30, 2016 at 9:32 PM, Caesar Wang wrote: >> From: Elaine Zhang >> >> In order to meet low power requirements, a power management unit (PMU) is >> designed for controlling power resources in RK3399. The RK3399 PMU is >> dedicated for managing the power of the whole chip. >> >> 1. add pd node for RK3399 Soc >> 2. create power domain tree >> 3. add qos node for domain >> >> From the DT/binds and driver can get more detail information: >> The driver: >> drivers/soc/rockchip/pm_domains.c >> The document: >> Documentation/devicetree/bindings/soc/rockchip/power_domain.txt >> --- >> >> Changes in v2: >> - As Doug/Heiko commnets on https://patchwork.kernel.org/patch/9206415/. >> drop the debugfs-dump and Add the comments for alphabetical order. >> >> Note: As the TRM lists many voltage domains and power domains, then >> in actual we just need control some domains for driver. >> Due to some domains (e.g. emmc, usb, core)...We can't turn off it on >> bootup. > I'm curious: why can't you turn off USB power domains if a board > doesn't usb USB? ...or GMAC on boards that don't use Ethernet? ...or > eDP on boards that don't use EDP? > > Maybe the driver for these things isn't ready to handle power domains > yet so that's why they are left out for now? > > It seems like GMAC could at least be added because we don't even have > the GMAC listed in the current device tree so therefore there can't be > any users of it. When it's added we can make sure that the power > domains are added. At least, the gmac had been supported in rockchip inside. That's seem the gmac driver can't handle the power domain enough. -- Frankly, I'm no test the GMAC?then this patch should support most of devices. We can send another patch to support it if someone?usb/gmac) can handle the power domain. > > I think in the current upstream dtsi file there is also no xhci node, > so does that mean you could add the USB3 power domain? > > willam at RK, what's think of it? >> Signed-off-by: Elaine Zhang >> Signed-off-by: Caesar Wang >> Cc: linux-arm-kernel at lists.infradead.org >> Cc: linux-rockchip at lists.infradead.org >> Cc: Heiko Stuebner >> >> --- >> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 179 +++++++++++++++++++++++++++++++ >> 1 file changed, 179 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi >> index a6dd623..103e185 100644 >> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi >> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi >> @@ -45,6 +45,7 @@ >> #include >> #include >> #include >> +#include >> #include >> >> / { >> @@ -594,6 +595,184 @@ >> status = "disabled"; >> }; >> >> + qos_hdcp: qos_hdcp at ffa90000 { >> + compatible = "syscon"; >> + reg = <0x0 0xffa90000 0x0 0x20>; >> + }; >> + >> + qos_iep: qos_iep at ffa98000 { >> + compatible = "syscon"; >> + reg = <0x0 0xffa98000 0x0 0x20>; >> + }; >> + >> + qos_isp0_m0: qos_isp0_m0 at ffaa0000 { >> + compatible = "syscon"; >> + reg = <0x0 0xffaa0000 0x0 0x20>; >> + }; >> + >> + qos_isp0_m1: qos_isp0_m1 at ffaa0080 { >> + compatible = "syscon"; >> + reg = <0x0 0xffaa0080 0x0 0x20>; >> + }; >> + >> + qos_isp1_m0: qos_isp1_m0 at ffaa8000 { >> + compatible = "syscon"; >> + reg = <0x0 0xffaa8000 0x0 0x20>; >> + }; >> + >> + qos_isp1_m1: qos_isp1_m1 at ffaa8080 { >> + compatible = "syscon"; >> + reg = <0x0 0xffaa8080 0x0 0x20>; >> + }; >> + >> + qos_rga_r: qos_rga_r at ffab0000 { >> + compatible = "syscon"; >> + reg = <0x0 0xffab0000 0x0 0x20>; >> + }; >> + >> + qos_rga_w: qos_rga_w at ffab0080 { >> + compatible = "syscon"; >> + reg = <0x0 0xffab0080 0x0 0x20>; >> + }; >> + >> + qos_video_m0: qos_video_m0 at ffab8000 { >> + compatible = "syscon"; >> + reg = <0x0 0xffab8000 0x0 0x20>; >> + }; >> + >> + qos_video_m1_r: qos_video_m1_r at ffac0000 { >> + compatible = "syscon"; >> + reg = <0x0 0xffac0000 0x0 0x20>; >> + }; >> + >> + qos_video_m1_w: qos_video_m1_w at ffac0080 { >> + compatible = "syscon"; >> + reg = <0x0 0xffac0080 0x0 0x20>; >> + }; >> + >> + qos_vop_big_r: qos_vop_big_r at ffac8000 { >> + compatible = "syscon"; >> + reg = <0x0 0xffac8000 0x0 0x20>; >> + }; >> + >> + qos_vop_big_w: qos_vop_big_w at ffac8080 { >> + compatible = "syscon"; >> + reg = <0x0 0xffac8080 0x0 0x20>; >> + }; >> + >> + qos_vop_little: qos_vop_little at ffad0000 { >> + compatible = "syscon"; >> + reg = <0x0 0xffad0000 0x0 0x20>; >> + }; >> + >> + qos_gpu: qos_gpu at ffae0000 { >> + compatible = "syscon"; >> + reg = <0x0 0xffae0000 0x0 0x20>; >> + }; >> + >> + pmu: power-management at ff310000 { >> + compatible = "rockchip,rk3399-pmu", "syscon", "simple-mfd"; >> + reg = <0x0 0xff310000 0x0 0x1000>; >> + >> + /* >> + * Note: RK3399 supports 6 voltage domains including VD_CORE_L, >> + * VD_CORE_B, VD_CENTER, VD_GPU, VD_LOGIC and VD_PMU. >> + * Some of the power domains are grouped together for every >> + * voltage domain. >> + * The detail contents as below. >> + */ >> + power: power-controller { >> + status = "okay"; >> + compatible = "rockchip,rk3399-power-controller"; >> + #power-domain-cells = <1>; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + /* These power domains are grouped by VD_LOGIC */ >> + pd_vio at RK3399_PD_VIO { >> + reg = ; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + pd_isp0 at RK3399_PD_ISP0 { >> + reg = ; >> + clocks = <&cru ACLK_ISP0>, >> + <&cru HCLK_ISP0>; >> + pm_qos = <&qos_isp0_m0>, >> + <&qos_isp0_m1>; >> + }; >> + pd_isp1 at RK3399_PD_ISP1 { >> + reg = ; >> + clocks = <&cru ACLK_ISP1>, >> + <&cru HCLK_ISP1>; >> + pm_qos = <&qos_isp1_m0>, >> + <&qos_isp1_m1>; >> + }; >> + pd_vo at RK3399_PD_VO { >> + reg = ; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + pd_vopb at RK3399_PD_VOPB { >> + reg = ; >> + clocks = <&cru ACLK_VOP0>, >> + <&cru HCLK_VOP0>; >> + pm_qos = <&qos_vop_big_r>, >> + <&qos_vop_big_w>; >> + }; >> + pd_vopl at RK3399_PD_VOP { >> + reg = ; >> + clocks = <&cru ACLK_VOP1>, >> + <&cru HCLK_VOP1>; >> + pm_qos = <&qos_vop_little>; >> + }; >> + }; >> + pd_hdcp at RK3399_PD_HDCP { >> + reg = ; >> + clocks = <&cru ACLK_HDCP>, >> + <&cru HCLK_HDCP>, >> + <&cru PCLK_HDCP>; >> + pm_qos = <&qos_hdcp>; >> + }; > HDCP sorts earlier than ISP0, so should be above that. Basically: > anything in the same area should be sorted alphabetically. The sort is follow up the TRM. At least I'm according to every voltage domain. > >> + }; >> + >> + /* These power domains are grouped by VD_CENTER */ >> + pd_vcodec at RK3399_PD_VCODEC { >> + reg = ; >> + clocks = <&cru ACLK_VCODEC>, >> + <&cru HCLK_VCODEC>; >> + pm_qos = <&qos_video_m0>; >> + }; >> + pd_vdu at RK3399_PD_VDU { >> + reg = ; >> + clocks = <&cru ACLK_VDU>, >> + <&cru HCLK_VDU>; >> + pm_qos = <&qos_video_m1_r>, >> + <&qos_video_m1_w>; >> + }; >> + pd_rga at RK3399_PD_RGA { >> + reg = ; >> + clocks = <&cru ACLK_RGA>, >> + <&cru HCLK_RGA>; >> + pm_qos = <&qos_rga_r>, >> + <&qos_rga_w>; >> + }; >> + pd_iep at RK3399_PD_IE { >> + reg = ; >> + clocks = <&cru ACLK_IEP>, >> + <&cru HCLK_IEP>; >> + pm_qos = <&qos_iep>; >> + }; > IE sorts before RGA. ...and both come before VCODEC / VDU. Ditto > >> + >> + /* These power domains are grouped by VD_GPU */ >> + pd_gpu at RK3399_PD_GPU { >> + reg = ; >> + clocks = <&cru ACLK_GPU>; >> + pm_qos = <&qos_gpu>; >> + }; >> + }; >> + }; >> + >> pmugrf: syscon at ff320000 { >> compatible = "rockchip,rk3399-pmugrf", "syscon", "simple-mfd"; >> reg = <0x0 0xff320000 0x0 0x1000>; >> -- >> 1.9.1 >> > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip -- caesar wang | software engineer | wxt at rock-chip.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932105AbcGBBfE (ORCPT ); Fri, 1 Jul 2016 21:35:04 -0400 Received: from regular1.263xmail.com ([211.150.99.131]:40058 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752328AbcGBBfC (ORCPT ); Fri, 1 Jul 2016 21:35:02 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: wxt@rock-chips.com X-FST-TO: dianders@chromium.org X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: wxt@rock-chips.com X-UNIQUE-TAG: <3c9c714ff3ba214e678b1c2d885e428e> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <57771A39.8060606@rock-chips.com> Date: Sat, 02 Jul 2016 09:34:49 +0800 From: Caesar Wang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Doug Anderson , =?UTF-8?B?5ZC06Imv5bOw?= CC: Caesar Wang , Tao Huang , =?UTF-8?B?SGVpa28gU3TDvGJuZXI=?= , Elaine Zhang , "linux-kernel@vger.kernel.org" , "open list:ARM/Rockchip SoC..." , Eddie Cai , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v2] arm64: dts: rockchip: add the power domain node for rk3399 References: <1467347575-11806-1-git-send-email-wxt@rock-chips.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016年07月02日 00:56, Doug Anderson wrote: > Caesar > > On Thu, Jun 30, 2016 at 9:32 PM, Caesar Wang wrote: >> From: Elaine Zhang >> >> In order to meet low power requirements, a power management unit (PMU) is >> designed for controlling power resources in RK3399. The RK3399 PMU is >> dedicated for managing the power of the whole chip. >> >> 1. add pd node for RK3399 Soc >> 2. create power domain tree >> 3. add qos node for domain >> >> From the DT/binds and driver can get more detail information: >> The driver: >> drivers/soc/rockchip/pm_domains.c >> The document: >> Documentation/devicetree/bindings/soc/rockchip/power_domain.txt >> --- >> >> Changes in v2: >> - As Doug/Heiko commnets on https://patchwork.kernel.org/patch/9206415/. >> drop the debugfs-dump and Add the comments for alphabetical order. >> >> Note: As the TRM lists many voltage domains and power domains, then >> in actual we just need control some domains for driver. >> Due to some domains (e.g. emmc, usb, core)...We can't turn off it on >> bootup. > I'm curious: why can't you turn off USB power domains if a board > doesn't usb USB? ...or GMAC on boards that don't use Ethernet? ...or > eDP on boards that don't use EDP? > > Maybe the driver for these things isn't ready to handle power domains > yet so that's why they are left out for now? > > It seems like GMAC could at least be added because we don't even have > the GMAC listed in the current device tree so therefore there can't be > any users of it. When it's added we can make sure that the power > domains are added. At least, the gmac had been supported in rockchip inside. That's seem the gmac driver can't handle the power domain enough. -- Frankly, I'm no test the GMAC，then this patch should support most of devices. We can send another patch to support it if someone（usb/gmac) can handle the power domain. > > I think in the current upstream dtsi file there is also no xhci node, > so does that mean you could add the USB3 power domain? > > willam@RK, what's think of it？ >> Signed-off-by: Elaine Zhang >> Signed-off-by: Caesar Wang >> Cc: linux-arm-kernel@lists.infradead.org >> Cc: linux-rockchip@lists.infradead.org >> Cc: Heiko Stuebner >> >> --- >> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 179 +++++++++++++++++++++++++++++++ >> 1 file changed, 179 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi >> index a6dd623..103e185 100644 >> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi >> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi >> @@ -45,6 +45,7 @@ >> #include >> #include >> #include >> +#include >> #include >> >> / { >> @@ -594,6 +595,184 @@ >> status = "disabled"; >> }; >> >> + qos_hdcp: qos_hdcp@ffa90000 { >> + compatible = "syscon"; >> + reg = <0x0 0xffa90000 0x0 0x20>; >> + }; >> + >> + qos_iep: qos_iep@ffa98000 { >> + compatible = "syscon"; >> + reg = <0x0 0xffa98000 0x0 0x20>; >> + }; >> + >> + qos_isp0_m0: qos_isp0_m0@ffaa0000 { >> + compatible = "syscon"; >> + reg = <0x0 0xffaa0000 0x0 0x20>; >> + }; >> + >> + qos_isp0_m1: qos_isp0_m1@ffaa0080 { >> + compatible = "syscon"; >> + reg = <0x0 0xffaa0080 0x0 0x20>; >> + }; >> + >> + qos_isp1_m0: qos_isp1_m0@ffaa8000 { >> + compatible = "syscon"; >> + reg = <0x0 0xffaa8000 0x0 0x20>; >> + }; >> + >> + qos_isp1_m1: qos_isp1_m1@ffaa8080 { >> + compatible = "syscon"; >> + reg = <0x0 0xffaa8080 0x0 0x20>; >> + }; >> + >> + qos_rga_r: qos_rga_r@ffab0000 { >> + compatible = "syscon"; >> + reg = <0x0 0xffab0000 0x0 0x20>; >> + }; >> + >> + qos_rga_w: qos_rga_w@ffab0080 { >> + compatible = "syscon"; >> + reg = <0x0 0xffab0080 0x0 0x20>; >> + }; >> + >> + qos_video_m0: qos_video_m0@ffab8000 { >> + compatible = "syscon"; >> + reg = <0x0 0xffab8000 0x0 0x20>; >> + }; >> + >> + qos_video_m1_r: qos_video_m1_r@ffac0000 { >> + compatible = "syscon"; >> + reg = <0x0 0xffac0000 0x0 0x20>; >> + }; >> + >> + qos_video_m1_w: qos_video_m1_w@ffac0080 { >> + compatible = "syscon"; >> + reg = <0x0 0xffac0080 0x0 0x20>; >> + }; >> + >> + qos_vop_big_r: qos_vop_big_r@ffac8000 { >> + compatible = "syscon"; >> + reg = <0x0 0xffac8000 0x0 0x20>; >> + }; >> + >> + qos_vop_big_w: qos_vop_big_w@ffac8080 { >> + compatible = "syscon"; >> + reg = <0x0 0xffac8080 0x0 0x20>; >> + }; >> + >> + qos_vop_little: qos_vop_little@ffad0000 { >> + compatible = "syscon"; >> + reg = <0x0 0xffad0000 0x0 0x20>; >> + }; >> + >> + qos_gpu: qos_gpu@ffae0000 { >> + compatible = "syscon"; >> + reg = <0x0 0xffae0000 0x0 0x20>; >> + }; >> + >> + pmu: power-management@ff310000 { >> + compatible = "rockchip,rk3399-pmu", "syscon", "simple-mfd"; >> + reg = <0x0 0xff310000 0x0 0x1000>; >> + >> + /* >> + * Note: RK3399 supports 6 voltage domains including VD_CORE_L, >> + * VD_CORE_B, VD_CENTER, VD_GPU, VD_LOGIC and VD_PMU. >> + * Some of the power domains are grouped together for every >> + * voltage domain. >> + * The detail contents as below. >> + */ >> + power: power-controller { >> + status = "okay"; >> + compatible = "rockchip,rk3399-power-controller"; >> + #power-domain-cells = <1>; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + /* These power domains are grouped by VD_LOGIC */ >> + pd_vio@RK3399_PD_VIO { >> + reg = ; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + pd_isp0@RK3399_PD_ISP0 { >> + reg = ; >> + clocks = <&cru ACLK_ISP0>, >> + <&cru HCLK_ISP0>; >> + pm_qos = <&qos_isp0_m0>, >> + <&qos_isp0_m1>; >> + }; >> + pd_isp1@RK3399_PD_ISP1 { >> + reg = ; >> + clocks = <&cru ACLK_ISP1>, >> + <&cru HCLK_ISP1>; >> + pm_qos = <&qos_isp1_m0>, >> + <&qos_isp1_m1>; >> + }; >> + pd_vo@RK3399_PD_VO { >> + reg = ; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + pd_vopb@RK3399_PD_VOPB { >> + reg = ; >> + clocks = <&cru ACLK_VOP0>, >> + <&cru HCLK_VOP0>; >> + pm_qos = <&qos_vop_big_r>, >> + <&qos_vop_big_w>; >> + }; >> + pd_vopl@RK3399_PD_VOP { >> + reg = ; >> + clocks = <&cru ACLK_VOP1>, >> + <&cru HCLK_VOP1>; >> + pm_qos = <&qos_vop_little>; >> + }; >> + }; >> + pd_hdcp@RK3399_PD_HDCP { >> + reg = ; >> + clocks = <&cru ACLK_HDCP>, >> + <&cru HCLK_HDCP>, >> + <&cru PCLK_HDCP>; >> + pm_qos = <&qos_hdcp>; >> + }; > HDCP sorts earlier than ISP0, so should be above that. Basically: > anything in the same area should be sorted alphabetically. The sort is follow up the TRM. At least I'm according to every voltage domain. > >> + }; >> + >> + /* These power domains are grouped by VD_CENTER */ >> + pd_vcodec@RK3399_PD_VCODEC { >> + reg = ; >> + clocks = <&cru ACLK_VCODEC>, >> + <&cru HCLK_VCODEC>; >> + pm_qos = <&qos_video_m0>; >> + }; >> + pd_vdu@RK3399_PD_VDU { >> + reg = ; >> + clocks = <&cru ACLK_VDU>, >> + <&cru HCLK_VDU>; >> + pm_qos = <&qos_video_m1_r>, >> + <&qos_video_m1_w>; >> + }; >> + pd_rga@RK3399_PD_RGA { >> + reg = ; >> + clocks = <&cru ACLK_RGA>, >> + <&cru HCLK_RGA>; >> + pm_qos = <&qos_rga_r>, >> + <&qos_rga_w>; >> + }; >> + pd_iep@RK3399_PD_IE { >> + reg = ; >> + clocks = <&cru ACLK_IEP>, >> + <&cru HCLK_IEP>; >> + pm_qos = <&qos_iep>; >> + }; > IE sorts before RGA. ...and both come before VCODEC / VDU. Ditto > >> + >> + /* These power domains are grouped by VD_GPU */ >> + pd_gpu@RK3399_PD_GPU { >> + reg = ; >> + clocks = <&cru ACLK_GPU>; >> + pm_qos = <&qos_gpu>; >> + }; >> + }; >> + }; >> + >> pmugrf: syscon@ff320000 { >> compatible = "rockchip,rk3399-pmugrf", "syscon", "simple-mfd"; >> reg = <0x0 0xff320000 0x0 0x1000>; >> -- >> 1.9.1 >> > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip -- caesar wang | software engineer | wxt@rock-chip.com