From: Thomas Monjalon <thomas@monjalon.net>
To: jspewock@iol.unh.edu
Cc: dev@dpdk.org, Honnappa.Nagarahalli@arm.com,
juraj.linkes@pantheon.tech, wathsala.vithanage@arm.com,
paul.szczepanek@arm.com, yoan.picchi@foss.arm.com, dev@dpdk.org,
Patrick Robb <probb@iol.unh.edu>
Subject: Re: [PATCH v3 1/1] dts: bind to DPDK driver before running test suites
Date: Tue, 14 Nov 2023 22:49:01 +0100 [thread overview]
Message-ID: <5777666.tdWV9SEqCh@thomas> (raw)
In-Reply-To: <CAJvnSUC_UOtHSi+R9eQDudjFzeRaAecuL9KBoQYPRLEWsrgnuw@mail.gmail.com>
13/11/2023 18:56, Patrick Robb:
> On Thu, Nov 9, 2023 at 6:17 PM <jspewock@iol.unh.edu> wrote:
>
> > From: Jeremy Spewock <jspewock@iol.unh.edu>
> >
> > Modifies the current process so that we bind to os_driver_for_dpdk from
> > the configuration file before running test suites and bind back to the
> > os_driver afterwards. This allows test suites to assume that the ports
> > are bound to a DPDK supported driver or bind to either driver as needed.
> >
> > Signed-off-by: Jeremy Spewock <jspewock@iol.unh.edu>
> >
> > We discussed this aspect of binding during last week's CI meeting and I
> understood Juraj to be consenting to returning to DTS running the binding
> to the dpdk driver (so, what you're doing here), as opposed to relying on
> the user to do it, and making it a smoke test. As we've discussed, that's
> how the old DTS framework ran, and I prefer to stick to this approach. One
> aspect I raised was how in a lab context it's desirable for us to define as
> much as possible within config files, and have environmental configuration
> be handled by DTS. So, since there was basically agreement here, I think
> your changes here are appropriate.
>
> Acked-by: Patrick Robb <probb@iol.unh.edu>
Not sure it is a good idea to add something knowing it will be reworked,
but you agreed, so I apply.
PS: please make all versions of the same patch in the same email thread.
next prev parent reply other threads:[~2023-11-14 21:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-09 23:16 [PATCH v3 0/1] dts: Add the ability to bind ports to drivers jspewock
2023-11-09 23:16 ` [PATCH v3 1/1] dts: bind to DPDK driver before running test suites jspewock
2023-11-13 17:56 ` Patrick Robb
2023-11-14 21:49 ` Thomas Monjalon [this message]
2023-11-14 23:41 ` Jeremy Spewock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5777666.tdWV9SEqCh@thomas \
--to=thomas@monjalon.net \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=dev@dpdk.org \
--cc=jspewock@iol.unh.edu \
--cc=juraj.linkes@pantheon.tech \
--cc=paul.szczepanek@arm.com \
--cc=probb@iol.unh.edu \
--cc=wathsala.vithanage@arm.com \
--cc=yoan.picchi@foss.arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.