From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752166AbcGBLWI (ORCPT ); Sat, 2 Jul 2016 07:22:08 -0400 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:45419 "EHLO s-opensource.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752018AbcGBLWH (ORCPT ); Sat, 2 Jul 2016 07:22:07 -0400 X-Greylist: delayed 335 seconds by postgrey-1.27 at vger.kernel.org; Sat, 02 Jul 2016 07:22:07 EDT Message-ID: <5777A3D9.90808@osg.samsung.com> Date: Sat, 02 Jul 2016 12:22:01 +0100 From: Luis de Bethencourt User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 MIME-Version: 1.0 To: Salah Triki , akpm@linux-foundation.org, viro@zeniv.linux.org.uk CC: mhocko@suse.com, vdavydov@virtuozzo.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] fs: befs: Coding style fix References: <9859a616787673d2f36ce21d4aa0220637c55001.1467446561.git.salah.triki@gmail.com> <6e5ad0148ac892de0e7ceaa7e9bc757e164c292f.1467446561.git.salah.triki@gmail.com> In-Reply-To: <6e5ad0148ac892de0e7ceaa7e9bc757e164c292f.1467446561.git.salah.triki@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/07/16 09:05, Salah Triki wrote: > Constant has to be capitalized. > > Signed-off-by: Salah Triki > --- > fs/befs/btree.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/fs/befs/btree.c b/fs/befs/btree.c > index 307645f9..e59ad20 100644 > --- a/fs/befs/btree.c > +++ b/fs/befs/btree.c > @@ -85,7 +85,7 @@ struct befs_btree_node { > }; > > /* local constants */ > -static const befs_off_t befs_bt_inval = 0xffffffffffffffffULL; > +static const befs_off_t BEFS_BT_INVAL = 0xffffffffffffffffULL; > > /* local functions */ > static int befs_btree_seekleaf(struct super_block *sb, const befs_data_stream *ds, > @@ -467,7 +467,7 @@ befs_btree_read(struct super_block *sb, const befs_data_stream *ds, > while (key_sum + this_node->head.all_key_count <= key_no) { > > /* no more nodes to look in: key_no is too large */ > - if (this_node->head.right == befs_bt_inval) { > + if (this_node->head.right == BEFS_BT_INVAL) { > *keysize = 0; > *value = 0; > befs_debug(sb, > @@ -608,7 +608,7 @@ static int > befs_leafnode(struct befs_btree_node *node) > { > /* all interior nodes (and only interior nodes) have an overflow node */ > - if (node->head.overflow == befs_bt_inval) > + if (node->head.overflow == BEFS_BT_INVAL) > return 1; > else > return 0; > Hi Salah, What the coding style says is: "Names of macros defining constants and labels in enums are capitalized." Even though this isn't a macro, when reading the code it is good to know it is almost like one. I agree this makes the code more readable. Acked-by: Luis de Bethencourt Thanks, Luis