From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752018AbcGBLvr (ORCPT ); Sat, 2 Jul 2016 07:51:47 -0400 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:45439 "EHLO s-opensource.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751213AbcGBLvq (ORCPT ); Sat, 2 Jul 2016 07:51:46 -0400 Message-ID: <5777AACD.4000806@osg.samsung.com> Date: Sat, 02 Jul 2016 12:51:41 +0100 From: Luis de Bethencourt User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 MIME-Version: 1.0 To: Salah Triki , akpm@linux-foundation.org, viro@zeniv.linux.org.uk CC: mhocko@suse.com, vdavydov@virtuozzo.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] fs: befs: Remove useless calls to brelse in befs_find_brun_dblindirect References: <9859a616787673d2f36ce21d4aa0220637c55001.1467446561.git.salah.triki@gmail.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/07/16 09:05, Salah Triki wrote: > The calls to brelse are useless since dbl_indir_block and indir_block > are NULL. > > Signed-off-by: Salah Triki > --- > fs/befs/datastream.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/fs/befs/datastream.c b/fs/befs/datastream.c > index e224b9a..b68b6f9 100644 > --- a/fs/befs/datastream.c > +++ b/fs/befs/datastream.c > @@ -471,7 +471,6 @@ befs_find_brun_dblindirect(struct super_block *sb, > (unsigned long) > iaddr2blockno(sb, &data->double_indirect) + > dbl_which_block); > - brelse(dbl_indir_block); > return BEFS_ERR; > } > > @@ -496,7 +495,6 @@ befs_find_brun_dblindirect(struct super_block *sb, > befs_error(sb, "%s couldn't read the indirect block " > "at blockno %lu", __func__, (unsigned long) > iaddr2blockno(sb, &indir_run) + which_block); > - brelse(indir_block); > return BEFS_ERR; > } > > Great catch! This went unnoticed because brelse() checks if the buffer_head is NULL before decrementing the reference count. Which in these two cases they clearly are NULL. Acked-by: Luis de Bethencourt Thanks! Luis