From mboxrd@z Thu Jan 1 00:00:00 1970 From: wangyijing Subject: Re: [PATCH v3 2/3] bcache: update document info Date: Mon, 4 Jul 2016 14:43:05 +0800 Message-ID: <577A0579.2040005@huawei.com> References: <1467595414-20844-1-git-send-email-wangyijing@huawei.com> <489c5709-29d0-077c-d8b7-92f12447fc08@coly.li> Mime-Version: 1.0 Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from szxga04-in.huawei.com ([119.145.14.52]:12826 "EHLO szxga04-in.huawei.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1753130AbcGDGop (ORCPT ); Mon, 4 Jul 2016 02:44:45 -0400 In-Reply-To: <489c5709-29d0-077c-d8b7-92f12447fc08@coly.li> Sender: linux-bcache-owner@vger.kernel.org List-Id: linux-bcache@vger.kernel.org To: Coly Li , axboe@fb.com, Kent Overstreet Cc: Eric Wheeler , Coly Li , linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org =D4=DA 2016/7/4 13:49, Coly Li =D0=B4=B5=C0: > =D4=DA 16/7/4 =C9=CF=CE=E79:23, Yijing Wang =D0=B4=B5=C0: >> There is no return in continue_at(), update the documentation. >> >=20 > Thanks. >=20 > Acked-by: Coly Li Thanks very much! >=20 >> Signed-off-by: Yijing Wang >> --- >> drivers/md/bcache/closure.c | 2 +- >> drivers/md/bcache/closure.h | 3 ++- >> 2 files changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/md/bcache/closure.c b/drivers/md/bcache/closure= =2Ec >> index 9eaf1d6..864e673 100644 >> --- a/drivers/md/bcache/closure.c >> +++ b/drivers/md/bcache/closure.c >> @@ -112,7 +112,7 @@ bool closure_wait(struct closure_waitlist *waitl= ist, struct closure *cl) >> EXPORT_SYMBOL(closure_wait); >> =20 >> /** >> - * closure_sync - sleep until a closure a closure has nothing left = to wait on >> + * closure_sync - sleep until a closure has nothing left to wait on >> * >> * Sleeps until the refcount hits 1 - the thread that's running the= closure owns >> * the last refcount. >> diff --git a/drivers/md/bcache/closure.h b/drivers/md/bcache/closure= =2Eh >> index 782cc2c..9b2fe2d 100644 >> --- a/drivers/md/bcache/closure.h >> +++ b/drivers/md/bcache/closure.h >> @@ -31,7 +31,8 @@ >> * passing it, as you might expect, the function to run when nothin= g is pending >> * and the workqueue to run that function out of. >> * >> - * continue_at() also, critically, is a macro that returns the call= ing function. >> + * continue_at() also, critically, requires a 'return' immediately = following the >> + * location where this macro is referenced, to return to the callin= g function. >> * There's good reason for this. >> * >> * To use safely closures asynchronously, they must always have a r= efcount while >> >=20 >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753175AbcGDGor (ORCPT ); Mon, 4 Jul 2016 02:44:47 -0400 Received: from szxga04-in.huawei.com ([119.145.14.52]:12826 "EHLO szxga04-in.huawei.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1753130AbcGDGop (ORCPT ); Mon, 4 Jul 2016 02:44:45 -0400 Subject: Re: [PATCH v3 2/3] bcache: update document info To: Coly Li , , Kent Overstreet References: <1467595414-20844-1-git-send-email-wangyijing@huawei.com> <489c5709-29d0-077c-d8b7-92f12447fc08@coly.li> CC: Eric Wheeler , Coly Li , , , From: wangyijing Message-ID: <577A0579.2040005@huawei.com> Date: Mon, 4 Jul 2016 14:43:05 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <489c5709-29d0-077c-d8b7-92f12447fc08@coly.li> Content-Type: text/plain; charset="gbk" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.177.23.4] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090203.577A0594.0067,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 737585a1735a228abcef4a77c044b410 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2016/7/4 13:49, Coly Li 写道: > 在 16/7/4 上午9:23, Yijing Wang 写道: >> There is no return in continue_at(), update the documentation. >> > > Thanks. > > Acked-by: Coly Li Thanks very much! > >> Signed-off-by: Yijing Wang >> --- >> drivers/md/bcache/closure.c | 2 +- >> drivers/md/bcache/closure.h | 3 ++- >> 2 files changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/md/bcache/closure.c b/drivers/md/bcache/closure.c >> index 9eaf1d6..864e673 100644 >> --- a/drivers/md/bcache/closure.c >> +++ b/drivers/md/bcache/closure.c >> @@ -112,7 +112,7 @@ bool closure_wait(struct closure_waitlist *waitlist, struct closure *cl) >> EXPORT_SYMBOL(closure_wait); >> >> /** >> - * closure_sync - sleep until a closure a closure has nothing left to wait on >> + * closure_sync - sleep until a closure has nothing left to wait on >> * >> * Sleeps until the refcount hits 1 - the thread that's running the closure owns >> * the last refcount. >> diff --git a/drivers/md/bcache/closure.h b/drivers/md/bcache/closure.h >> index 782cc2c..9b2fe2d 100644 >> --- a/drivers/md/bcache/closure.h >> +++ b/drivers/md/bcache/closure.h >> @@ -31,7 +31,8 @@ >> * passing it, as you might expect, the function to run when nothing is pending >> * and the workqueue to run that function out of. >> * >> - * continue_at() also, critically, is a macro that returns the calling function. >> + * continue_at() also, critically, requires a 'return' immediately following the >> + * location where this macro is referenced, to return to the calling function. >> * There's good reason for this. >> * >> * To use safely closures asynchronously, they must always have a refcount while >> > >