From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33338) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bJyKo-0002gV-Aq for qemu-devel@nongnu.org; Mon, 04 Jul 2016 03:30:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bJyKk-0002gU-19 for qemu-devel@nongnu.org; Mon, 04 Jul 2016 03:30:26 -0400 Received: from mx-v6.kamp.de ([2a02:248:0:51::16]:50863 helo=mx01.kamp.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bJyKj-0002ft-NT for qemu-devel@nongnu.org; Mon, 04 Jul 2016 03:30:21 -0400 References: <1467104499-27517-1-git-send-email-pl@kamp.de> <1467104499-27517-10-git-send-email-pl@kamp.de> From: Peter Lieven Message-ID: <577A1080.8070808@kamp.de> Date: Mon, 4 Jul 2016 09:30:08 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 09/15] loader: use mmap for ROMs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: kwolf@redhat.com, peter.maydell@linaro.org, mst@redhat.com, dgilbert@redhat.com, mreitz@redhat.com, kraxel@redhat.com Am 28.06.2016 um 12:41 schrieb Paolo Bonzini: > > On 28/06/2016 11:01, Peter Lieven wrote: >> a classic use for mmap here. >> >> Signed-off-by: Peter Lieven > They are never freed, why does mmap help? checked again. qemu_system_reset (which calls rom_reset) is invoked after pc_macine_init. So the memory is indeed freed again. Peter