From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kishon Vijay Abraham I Date: Mon, 04 Jul 2016 07:53:42 +0000 Subject: Re: [PATCH] phy: fix error handling Message-Id: <577A15D2.5010103@ti.com> List-Id: References: <1467525332-12963-1-git-send-email-christophe.jaillet@wanadoo.fr> <00d5243a-0359-1dc7-e9aa-1ad8a9074821@wanadoo.fr> In-Reply-To: <00d5243a-0359-1dc7-e9aa-1ad8a9074821@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: linux-arm-kernel@lists.infradead.org Hi, On Monday 04 July 2016 02:38 AM, Christophe JAILLET wrote: > I will resubmit in the coming days. >=20 > return PTR_ERR(phy->clk); > should also be updated. while at that, also fix your $subject to something like "phy: sun9i-usb: fix error handling" Thanks Kishon >=20 > Best regards, > CJ >=20 > Le 03/07/2016 =E0 07:55, Christophe JAILLET a =E9crit : >> This is likely that checking 'phy->hsic_clk' instead of 'phy->clk' is >> expected here. >> >> Signed-off-by: Christophe JAILLET >> --- >> drivers/phy/phy-sun9i-usb.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/phy/phy-sun9i-usb.c b/drivers/phy/phy-sun9i-usb.c >> index ac4f31a..ff99eba 100644 >> --- a/drivers/phy/phy-sun9i-usb.c >> +++ b/drivers/phy/phy-sun9i-usb.c >> @@ -141,7 +141,7 @@ static int sun9i_usb_phy_probe(struct platform_devic= e *pdev) >> } >> phy->hsic_clk =3D devm_clk_get(dev, "hsic_12M"); >> - if (IS_ERR(phy->clk)) { >> + if (IS_ERR(phy->hsic_clk)) { >> dev_err(dev, "failed to get hsic_12M clock\n"); >> return PTR_ERR(phy->clk); >> } >=20 >=20 -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: kishon@ti.com (Kishon Vijay Abraham I) Date: Mon, 4 Jul 2016 13:22:50 +0530 Subject: [PATCH] phy: fix error handling In-Reply-To: <00d5243a-0359-1dc7-e9aa-1ad8a9074821@wanadoo.fr> References: <1467525332-12963-1-git-send-email-christophe.jaillet@wanadoo.fr> <00d5243a-0359-1dc7-e9aa-1ad8a9074821@wanadoo.fr> Message-ID: <577A15D2.5010103@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On Monday 04 July 2016 02:38 AM, Christophe JAILLET wrote: > I will resubmit in the coming days. > > return PTR_ERR(phy->clk); > should also be updated. while at that, also fix your $subject to something like "phy: sun9i-usb: fix error handling" Thanks Kishon > > Best regards, > CJ > > Le 03/07/2016 ? 07:55, Christophe JAILLET a ?crit : >> This is likely that checking 'phy->hsic_clk' instead of 'phy->clk' is >> expected here. >> >> Signed-off-by: Christophe JAILLET >> --- >> drivers/phy/phy-sun9i-usb.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/phy/phy-sun9i-usb.c b/drivers/phy/phy-sun9i-usb.c >> index ac4f31a..ff99eba 100644 >> --- a/drivers/phy/phy-sun9i-usb.c >> +++ b/drivers/phy/phy-sun9i-usb.c >> @@ -141,7 +141,7 @@ static int sun9i_usb_phy_probe(struct platform_device *pdev) >> } >> phy->hsic_clk = devm_clk_get(dev, "hsic_12M"); >> - if (IS_ERR(phy->clk)) { >> + if (IS_ERR(phy->hsic_clk)) { >> dev_err(dev, "failed to get hsic_12M clock\n"); >> return PTR_ERR(phy->clk); >> } > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753294AbcGDHxp (ORCPT ); Mon, 4 Jul 2016 03:53:45 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:45462 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753011AbcGDHxl (ORCPT ); Mon, 4 Jul 2016 03:53:41 -0400 Subject: Re: [PATCH] phy: fix error handling To: Christophe JAILLET , , References: <1467525332-12963-1-git-send-email-christophe.jaillet@wanadoo.fr> <00d5243a-0359-1dc7-e9aa-1ad8a9074821@wanadoo.fr> CC: , , From: Kishon Vijay Abraham I Message-ID: <577A15D2.5010103@ti.com> Date: Mon, 4 Jul 2016 13:22:50 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <00d5243a-0359-1dc7-e9aa-1ad8a9074821@wanadoo.fr> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Monday 04 July 2016 02:38 AM, Christophe JAILLET wrote: > I will resubmit in the coming days. > > return PTR_ERR(phy->clk); > should also be updated. while at that, also fix your $subject to something like "phy: sun9i-usb: fix error handling" Thanks Kishon > > Best regards, > CJ > > Le 03/07/2016 à 07:55, Christophe JAILLET a écrit : >> This is likely that checking 'phy->hsic_clk' instead of 'phy->clk' is >> expected here. >> >> Signed-off-by: Christophe JAILLET >> --- >> drivers/phy/phy-sun9i-usb.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/phy/phy-sun9i-usb.c b/drivers/phy/phy-sun9i-usb.c >> index ac4f31a..ff99eba 100644 >> --- a/drivers/phy/phy-sun9i-usb.c >> +++ b/drivers/phy/phy-sun9i-usb.c >> @@ -141,7 +141,7 @@ static int sun9i_usb_phy_probe(struct platform_device *pdev) >> } >> phy->hsic_clk = devm_clk_get(dev, "hsic_12M"); >> - if (IS_ERR(phy->clk)) { >> + if (IS_ERR(phy->hsic_clk)) { >> dev_err(dev, "failed to get hsic_12M clock\n"); >> return PTR_ERR(phy->clk); >> } > >