Re: [Qemu-devel] [RFC PATCH V2 2/3] filter-rewriter: track connection and parse packet

[Jason Wang <jasowang@redhat.com>]

On 2016年07月04日 15:47, Zhang Chen wrote:
>>> +    if (is_tcp_packet(pkt)) {
>>> +        if (sender == nf->netdev) {
>>> +            fill_connection_key(pkt, &key, SECONDARY);
>>> +        } else {
>>> +            fill_connection_key(pkt, &key, PRIMARY);
>>> +        }
>>> +
>>> +        conn = connection_get(s->connection_track_table,
>>> +                              &key,
>>> +                              &s->hashtable_size);
>>> +        if (!conn->processing) {
>>> +            qemu_mutex_lock(&s->conn_list_lock);
>>> +            g_queue_push_tail(&s->conn_list, conn);
>>> +            qemu_mutex_unlock(&s->conn_list_lock);
>>
>> conn_list was never used in this series, and I fail to understand why 
>> conn_list is needed?
>
> When filter-rewriter work with colo-frame we need this do some 
> synchronization job.
> like colo do checkpoint,we will flush connection.
> Maybe I should move this lock to other patch (like filter-rewriter 
> work with colo-frame).
>
> Thanks
> Zhang Chen 

Yes, please do it.