From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH 1/2] drm/amdgpu: remove unneeded conversions to bool Date: Mon, 4 Jul 2016 10:31:01 +0200 Message-ID: <577A1EC5.1020907@vodafone.de> References: <20160701142256.16926-1-afd@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from pegasos-out.vodafone.de (pegasos-out.vodafone.de [80.84.1.38]) by gabe.freedesktop.org (Postfix) with ESMTP id 00F2F6E177 for ; Mon, 4 Jul 2016 08:31:08 +0000 (UTC) In-Reply-To: <20160701142256.16926-1-afd@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: "Andrew F. Davis" , Alex Deucher , =?UTF-8?Q?Christian_K=c3=b6nig?= , David Airlie Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org QW0gMDEuMDcuMjAxNiB1bSAxNjoyMiBzY2hyaWViIEFuZHJldyBGLiBEYXZpczoKPiBGb3VuZCB3 aXRoIHNjcmlwdHMvY29jY2luZWxsZS9taXNjL2Jvb2xjb252LmNvY2NpLgo+Cj4gU2lnbmVkLW9m Zi1ieTogQW5kcmV3IEYuIERhdmlzIDxhZmRAdGkuY29tPgoKRm9yIGJvdGggcGF0Y2hlcyBSZXZp ZXdlZC1ieTogQ2hyaXN0aWFuIEvDtm5pZyA8Y2hyaXN0aWFuLmtvZW5pZ0BhbWQuY29tPi4KCj4g LS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9nZnhfdjhfMC5jICB8ICA4ICsrKyst LS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9nbWNfdjhfMC5jICB8ICA0ICsrLS0K PiAgIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L3NkbWFfdjNfMC5jIHwgIDQgKystLQo+ICAg ZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvdmkuYyAgICAgICAgfCAxNCArKysrKysrLS0tLS0t LQo+ICAgNCBmaWxlcyBjaGFuZ2VkLCAxNSBpbnNlcnRpb25zKCspLCAxNSBkZWxldGlvbnMoLSkK Pgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9nZnhfdjhfMC5jIGIv ZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvZ2Z4X3Y4XzAuYwo+IGluZGV4IDFhNWNiYWYuLmYz YzhjMzcgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvZ2Z4X3Y4XzAu Ywo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2dmeF92OF8wLmMKPiBAQCAtNTE0 NCwxMyArNTE0NCwxMyBAQCBzdGF0aWMgaW50IGdmeF92OF8wX3NldF9wb3dlcmdhdGluZ19zdGF0 ZSh2b2lkICpoYW5kbGUsCj4gICAJY2FzZSBDSElQX1BPTEFSSVMxMToKPiAgIAkJaWYgKGFkZXYt PnBnX2ZsYWdzICYgQU1EX1BHX1NVUFBPUlRfR0ZYX1NNRykKPiAgIAkJCXBvbGFyaXMxMV9lbmFi bGVfZ2Z4X3N0YXRpY19tZ19wb3dlcl9nYXRpbmcoYWRldiwKPiAtCQkJCQlzdGF0ZSA9PSBBTURf UEdfU1RBVEVfR0FURSA/IHRydWUgOiBmYWxzZSk7Cj4gKwkJCQkJc3RhdGUgPT0gQU1EX1BHX1NU QVRFX0dBVEUpOwo+ICAgCQllbHNlIGlmIChhZGV2LT5wZ19mbGFncyAmIEFNRF9QR19TVVBQT1JU X0dGWF9ETUcpCj4gICAJCQlwb2xhcmlzMTFfZW5hYmxlX2dmeF9keW5hbWljX21nX3Bvd2VyX2dh dGluZyhhZGV2LAo+IC0JCQkJCXN0YXRlID09IEFNRF9QR19TVEFURV9HQVRFID8gdHJ1ZSA6IGZh bHNlKTsKPiArCQkJCQlzdGF0ZSA9PSBBTURfUEdfU1RBVEVfR0FURSk7Cj4gICAJCWVsc2UKPiAg IAkJCXBvbGFyaXMxMV9lbmFibGVfZ2Z4X3F1aWNrX21nX3Bvd2VyX2dhdGluZyhhZGV2LAo+IC0J CQkJCXN0YXRlID09IEFNRF9QR19TVEFURV9HQVRFID8gdHJ1ZSA6IGZhbHNlKTsKPiArCQkJCQlz dGF0ZSA9PSBBTURfUEdfU1RBVEVfR0FURSk7Cj4gICAJCWJyZWFrOwo+ICAgCWRlZmF1bHQ6Cj4g ICAJCWJyZWFrOwo+IEBAIC01NTgzLDcgKzU1ODMsNyBAQCBzdGF0aWMgaW50IGdmeF92OF8wX3Nl dF9jbG9ja2dhdGluZ19zdGF0ZSh2b2lkICpoYW5kbGUsCj4gICAJY2FzZSBDSElQX0NBUlJJWk86 Cj4gICAJY2FzZSBDSElQX1NUT05FWToKPiAgIAkJZ2Z4X3Y4XzBfdXBkYXRlX2dmeF9jbG9ja19n YXRpbmcoYWRldiwKPiAtCQkJCQkJIHN0YXRlID09IEFNRF9DR19TVEFURV9HQVRFID8gdHJ1ZSA6 IGZhbHNlKTsKPiArCQkJCQkJIHN0YXRlID09IEFNRF9DR19TVEFURV9HQVRFKTsKPiAgIAkJYnJl YWs7Cj4gICAJZGVmYXVsdDoKPiAgIAkJYnJlYWs7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9hbWQvYW1kZ3B1L2dtY192OF8wLmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9n bWNfdjhfMC5jCj4gaW5kZXggOTk0NWQ1Yi4uNmMzYzczMCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vYW1kL2FtZGdwdS9nbWNfdjhfMC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2Ft ZC9hbWRncHUvZ21jX3Y4XzAuYwo+IEBAIC0xNDA2LDkgKzE0MDYsOSBAQCBzdGF0aWMgaW50IGdt Y192OF8wX3NldF9jbG9ja2dhdGluZ19zdGF0ZSh2b2lkICpoYW5kbGUsCj4gICAJc3dpdGNoIChh ZGV2LT5hc2ljX3R5cGUpIHsKPiAgIAljYXNlIENISVBfRklKSToKPiAgIAkJZmlqaV91cGRhdGVf bWNfbWVkaXVtX2dyYWluX2Nsb2NrX2dhdGluZyhhZGV2LAo+IC0JCQkJc3RhdGUgPT0gQU1EX0NH X1NUQVRFX0dBVEUgPyB0cnVlIDogZmFsc2UpOwo+ICsJCQkJc3RhdGUgPT0gQU1EX0NHX1NUQVRF X0dBVEUpOwo+ICAgCQlmaWppX3VwZGF0ZV9tY19saWdodF9zbGVlcChhZGV2LAo+IC0JCQkJc3Rh dGUgPT0gQU1EX0NHX1NUQVRFX0dBVEUgPyB0cnVlIDogZmFsc2UpOwo+ICsJCQkJc3RhdGUgPT0g QU1EX0NHX1NUQVRFX0dBVEUpOwo+ICAgCQlicmVhazsKPiAgIAlkZWZhdWx0Ogo+ICAgCQlicmVh azsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvc2RtYV92M18wLmMg Yi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9zZG1hX3YzXzAuYwo+IGluZGV4IDUzMmVhODgu LmU1N2NhYjYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvc2RtYV92 M18wLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9zZG1hX3YzXzAuYwo+IEBA IC0xNTQ3LDkgKzE1NDcsOSBAQCBzdGF0aWMgaW50IHNkbWFfdjNfMF9zZXRfY2xvY2tnYXRpbmdf c3RhdGUodm9pZCAqaGFuZGxlLAo+ICAgCWNhc2UgQ0hJUF9DQVJSSVpPOgo+ICAgCWNhc2UgQ0hJ UF9TVE9ORVk6Cj4gICAJCXNkbWFfdjNfMF91cGRhdGVfc2RtYV9tZWRpdW1fZ3JhaW5fY2xvY2tf Z2F0aW5nKGFkZXYsCj4gLQkJCQlzdGF0ZSA9PSBBTURfQ0dfU1RBVEVfR0FURSA/IHRydWUgOiBm YWxzZSk7Cj4gKwkJCQlzdGF0ZSA9PSBBTURfQ0dfU1RBVEVfR0FURSk7Cj4gICAJCXNkbWFfdjNf MF91cGRhdGVfc2RtYV9tZWRpdW1fZ3JhaW5fbGlnaHRfc2xlZXAoYWRldiwKPiAtCQkJCXN0YXRl ID09IEFNRF9DR19TVEFURV9HQVRFID8gdHJ1ZSA6IGZhbHNlKTsKPiArCQkJCXN0YXRlID09IEFN RF9DR19TVEFURV9HQVRFKTsKPiAgIAkJYnJlYWs7Cj4gICAJZGVmYXVsdDoKPiAgIAkJYnJlYWs7 Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L3ZpLmMgYi9kcml2ZXJz L2dwdS9kcm0vYW1kL2FtZGdwdS92aS5jCj4gaW5kZXggYTY1Yzk2MC4uZDM0MDRlZiAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS92aS5jCj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2FtZC9hbWRncHUvdmkuYwo+IEBAIC0xMzkzLDIyICsxMzkzLDIyIEBAIHN0YXRpYyBp bnQgdmlfY29tbW9uX3NldF9jbG9ja2dhdGluZ19zdGF0ZSh2b2lkICpoYW5kbGUsCj4gICAJc3dp dGNoIChhZGV2LT5hc2ljX3R5cGUpIHsKPiAgIAljYXNlIENISVBfRklKSToKPiAgIAkJdmlfdXBk YXRlX2JpZl9tZWRpdW1fZ3JhaW5fbGlnaHRfc2xlZXAoYWRldiwKPiAtCQkJCXN0YXRlID09IEFN RF9DR19TVEFURV9HQVRFID8gdHJ1ZSA6IGZhbHNlKTsKPiArCQkJCXN0YXRlID09IEFNRF9DR19T VEFURV9HQVRFKTsKPiAgIAkJdmlfdXBkYXRlX2hkcF9tZWRpdW1fZ3JhaW5fY2xvY2tfZ2F0aW5n KGFkZXYsCj4gLQkJCQlzdGF0ZSA9PSBBTURfQ0dfU1RBVEVfR0FURSA/IHRydWUgOiBmYWxzZSk7 Cj4gKwkJCQlzdGF0ZSA9PSBBTURfQ0dfU1RBVEVfR0FURSk7Cj4gICAJCXZpX3VwZGF0ZV9oZHBf bGlnaHRfc2xlZXAoYWRldiwKPiAtCQkJCXN0YXRlID09IEFNRF9DR19TVEFURV9HQVRFID8gdHJ1 ZSA6IGZhbHNlKTsKPiArCQkJCXN0YXRlID09IEFNRF9DR19TVEFURV9HQVRFKTsKPiAgIAkJdmlf dXBkYXRlX3JvbV9tZWRpdW1fZ3JhaW5fY2xvY2tfZ2F0aW5nKGFkZXYsCj4gLQkJCQlzdGF0ZSA9 PSBBTURfQ0dfU1RBVEVfR0FURSA/IHRydWUgOiBmYWxzZSk7Cj4gKwkJCQlzdGF0ZSA9PSBBTURf Q0dfU1RBVEVfR0FURSk7Cj4gICAJCWJyZWFrOwo+ICAgCWNhc2UgQ0hJUF9DQVJSSVpPOgo+ICAg CWNhc2UgQ0hJUF9TVE9ORVk6Cj4gICAJCXZpX3VwZGF0ZV9iaWZfbWVkaXVtX2dyYWluX2xpZ2h0 X3NsZWVwKGFkZXYsCj4gLQkJCQlzdGF0ZSA9PSBBTURfQ0dfU1RBVEVfR0FURSA/IHRydWUgOiBm YWxzZSk7Cj4gKwkJCQlzdGF0ZSA9PSBBTURfQ0dfU1RBVEVfR0FURSk7Cj4gICAJCXZpX3VwZGF0 ZV9oZHBfbWVkaXVtX2dyYWluX2Nsb2NrX2dhdGluZyhhZGV2LAo+IC0JCQkJc3RhdGUgPT0gQU1E X0NHX1NUQVRFX0dBVEUgPyB0cnVlIDogZmFsc2UpOwo+ICsJCQkJc3RhdGUgPT0gQU1EX0NHX1NU QVRFX0dBVEUpOwo+ICAgCQl2aV91cGRhdGVfaGRwX2xpZ2h0X3NsZWVwKGFkZXYsCj4gLQkJCQlz dGF0ZSA9PSBBTURfQ0dfU1RBVEVfR0FURSA/IHRydWUgOiBmYWxzZSk7Cj4gKwkJCQlzdGF0ZSA9 PSBBTURfQ0dfU1RBVEVfR0FURSk7Cj4gICAJCWJyZWFrOwo+ICAgCWRlZmF1bHQ6Cj4gICAJCWJy ZWFrOwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJp LWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753410AbcGDIbN (ORCPT ); Mon, 4 Jul 2016 04:31:13 -0400 Received: from pegasos-out.vodafone.de ([80.84.1.38]:52690 "EHLO pegasos-out.vodafone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753213AbcGDIbJ (ORCPT ); Mon, 4 Jul 2016 04:31:09 -0400 X-Spam-Flag: NO X-Spam-Score: 0.2 Authentication-Results: rohrpostix1.prod.vfnet.de (amavisd-new); dkim=pass header.i=@vodafone.de X-DKIM: OpenDKIM Filter v2.6.8 pegasos-out.vodafone.de C99AB2604C9 Subject: Re: [PATCH 1/2] drm/amdgpu: remove unneeded conversions to bool To: "Andrew F. Davis" , Alex Deucher , =?UTF-8?Q?Christian_K=c3=b6nig?= , David Airlie References: <20160701142256.16926-1-afd@ti.com> Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <577A1EC5.1020907@vodafone.de> Date: Mon, 4 Jul 2016 10:31:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <20160701142256.16926-1-afd@ti.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 01.07.2016 um 16:22 schrieb Andrew F. Davis: > Found with scripts/coccinelle/misc/boolconv.cocci. > > Signed-off-by: Andrew F. Davis For both patches Reviewed-by: Christian König . > --- > drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 8 ++++---- > drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c | 4 ++-- > drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c | 4 ++-- > drivers/gpu/drm/amd/amdgpu/vi.c | 14 +++++++------- > 4 files changed, 15 insertions(+), 15 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c > index 1a5cbaf..f3c8c37 100644 > --- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c > @@ -5144,13 +5144,13 @@ static int gfx_v8_0_set_powergating_state(void *handle, > case CHIP_POLARIS11: > if (adev->pg_flags & AMD_PG_SUPPORT_GFX_SMG) > polaris11_enable_gfx_static_mg_power_gating(adev, > - state == AMD_PG_STATE_GATE ? true : false); > + state == AMD_PG_STATE_GATE); > else if (adev->pg_flags & AMD_PG_SUPPORT_GFX_DMG) > polaris11_enable_gfx_dynamic_mg_power_gating(adev, > - state == AMD_PG_STATE_GATE ? true : false); > + state == AMD_PG_STATE_GATE); > else > polaris11_enable_gfx_quick_mg_power_gating(adev, > - state == AMD_PG_STATE_GATE ? true : false); > + state == AMD_PG_STATE_GATE); > break; > default: > break; > @@ -5583,7 +5583,7 @@ static int gfx_v8_0_set_clockgating_state(void *handle, > case CHIP_CARRIZO: > case CHIP_STONEY: > gfx_v8_0_update_gfx_clock_gating(adev, > - state == AMD_CG_STATE_GATE ? true : false); > + state == AMD_CG_STATE_GATE); > break; > default: > break; > diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c > index 9945d5b..6c3c730 100644 > --- a/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c > @@ -1406,9 +1406,9 @@ static int gmc_v8_0_set_clockgating_state(void *handle, > switch (adev->asic_type) { > case CHIP_FIJI: > fiji_update_mc_medium_grain_clock_gating(adev, > - state == AMD_CG_STATE_GATE ? true : false); > + state == AMD_CG_STATE_GATE); > fiji_update_mc_light_sleep(adev, > - state == AMD_CG_STATE_GATE ? true : false); > + state == AMD_CG_STATE_GATE); > break; > default: > break; > diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c > index 532ea88..e57cab6 100644 > --- a/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c > @@ -1547,9 +1547,9 @@ static int sdma_v3_0_set_clockgating_state(void *handle, > case CHIP_CARRIZO: > case CHIP_STONEY: > sdma_v3_0_update_sdma_medium_grain_clock_gating(adev, > - state == AMD_CG_STATE_GATE ? true : false); > + state == AMD_CG_STATE_GATE); > sdma_v3_0_update_sdma_medium_grain_light_sleep(adev, > - state == AMD_CG_STATE_GATE ? true : false); > + state == AMD_CG_STATE_GATE); > break; > default: > break; > diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c b/drivers/gpu/drm/amd/amdgpu/vi.c > index a65c960..d3404ef 100644 > --- a/drivers/gpu/drm/amd/amdgpu/vi.c > +++ b/drivers/gpu/drm/amd/amdgpu/vi.c > @@ -1393,22 +1393,22 @@ static int vi_common_set_clockgating_state(void *handle, > switch (adev->asic_type) { > case CHIP_FIJI: > vi_update_bif_medium_grain_light_sleep(adev, > - state == AMD_CG_STATE_GATE ? true : false); > + state == AMD_CG_STATE_GATE); > vi_update_hdp_medium_grain_clock_gating(adev, > - state == AMD_CG_STATE_GATE ? true : false); > + state == AMD_CG_STATE_GATE); > vi_update_hdp_light_sleep(adev, > - state == AMD_CG_STATE_GATE ? true : false); > + state == AMD_CG_STATE_GATE); > vi_update_rom_medium_grain_clock_gating(adev, > - state == AMD_CG_STATE_GATE ? true : false); > + state == AMD_CG_STATE_GATE); > break; > case CHIP_CARRIZO: > case CHIP_STONEY: > vi_update_bif_medium_grain_light_sleep(adev, > - state == AMD_CG_STATE_GATE ? true : false); > + state == AMD_CG_STATE_GATE); > vi_update_hdp_medium_grain_clock_gating(adev, > - state == AMD_CG_STATE_GATE ? true : false); > + state == AMD_CG_STATE_GATE); > vi_update_hdp_light_sleep(adev, > - state == AMD_CG_STATE_GATE ? true : false); > + state == AMD_CG_STATE_GATE); > break; > default: > break;