From: Peter Lieven <pl@kamp.de>
To: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: Eric Blake <eblake@redhat.com>, Kevin Wolf <kwolf@redhat.com>
Subject: [Qemu-devel] Regression: block: Add .bdrv_co_pwrite_zeroes()
Date: Mon, 4 Jul 2016 15:49:09 +0200 [thread overview]
Message-ID: <577A6955.6020603@kamp.de> (raw)
Hi,
the above commit:
commit d05aa8bb4a8b6aa9a915ec5074fb12ae632d2323
Author: Eric Blake <eblake@redhat.com>
Date: Wed Jun 1 15:10:03 2016 -0600
block: Add .bdrv_co_pwrite_zeroes()
introduces a regression (at least for me).
The Limits from the iSCSI Block Limits VPD have no requirement of being a power of two.
We use Dell Equallogic iSCSI SANs for instance. They have an internal page size of 15MB. And
they advertise this page size as max_ws_len, opt_transfer_len and opt_discard_alignment.
I think we cannot assert that that these alignments are a power of 2.
Peter
next reply other threads:[~2016-07-04 13:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-04 13:49 Peter Lieven [this message]
2016-07-05 1:53 ` [Qemu-devel] Regression: block: Add .bdrv_co_pwrite_zeroes() Eric Blake
2016-07-05 7:30 ` Peter Lieven
2016-07-05 13:03 ` Eric Blake
2016-07-05 13:39 ` Paolo Bonzini
2016-07-05 13:37 ` Paolo Bonzini
2016-07-05 13:40 ` Peter Lieven
2016-07-05 14:59 ` Eric Blake
2016-07-05 15:09 ` Paolo Bonzini
2016-07-15 10:09 ` Peter Lieven
2016-07-15 15:40 ` Eric Blake
2016-07-18 7:06 ` Peter Lieven
2016-07-20 23:35 ` Eric Blake
2016-07-21 7:01 ` Peter Lieven
2016-07-21 9:10 ` Paolo Bonzini
2016-07-21 9:08 ` Paolo Bonzini
2016-07-21 15:12 ` Eric Blake
2016-07-21 13:38 ` wangweiwei
2016-07-21 13:45 ` wangweiwei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=577A6955.6020603@kamp.de \
--to=pl@kamp.de \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.