From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58466) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bK8Vg-0002Cr-53 for qemu-devel@nongnu.org; Mon, 04 Jul 2016 14:22:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bK8Va-0002QX-5R for qemu-devel@nongnu.org; Mon, 04 Jul 2016 14:22:19 -0400 References: <1467643124-29778-1-git-send-email-den@openvz.org> <1cd0922f-da5f-2325-8888-dfa134a5a72f@redhat.com> From: Evgeny Yakovlev Message-ID: <577A855D.7060803@virtuozzo.com> Date: Mon, 4 Jul 2016 18:48:45 +0300 MIME-Version: 1.0 In-Reply-To: <1cd0922f-da5f-2325-8888-dfa134a5a72f@redhat.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 0/4] block: ignore flush requests when storage is clean List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , "Denis V. Lunev" , qemu-block@nongnu.org, qemu-devel@nongnu.org Cc: Kevin Wolf , Fam Zheng , Max Reitz , Stefan Hajnoczi , John Snow On 04.07.2016 17:53, Paolo Bonzini wrote: > On 04/07/2016 16:38, Denis V. Lunev wrote: >> Changes from v4: >> - Moved to write generation scheme instead of dirty flag >> - Added retry setup to IDE PIO and FLUSH requests >> >> Changes from v3: >> - Fixed a typo in commit message >> - Rebased on Kevin'n origin/block >> >> Changes from v2: >> - Better comments >> - Rebased on latest master >> >> Changes from v1: >> - Flush requests that should be skipped will now wait for completion >> of any previous requests already in flight >> - Fixed IDE and AHCI tests to dirty media for new flush behaviour >> - Fixed a problem in IDE CMD_FLUSH_CACHE failure handling >> >> Signed-off-by: Evgeny Yakovlev >> Signed-off-by: Denis V. Lunev >> CC: Kevin Wolf >> CC: Max Reitz >> CC: Stefan Hajnoczi >> CC: Fam Zheng >> CC: John Snow >> >> Evgeny Yakovlev (4): >> ide: refactor retry_unit set and clear into separate function >> ide: set retry_unit for PIO and FLUSH requests >> tests: in IDE and AHCI tests perform DMA write before flushing >> block: ignore flush requests when storage is clean >> >> block.c | 3 +++ >> block/io.c | 18 ++++++++++++++++++ >> hw/ide/core.c | 24 ++++++++++++++++++------ >> include/block/block_int.h | 5 +++++ >> tests/ahci-test.c | 34 ++++++++++++++++++++++++++++++++-- >> tests/ide-test.c | 43 +++++++++++++++++++++++++++++++++++++++++++ >> 6 files changed, 119 insertions(+), 8 deletions(-) >> > Reviewed-by: Paolo Bonzini > > Thanks! You're welcome! > > Paolo