From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51160) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bKEs9-0004fu-Mk for qemu-devel@nongnu.org; Mon, 04 Jul 2016 21:09:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bKEs4-0005XF-Ep for qemu-devel@nongnu.org; Mon, 04 Jul 2016 21:09:56 -0400 Received: from szxga01-in.huawei.com ([58.251.152.64]:18156) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bKEs3-0005WX-KU for qemu-devel@nongnu.org; Mon, 04 Jul 2016 21:09:52 -0400 Message-ID: <577B08BF.8070105@huawei.com> Date: Tue, 5 Jul 2016 09:09:19 +0800 From: Shannon Zhao MIME-Version: 1.0 References: <1467647479-40202-1-git-send-email-imammedo@redhat.com> <1467647479-40202-4-git-send-email-imammedo@redhat.com> In-Reply-To: <1467647479-40202-4-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 3/5] numa: reduce code duplication by adding helper numa_get_node_for_cpu() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , qemu-devel@nongnu.org Cc: marcel@redhat.com, peter.maydell@linaro.org, david@gibson.dropbear.id.au, mst@redhat.com On 2016/7/4 23:51, Igor Mammedov wrote: > Replace repeated pattern > > for (i = 0; i < nb_numa_nodes; i++) { > if (test_bit(idx, numa_info[i].node_cpu)) { > ... > break; > > with a helper function to lookup numa node index for cpu. > > Suggested-by: Michael S. Tsirkin > Signed-off-by: Igor Mammedov > Reviewed-by: David Gibson Reviewed-by: Shannon Zhao -- Shannon