From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 31754E00DA7; Tue, 5 Jul 2016 03:59:37 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [209.85.192.181 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily * valid * -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Received: from mail-pf0-f181.google.com (mail-pf0-f181.google.com [209.85.192.181]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id BE708E00DA4 for ; Tue, 5 Jul 2016 03:59:32 -0700 (PDT) Received: by mail-pf0-f181.google.com with SMTP id t190so69373337pfb.3 for ; Tue, 05 Jul 2016 03:59:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding; bh=dYsrjl8ODhg6pLMuX8drYuaEzHOI8pU0267PySfhQFY=; b=bzgJ8uev8ZiTj5X276QiyKQaUc1ml2Dwj7fMlA0yPbBDUejOQu3k1E03dICKO5vqfu cZb+wUWrquMC0LZKjgWvSaxNiyayJzsfqgMPE+pN1bChNE9XSabmvuAFYUkz1aFSL4+l k/tmKk5PoTbxYEW0WvvaJFUiGOx+5AdnPiYgz5OVDC/o0hdPn7z+XZrHld+xNtx9Xamd JH2UukwvFRBAZzga3gLmcj223O7L3dyntxkUF5DgQQIn0sHoJVZ/ccbZjcoVvMkH0yf3 dcRcG1j1ckq4nUPfzjfWiaICMbxRF7Vc1QTvX64bUUItntOCzFQY6rDLnZO6Wb1ttCRF Kpug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=dYsrjl8ODhg6pLMuX8drYuaEzHOI8pU0267PySfhQFY=; b=ALM05SjbPKVwuFj8sGYEXXyGpVYLB6DjjuYPlMFiDIhUqJNcRnrFsAo28M4TgHBivh aKiXEbDMaQr9troYYShkeXbLOkzX/81WG+vRrUdGYvKPGoL7DiN/cuij9gR2lf/HjzL7 w0ryYvk2Rzut1kHiz5sjqMnsh2b+U9SNwk10pF5+t/6vMaaiKW2uWZmPiIgQAU9nKScU lmyRmVbMLhMoNYzgWIx+AhVxy4EKWnQRKYPK7rDP+5zZnUTTs1AR3XQZd1tfbRaBcpES /i/3IWOFudsAnMI4sCcuYvrs4sc12TFEXsjl+SKblDjivnIuIbzYGrS2fYLpMInf3e9u yerA== X-Gm-Message-State: ALyK8tLfUilj6ZTDvqHcmUBIY/xAdVHofJ2l4VqOnjXBUkvAco4A2CJl0EPL6U1Q7Lsnr8Jb X-Received: by 10.98.20.216 with SMTP id 207mr31083975pfu.144.1467716372111; Tue, 05 Jul 2016 03:59:32 -0700 (PDT) Received: from [192.168.0.78] (host86-169-85-169.range86-169.btcentralplus.com. [86.169.85.169]) by smtp.googlemail.com with ESMTPSA id y63sm3792314pfb.13.2016.07.05.03.59.30 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Jul 2016 03:59:31 -0700 (PDT) To: toaster@yoctoproject.org References: From: Michael Wood Message-ID: <577B9310.4010106@intel.com> Date: Tue, 5 Jul 2016 11:59:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: Subject: Re: Database design and Target objects X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jul 2016 10:59:37 -0000 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit On 04/07/16 11:54, Smith, Elliot wrote: > The Target object in Toaster's database currently has a > license_manifest_path, which is only set for targets which produce > images. (This means that manifest files are treated differently from > other types of build artifact.) > > In Toaster's build dashboard, we show this as the License manifest, > with a link. > > However, Belen's new designs call for a separate section for > manifests, with links to both the package manifest and the license > manifest. This means linking a Target to another type of manifest. > > I can see broadly two ways to do this: > > 1. Add a package_license_manifest field to the Target object. This > fits with the approach we have for the license manifest and is most > expedient, but feels wrong in terms of good practice for database design. > > 2. Add a separate category of manifest file objects associated with > Target, into which both license and package manifests are inserted. > This feels better but is much more work and makes the database more > complicated than it already is. > > This is partly a general philosophical question: should we start > repairing problems with Toaster's database design now (option 2), or > find expedient solutions which follow existing (though sometimes poor) > patterns (option 1)? > > My preference is option 2, but the number of outstanding bugs makes me > consider 1 (not just for this bug, but, again, generally). > > Any comments would be welcome. > Elliot > > -- > Elliot Smith > Software Engineer > Intel Open Source Technology Centre > > With this release we are definitely trying to tidy things up, but I think option 2 is only a good option if you foresee more manifests types coming up in the future. Otherwise for just two types of manifest I don't think it matters that much to have an extra field in the Target model. Michael