From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Pablo de Lara <pablo.de.lara.guarch@intel.com>, dev@dpdk.org
Cc: john.mcnamara@intel.com
Subject: Re: [PATCH] doc: announce API change for virtual device initialization
Date: Tue, 5 Jul 2016 14:04:27 +0100 [thread overview]
Message-ID: <577BB05B.3070203@intel.com> (raw)
In-Reply-To: <1467643848-14780-1-git-send-email-pablo.de.lara.guarch@intel.com>
On 7/4/2016 3:50 PM, Pablo de Lara wrote:
> In order to create a virtual device, user needs to call
> rte_eal_vdev_init generally, but this function returns 0
> on success or negative number if error. Instead, something
> more useful would be to return the port or device id of the
> device created, so the user can call rte_eal_vdev_init
> function and use the device straight away, using the id returned
> by the function.
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
> doc/guides/rel_notes/deprecation.rst | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index f502f86..60cc7c7 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -41,3 +41,8 @@ Deprecation Notices
> * The mempool functions for single/multi producer/consumer are deprecated and
> will be removed in 16.11.
> It is replaced by rte_mempool_generic_get/put functions.
> +
> +* The rte_eal_vdev_init function will be changed in 16.11 to return
> + the port/device id of the device created, instead of 0, when it has been
> + initialized successfully, so user can use the returned value straight away
> + to call all the device functions that require that parameter.
>
Hi Pablo,
There is another API rte_eth_dev_attach(), which returns port_id, and is
a common wrapper both for pdev and vdev.
So with proper devargs this API calls rte_eal_vdev_init() and returns
port_id (set in argument) without any extra side effect.
I just would like remind it in case that works for you, since what
rte_eth_dev_attach() does sounds like what is targeted with this API change.
Thanks,
ferruh
next prev parent reply other threads:[~2016-07-05 13:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-04 14:50 [PATCH] doc: announce API change for virtual device initialization Pablo de Lara
2016-07-05 10:44 ` Declan Doherty
2016-07-05 13:04 ` Ferruh Yigit [this message]
2016-07-05 13:38 ` Thomas Monjalon
2016-07-05 14:55 ` De Lara Guarch, Pablo
2016-07-06 10:59 ` De Lara Guarch, Pablo
2016-07-28 12:18 ` David Marchand
2016-07-28 15:47 ` De Lara Guarch, Pablo
2016-07-28 15:56 ` David Marchand
2016-07-29 17:35 ` Andriy Berestovskyy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=577BB05B.3070203@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.