From: Jon Hunter <jonathanh@nvidia.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Laxman Dewangan <ldewangan@nvidia.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Thierry Reding <thierry.reding@gmail.com>,
Alexandre Courbot <gnurou@gmail.com>,
Shardar Shariff Md <smohammed@nvidia.com>,
linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: tegra: Correct error path in probe
Date: Tue, 5 Jul 2016 14:21:23 +0100 [thread overview]
Message-ID: <577BB453.7020903@nvidia.com> (raw)
In-Reply-To: <5770F2CB.2090109@nvidia.com>
Wolfram,
On 27/06/16 10:32, Laxman Dewangan wrote:
>
> On Monday 27 June 2016 02:58 PM, Jon Hunter wrote:
>> Hi all,
>>
>> On 14/06/16 21:26, Jon Hunter wrote:
>>> @@ -912,7 +912,7 @@ static int tegra_i2c_probe(struct platform_device
>>> *pdev)
>>> ret = tegra_i2c_init(i2c_dev);
>>> if (ret) {
>>> dev_err(&pdev->dev, "Failed to initialize i2c controller");
>>> - goto unprepare_div_clk;
>>> + goto disable_div_clk;
>>> }
>>>
>
> Yes, this looks correct.
>
> Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
Can you pick this one up?
Cheers
Jon
--
nvpublic
WARNING: multiple messages have this Message-ID (diff)
From: Jon Hunter <jonathanh@nvidia.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Laxman Dewangan <ldewangan@nvidia.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Thierry Reding <thierry.reding@gmail.com>,
"Alexandre Courbot" <gnurou@gmail.com>,
Shardar Shariff Md <smohammed@nvidia.com>,
<linux-i2c@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] i2c: tegra: Correct error path in probe
Date: Tue, 5 Jul 2016 14:21:23 +0100 [thread overview]
Message-ID: <577BB453.7020903@nvidia.com> (raw)
In-Reply-To: <5770F2CB.2090109@nvidia.com>
Wolfram,
On 27/06/16 10:32, Laxman Dewangan wrote:
>
> On Monday 27 June 2016 02:58 PM, Jon Hunter wrote:
>> Hi all,
>>
>> On 14/06/16 21:26, Jon Hunter wrote:
>>> @@ -912,7 +912,7 @@ static int tegra_i2c_probe(struct platform_device
>>> *pdev)
>>> ret = tegra_i2c_init(i2c_dev);
>>> if (ret) {
>>> dev_err(&pdev->dev, "Failed to initialize i2c controller");
>>> - goto unprepare_div_clk;
>>> + goto disable_div_clk;
>>> }
>>>
>
> Yes, this looks correct.
>
> Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
Can you pick this one up?
Cheers
Jon
--
nvpublic
next prev parent reply other threads:[~2016-07-05 13:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-14 20:26 [PATCH] i2c: tegra: Correct error path in probe Jon Hunter
2016-06-14 20:26 ` Jon Hunter
[not found] ` <1465936007-18599-1-git-send-email-jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-06-27 9:28 ` Jon Hunter
2016-06-27 9:28 ` Jon Hunter
2016-06-27 9:32 ` Laxman Dewangan
2016-06-27 9:32 ` Laxman Dewangan
2016-07-05 13:21 ` Jon Hunter [this message]
2016-07-05 13:21 ` Jon Hunter
2016-07-05 15:22 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=577BB453.7020903@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=gnurou@gmail.com \
--cc=ldewangan@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=smohammed@nvidia.com \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.