From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56405) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bKQas-0003LA-QN for qemu-devel@nongnu.org; Tue, 05 Jul 2016 09:40:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bKQam-0000ed-RK for qemu-devel@nongnu.org; Tue, 05 Jul 2016 09:40:53 -0400 Received: from mx-v6.kamp.de ([2a02:248:0:51::16]:58020 helo=mx01.kamp.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bKQam-0000ck-Fy for qemu-devel@nongnu.org; Tue, 05 Jul 2016 09:40:48 -0400 References: <577A6955.6020603@kamp.de> <577B130A.3040205@redhat.com> <3221d3d3-37ee-9752-396e-379792445ee0@redhat.com> From: Peter Lieven Message-ID: <577BB8DD.6060609@kamp.de> Date: Tue, 5 Jul 2016 15:40:45 +0200 MIME-Version: 1.0 In-Reply-To: <3221d3d3-37ee-9752-396e-379792445ee0@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] Regression: block: Add .bdrv_co_pwrite_zeroes() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , Eric Blake , "qemu-devel@nongnu.org" Cc: Kevin Wolf Am 05.07.2016 um 15:37 schrieb Paolo Bonzini: > > On 05/07/2016 03:53, Eric Blake wrote: >>>> I think we cannot assert that that these alignments are a power of 2. >> Perhaps that means we should just fix our code to round things down to >> the nearest power of 2 (8MB) for the opt_transfer_len and >> opt_discard_alignment values. Can you post a stack-trace of the actual >> assertion you are hitting? > It doesn't work for opt_discard_alignment. Neither 8MB nor 16MB is > aligned to 15MB for example. Right, we should keep these limits. And if we need to round down for any reason we should use the gcd of both values. Peter