From: Florian Fainelli <f.fainelli@gmail.com>
To: Mason <slash.tmp@free.fr>, linux-pm <linux-pm@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Cc: Sebastian Frias <sf84@laposte.net>
Subject: Re: WARNING: CPU: 0 PID: 0 at net/ipv4/af_inet.c:155 inet_sock_destruct+0x1c4/0x1dc
Date: Tue, 5 Jul 2016 14:55:09 -0700 [thread overview]
Message-ID: <577C2CBD.2060905@gmail.com> (raw)
In-Reply-To: <577C2BF0.7030409@free.fr>
On 07/05/2016 02:51 PM, Mason wrote:
>>> Therefore, loss of context cannot possibly explain the
>>> warning I am seeing.
>>
>> No, but if you go all the way down to trying to suspend and the last
>> step is the firmware failing, anything you have suspended needs to be
>> unwinded, for your ethernet driver that means that you went through a
>> successful suspend then resume cycle even if it failed down later when
>> the platform attempted to suspend.
>
> So it is the driver's responsibility to "shut down" on resume?
It is the driver responsibility to know how to suspend and resume a
device it manages, and it does that by implementing appropriate
suspend/resume callbacks.
> (I had the vague impression that the suspend framework would
> "disable" the device through the appropriate callback.)
The suspend framework knows which drivers implement suspend/resume and
calls them appropriately (based on parenting/bus hierarchy), but it
won't automatigally do anything because there is no such thing as magic
when it comes to suspending hardware, this needs to be a controlled
sequence.
--
Florian
next prev parent reply other threads:[~2016-07-05 21:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-05 13:33 WARNING: CPU: 0 PID: 0 at net/ipv4/af_inet.c:155 inet_sock_destruct+0x1c4/0x1dc Mason
2016-07-05 14:50 ` Mason
2016-07-05 15:28 ` Florian Fainelli
2016-07-05 15:56 ` Mason
2016-07-05 16:20 ` Florian Fainelli
2016-07-05 20:26 ` Mason
2016-07-05 21:22 ` Florian Fainelli
2016-07-05 21:51 ` Mason
2016-07-05 21:55 ` Florian Fainelli [this message]
2016-07-12 9:53 ` Mason
2016-07-12 9:53 ` Mason
2016-07-12 11:48 ` Mason
2016-07-12 11:48 ` Mason
2016-07-12 14:25 ` Eric Dumazet
2016-07-12 14:25 ` Eric Dumazet
2016-07-12 14:38 ` Mason
2016-07-12 14:38 ` Mason
2016-07-13 12:11 ` Mason
2016-07-13 12:11 ` Mason
2016-07-13 12:11 ` Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=577C2CBD.2060905@gmail.com \
--to=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sf84@laposte.net \
--cc=slash.tmp@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.