From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36891) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bKYdf-00043u-Qh for qemu-devel@nongnu.org; Tue, 05 Jul 2016 18:16:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bKYdd-0003Aj-P1 for qemu-devel@nongnu.org; Tue, 05 Jul 2016 18:16:18 -0400 References: <1467514729-29366-1-git-send-email-eblake@redhat.com> <1467514729-29366-11-git-send-email-eblake@redhat.com> From: Eric Blake Message-ID: <577C31A6.6030105@redhat.com> Date: Tue, 5 Jul 2016 16:16:06 -0600 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="JdSsHSm6JnGdKq756BjrkC3QNxK3okGTE" Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v8 10/16] block: Simplify drive-mirror List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-devel@nongnu.org Cc: Kevin Wolf , Luiz Capitulino , armbru@redhat.com, "open list:Block layer core" , Max Reitz This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --JdSsHSm6JnGdKq756BjrkC3QNxK3okGTE From: Eric Blake To: John Snow , qemu-devel@nongnu.org Cc: Kevin Wolf , Luiz Capitulino , armbru@redhat.com, "open list:Block layer core" , Max Reitz Message-ID: <577C31A6.6030105@redhat.com> Subject: Re: [Qemu-block] [PATCH v8 10/16] block: Simplify drive-mirror References: <1467514729-29366-1-git-send-email-eblake@redhat.com> <1467514729-29366-11-git-send-email-eblake@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/05/2016 02:27 PM, John Snow wrote: >=20 >=20 > On 07/02/2016 10:58 PM, Eric Blake wrote: >> Now that we can support boxed commands, use it to greatly >> reduce the number of parameters (and likelihood of getting >> out of sync) when adjusting drive-mirror parameters. >> >> Signed-off-by: Eric Blake >> >> @@ -1154,12 +1169,9 @@ >> # written. Both will result in identical contents. >> # Default is true. (Since 2.4) >> # >> -# Returns: nothing on success >> -# If @device is not a valid block device, DeviceNotFound >> -# >> # Since 1.3 >=20 > Should this still be "Since 1.3" for DriveMirror as a structure, since > it's being newly created? >=20 > (What color of shed would you like? Any color is fine for me.) Introspection output is unchanged, and doesn't include 'since:' information (we intentionally made introspection agnostic to backwards-compatible changes, such as creating a named type in place of an inline one). So unless Markus has any particular advice on a better number to use, I think leaving the version number associated with the first time the associated command was around is as close to the truth as is necessary. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --JdSsHSm6JnGdKq756BjrkC3QNxK3okGTE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXfDGnAAoJEKeha0olJ0NqRNUH/jjFQrthZg4P1TMUMXgc0xqt r3vwNgAYw8rORBqqY6MbjpTt431YGDmZr4fD6tgFHOApPIzq+s0F8YCEEr/MLh3i UqYtjRU77Lya2gYSn5nPVlm1YqzjSoswAgJoMRsHf7h/bHsLoTTkfniV2gxe9v9k KCwVvzWa0mjkpjI4pu2r97L8zZ7WUu/2AoDyVaj+C2x1KGMhAgA7rbTsgZwIPR9h Usflvx2yrsQR4yPmjvkUCyrldTSDv7b53XMncYITXxpU60To7dbLyFYPRFND0gxI g/RvDWm5T4BolxSG1wqim+FoSdXhO00URF7Kj38rmhfSysiEKVAwRjanE2VnJ6g= =6O5o -----END PGP SIGNATURE----- --JdSsHSm6JnGdKq756BjrkC3QNxK3okGTE--