From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chanwoo Choi Subject: Re: [PATCH] memory: samsung: exynos-srom: fix wrong count of registers Date: Wed, 06 Jul 2016 09:12:18 +0900 Message-ID: <577C4CE2.2090103@samsung.com> References: <1467718817-19239-1-git-send-email-sw0312.kim@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mailout3.samsung.com ([203.254.224.33]:40178 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750840AbcGFAM0 (ORCPT ); Tue, 5 Jul 2016 20:12:26 -0400 In-reply-to: <1467718817-19239-1-git-send-email-sw0312.kim@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Seung-Woo Kim , linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, k.kozlowski@samsung.com, kgene@kernel.org On 2016=EB=85=84 07=EC=9B=94 05=EC=9D=BC 20:40, Seung-Woo Kim wrote: > This patch fixes wrong count of array for srom registers from probe > function. >=20 > Signed-off-by: Seung-Woo Kim > --- > drivers/memory/samsung/exynos-srom.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/memory/samsung/exynos-srom.c b/drivers/memory/sa= msung/exynos-srom.c > index 96756fb..c66d2bd 100644 > --- a/drivers/memory/samsung/exynos-srom.c > +++ b/drivers/memory/samsung/exynos-srom.c > @@ -134,7 +134,7 @@ static int exynos_srom_probe(struct platform_devi= ce *pdev) > platform_set_drvdata(pdev, srom); > =20 > srom->reg_offset =3D exynos_srom_alloc_reg_dump(exynos_srom_offsets= , > - sizeof(exynos_srom_offsets)); > + ARRAY_SIZE(exynos_srom_offsets)); > if (!srom->reg_offset) { > iounmap(srom->reg_base); > return -ENOMEM; >=20 On the exynos-srom.c, use the ARRAY_SIZE to get the number of array ent= ry. Looks good to me. Reviewed-by: Chanwoo Choi Thanks, Chanwoo Choi From mboxrd@z Thu Jan 1 00:00:00 1970 From: cw00.choi@samsung.com (Chanwoo Choi) Date: Wed, 06 Jul 2016 09:12:18 +0900 Subject: [PATCH] memory: samsung: exynos-srom: fix wrong count of registers In-Reply-To: <1467718817-19239-1-git-send-email-sw0312.kim@samsung.com> References: <1467718817-19239-1-git-send-email-sw0312.kim@samsung.com> Message-ID: <577C4CE2.2090103@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2016? 07? 05? 20:40, Seung-Woo Kim wrote: > This patch fixes wrong count of array for srom registers from probe > function. > > Signed-off-by: Seung-Woo Kim > --- > drivers/memory/samsung/exynos-srom.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/memory/samsung/exynos-srom.c b/drivers/memory/samsung/exynos-srom.c > index 96756fb..c66d2bd 100644 > --- a/drivers/memory/samsung/exynos-srom.c > +++ b/drivers/memory/samsung/exynos-srom.c > @@ -134,7 +134,7 @@ static int exynos_srom_probe(struct platform_device *pdev) > platform_set_drvdata(pdev, srom); > > srom->reg_offset = exynos_srom_alloc_reg_dump(exynos_srom_offsets, > - sizeof(exynos_srom_offsets)); > + ARRAY_SIZE(exynos_srom_offsets)); > if (!srom->reg_offset) { > iounmap(srom->reg_base); > return -ENOMEM; > On the exynos-srom.c, use the ARRAY_SIZE to get the number of array entry. Looks good to me. Reviewed-by: Chanwoo Choi Thanks, Chanwoo Choi