From: Daniel Borkmann <daniel@iogearbox.net>
To: David Miller <davem@davemloft.net>, alexei.starovoitov@gmail.com
Cc: sargun@sargun.me, netdev@vger.kernel.org
Subject: Re: Backport bpf: try harder on clones when writing into skb? [Commit: 3697649ff29e0f647565eed04b27a7779c646a22]
Date: Wed, 06 Jul 2016 10:12:57 +0200 [thread overview]
Message-ID: <577CBD89.4060303@iogearbox.net> (raw)
In-Reply-To: <20160705.204755.193524893150572527.davem@davemloft.net>
On 07/06/2016 05:47 AM, David Miller wrote:
> From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
> Date: Tue, 5 Jul 2016 19:16:51 -0700
>
>> On Tue, Jul 05, 2016 at 08:35:18AM -0700, Sargun Dhillon wrote:
>>> Does it make sense to backport
>>> 3697649ff29e0f647565eed04b27a7779c646a22 from 4.6 to the longterm
>>> (4.4) release? I can trivially recreate the issue represented by
>>> 3697649ff29e0f647565eed04b27a7779c646a22 by attaching a eBPF filter
>>> that clones an ingress ICMP packet, and then tries to set the
>>> destination MAC address.
>>>
>>> It seems like the patch applies cleanly to 4.4. I cherry-picked it,
>>> and rebuilt my kernel, and at least in the trivial test case passes.
>>
>> Makes sense to me, especially since it's lts.
>> Daniel, thoughts?
>
> I'll queued this up for 4.4 -stable.
Sounds good, thanks!
prev parent reply other threads:[~2016-07-06 8:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-05 15:35 Backport bpf: try harder on clones when writing into skb? [Commit: 3697649ff29e0f647565eed04b27a7779c646a22] Sargun Dhillon
2016-07-06 2:16 ` Alexei Starovoitov
2016-07-06 3:47 ` David Miller
2016-07-06 8:12 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=577CBD89.4060303@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=alexei.starovoitov@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sargun@sargun.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.