From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 3DACBE00C5D; Wed, 6 Jul 2016 06:33:21 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily * valid * -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [74.125.82.52 listed in list.dnswl.org] Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id E0CD9E007F2 for ; Wed, 6 Jul 2016 06:33:17 -0700 (PDT) Received: by mail-wm0-f52.google.com with SMTP id r201so192987298wme.1 for ; Wed, 06 Jul 2016 06:33:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding; bh=63sGGzKsFuUwYhcCWRFiR96n/VxaJUTz7OzdqdXvytE=; b=hUqhEn13jn/UH8lgjMmSWlN4d+WNAo15wVDQJnl4FjFG98hB5fljhxw5wUMxv/mKB4 B8K8YU2JdoqzrrDjlSd1c6uPcnjAV26mNlCNVJahxj8P9+MP1oytaNvw2BlU01cDSorx XYRiIi4NrdBNulgZ+NnBh8k6WPgEQWftwP0a+IoslkqFOd1/422Ois/Ytx+HTG7M/77g 6qJVM3gZu0mZzlN+RjMa42d7uZnRz87k1shnfmoom8YTZ2QMOtLDcoTysWtCJGNpX1ap 4xLcAijvEGTl323lBKLQSX7B28OlGU2ax0oXYeqbEJMNIZbXoDwFHjMAMrQmnZc1H05V ewDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=63sGGzKsFuUwYhcCWRFiR96n/VxaJUTz7OzdqdXvytE=; b=DAGenTrlVFcQwfOem9sF2QdFKNKoIdny89RhmpAUr5eLd/0gVcr1inSMaze3H9o8nx fkIicWoBut75mURsVm2UbaGdfdRzW8Nl9eBc3Iz7V4Gm7DKlSMYxweKn1NDExkNbOYmH E/SLGFk9F3xJgBR+eNjnCk5AKPANcVJ8SIndyEo2N/etTMdPJMPWd3iY0k8N6vB5LlIy jwDb+UeAoiRWqXz8+b2AJSYEt9QUtGCAvGdJeQ1IVFgNXQsdj9k5zQF80nvCieV+STbA IjbLeHwE83RUskC9ssE+JwIm2J4f9HP01GygCD+Ozm/nPnKLIeLLa7OekiS04ai7yeOH qm2g== X-Gm-Message-State: ALyK8tJuZEAoNm5WBnQBi9FXWW5PQQnnjgIR7A17BOGTfJJ0IgsE+SqaoTodkDMI/SqMvw50 X-Received: by 10.194.102.202 with SMTP id fq10mr20593039wjb.156.1467811995869; Wed, 06 Jul 2016 06:33:15 -0700 (PDT) Received: from [192.168.0.78] (host86-169-85-169.range86-169.btcentralplus.com. [86.169.85.169]) by smtp.googlemail.com with ESMTPSA id a4sm3296918wjq.40.2016.07.06.06.33.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Jul 2016 06:33:14 -0700 (PDT) To: "Barros Pena, Belen" , "toaster@yoctoproject.org" References: <1467665785-13108-1-git-send-email-michael.g.wood@intel.com> From: Michael Wood Message-ID: <577D0898.9010807@intel.com> Date: Wed, 6 Jul 2016 14:33:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: Subject: Re: [PATCH 0/4] Add delete layer and fix layer rev saving X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Jul 2016 13:33:21 -0000 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit On 06/07/16 14:28, Barros Pena, Belen wrote: > > On 06/07/2016 14:22, "toaster-bounces@yoctoproject.org on behalf of Barros > Pena, Belen" belen.barros.pena@intel.com> wrote: > >> >> On 04/07/2016 21:56, "toaster-bounces@yoctoproject.org on behalf of >> Michael Wood" > michael.g.wood@intel.com> wrote: >> >>> Michael Wood (4): >>> toaster: layerdetails api Fix saving of git revision of a layer >>> toaster: api Add util function for returning the error response >>> toaster: add Layer delete front end feature to layerdetails >>> toaster: tests Add selenium test for layerdetails page >> The fix to the revision changes for imported layers (8952) works like a >> charm: I can edit all the layer details now. I can also delete an imported >> layer \0/, but when I get redirected to the project configuration page >> after clicking the 'delete' button no notification appears, so I am left >> wondering if the layer was deleted or not. > Ignore me: browser cache playing tricks. But the question mark really is > missing ;) OK, I fixed the missing question mark in the branch, so if who ever is reviewing pulls from the branch then it should be there. > >> I also spotted that the question in the delete confirmation dialog is >> missing the question mark. >> >> Thanks!! >> >> Belén >> >> PS: I hate delete confirmation dialogs ... For the record ;) >> >>> .../tests/browser/test_layerdetails_page.py | 190 >>> +++++++++++++++++++++ >>> bitbake/lib/toaster/toastergui/api.py | 121 +++++++++++-- >>> .../toaster/toastergui/static/js/layerdetails.js | 20 +++ >>> .../toaster/toastergui/static/js/projectpage.js | 18 ++ >>> .../toaster/toastergui/templates/layerdetails.html | 18 +- >>> bitbake/lib/toaster/toastergui/urls.py | 5 +- >>> bitbake/lib/toaster/toastergui/views.py | 43 ----- >>> 7 files changed, 360 insertions(+), 55 deletions(-) >>> create mode 100644 >>> bitbake/lib/toaster/tests/browser/test_layerdetails_page.py >>> >>> -- >>> 2.7.4 >>> >>> -- >>> _______________________________________________ >>> toaster mailing list >>> toaster@yoctoproject.org >>> https://lists.yoctoproject.org/listinfo/toaster >> -- >> _______________________________________________ >> toaster mailing list >> toaster@yoctoproject.org >> https://lists.yoctoproject.org/listinfo/toaster