From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 073F4E00D42; Wed, 6 Jul 2016 07:40:11 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [209.85.192.177 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily * valid * -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Received: from mail-pf0-f177.google.com (mail-pf0-f177.google.com [209.85.192.177]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id C8DDDE00C60 for ; Wed, 6 Jul 2016 07:40:04 -0700 (PDT) Received: by mail-pf0-f177.google.com with SMTP id h14so80291800pfe.1 for ; Wed, 06 Jul 2016 07:40:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=HEAjh1QOEH4htSS2qoh3GyKj8FwjF3vRQhCNTXBG6xs=; b=ODtTUsgnBmsWDuhGh11/EIjqONuJwT5UpYmS0WbMvvjhdIEqLAiUvKQ8y9arZFfs04 D0Jnc9O9udhPDFmjlfxD1E7UHPM3nD/YRZedEG+Ob2DdHpwMO8dLB0hIXQ0+6JY2pWzR rLH1cACK7sYt1GCvIl3LVf0kRZIrketzkFeHpo+WZ+DmK+Woq6ptv2isU6i6iE2JG61q aF6L6K9x6czDws+x1L0/lrXjaQsQa3w2hTAo5mfgOeS6QIYd0znlIvDrseUKfNcIpSP7 GcEGY9MBY0ZiSruwCylcowCAMMyXvYyzRB6vCJtThji6MJr4DaNALnfaQJq4MP5Fg5Wu vGIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=HEAjh1QOEH4htSS2qoh3GyKj8FwjF3vRQhCNTXBG6xs=; b=XSPW7QxyJaSWzQ9BTOu8Qr4Oel7A8VN8LUKhTM7PRdbLWx2nO7tv8GuQUpWIDY/zMJ o+eBnFQHGCRcPILKKvtPJvS4N7ZIltL+wh1zU3X0faT+wZVA/O0MWdr/tNHlcSf5yfnx 6HgVIv3/ZPFINbK1CzR7NgekBJij8+3QtEhKGN5/j0BshxTCgFZcMqL7XdUkUoY6N9Yp 4nK5oKbKO9FwTV+PBmY35brywbsNtFeDwNuPxusl+KQ1aDkNNtgME42IyYazTabks2vh NlRi7VATMP6aN2xc273sU2R9mcFhjcrTK8chEIqX28GSmprh4nly6AmGs6EaqplfkhKD XlmA== X-Gm-Message-State: ALyK8tJirzhyUEm5bH9We8LlSGwXOVJgIxSYRD0fdn7BNaJ/liYahXFqhtcavWnd5Uq8WM79 X-Received: by 10.98.87.138 with SMTP id i10mr43554198pfj.1.1467816004426; Wed, 06 Jul 2016 07:40:04 -0700 (PDT) Received: from [192.168.0.78] (host86-169-85-169.range86-169.btcentralplus.com. [86.169.85.169]) by smtp.googlemail.com with ESMTPSA id y70sm4384610pff.25.2016.07.06.07.40.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Jul 2016 07:40:03 -0700 (PDT) To: "Smith, Elliot" References: <1467665785-13108-1-git-send-email-michael.g.wood@intel.com> <577D0898.9010807@intel.com> From: Michael Wood Message-ID: <577D1841.8000505@intel.com> Date: Wed, 6 Jul 2016 15:40:01 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: Cc: "toaster@yoctoproject.org" Subject: Re: [PATCH 0/4] Add delete layer and fix layer rev saving X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Jul 2016 14:40:11 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit On 06/07/16 15:02, Smith, Elliot wrote: > On 6 July 2016 at 14:33, Michael Wood > wrote: > > On 06/07/16 14:28, Barros Pena, Belen wrote: > > > On 06/07/2016 14:22, "toaster-bounces@yoctoproject.org > on behalf of Barros > Pena, Belen" on behalf of > belen.barros.pena@intel.com > > wrote: > > > On 04/07/2016 21:56, "toaster-bounces@yoctoproject.org > on behalf of > Michael Wood" on behalf of > michael.g.wood@intel.com > > wrote: > > Michael Wood (4): > toaster: layerdetails api Fix saving of git revision > of a layer > toaster: api Add util function for returning the > error response > toaster: add Layer delete front end feature to > layerdetails > toaster: tests Add selenium test for layerdetails page > > > > A couple of comments so far: > > 1. I think I'm right in saying that "deleting" a layer permanently > removes it from the database. I think the confirmation dialog should > make it clear that this is what you're doing ("This layer won't be > available to other projects" or similar), as it's not obvious that > remove and delete are different operations. (I didn't get the > distinction to start with.) The imported layers are project specific so it is deleted from the project, and also deleted from being added to your project if applicable. I'll leave this in Belen's corner though. > > 2. I see the "delete" link for all layers in the layer detail page, > not just for layers which I've imported. These layers can't be > deleted, so the dialog box doesn't change when you click "OK", as an > error is returned by the API. > Ah thanks good catch, will roll a v2. > 3. The inline editing of layer dependencies doesn't quite feel right > to me: it's not 100% clear you're going to be adding layer > dependencies by using that box, you could just be adding a new layer. > I'd change the placeholder text to something like "Type the name of a > layer dependency to add" (ideally, something less clunky than that), > or perhaps change the button text to "Add layer dependency". > As this is the existing behaviour (for many releases) you would have to open a bug about this as it's out of the scope of this patch set. Thanks Michael > Elliot > > The fix to the revision changes for imported layers (8952) > works like a > charm: I can edit all the layer details now. I can also > delete an imported > layer \0/, but when I get redirected to the project > configuration page > after clicking the 'delete' button no notification > appears, so I am left > wondering if the layer was deleted or not. > > Ignore me: browser cache playing tricks. But the question mark > really is > missing ;) > > > OK, I fixed the missing question mark in the branch, so if who > ever is reviewing pulls from the branch then it should be there. > > > > I also spotted that the question in the delete > confirmation dialog is > missing the question mark. > > Thanks!! > > Belén > > PS: I hate delete confirmation dialogs ... For the record ;) > > .../tests/browser/test_layerdetails_page.py | 190 > +++++++++++++++++++++ > bitbake/lib/toaster/toastergui/api.py | 121 > +++++++++++-- > .../toaster/toastergui/static/js/layerdetails.js | > 20 +++ > .../toaster/toastergui/static/js/projectpage.js | 18 ++ > .../toaster/toastergui/templates/layerdetails.html | > 18 +- > bitbake/lib/toaster/toastergui/urls.py | 5 +- > bitbake/lib/toaster/toastergui/views.py | 43 ----- > 7 files changed, 360 insertions(+), 55 deletions(-) > create mode 100644 > bitbake/lib/toaster/tests/browser/test_layerdetails_page.py > > -- > 2.7.4 > > -- > _______________________________________________ > toaster mailing list > toaster@yoctoproject.org > https://lists.yoctoproject.org/listinfo/toaster > > -- > _______________________________________________ > toaster mailing list > toaster@yoctoproject.org > https://lists.yoctoproject.org/listinfo/toaster > > > -- > _______________________________________________ > toaster mailing list > toaster@yoctoproject.org > https://lists.yoctoproject.org/listinfo/toaster > > > > > -- > Elliot Smith > Software Engineer > Intel Open Source Technology Centre > > --------------------------------------------------------------------- > Intel Corporation (UK) Limited > Registered No. 1134945 (England) > Registered Office: Pipers Way, Swindon SN3 1RJ > VAT No: 860 2173 47 > > This e-mail and any attachments may contain confidential material for > the sole use of the intended recipient(s). Any review or distribution > by others is strictly prohibited. If you are not the intended > recipient, please contact the sender and delete all copies. >