All of lore.kernel.org
 help / color / mirror / Atom feed
From: Corey Minyard <minyard@acm.org>
To: Borislav Petkov <bp@alien8.de>,
	Luck@minyard.net, Tony <tony.luck@intel.com>,
	linux-rt-users@vger.kernel.org,
	Steven Rostedt <rostedt@goodmis.org>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Corey Minyard <cminyard@mvista.com>
Subject: Re: [PATCH v2] x86: Fix an RT MCE crash
Date: Wed, 6 Jul 2016 15:30:34 -0500	[thread overview]
Message-ID: <577D6A6A.6060709@acm.org> (raw)
In-Reply-To: <1467831301-17233-1-git-send-email-minyard@acm.org>

I forgot to mention that this applies to v3.2-rt, v3.4-rt,
v3.10-rt, v3.12-rt, and v3.14-rt.  I didn't see a v3.16-rt.

-corey

On 07/06/2016 01:55 PM, minyard@acm.org wrote:
> From: Corey Minyard <cminyard@mvista.com>
>
> On some x86 systems an MCE interrupt would come in before the kernel
> was ready for it.  Looking at the latest RT code, it has similar
> (but not quite the same) code, except it adds a bool that tells if
> MCE handling is initialized.  That was required because they had
> switched to use swork instead of a kernel thread.  Here, just
> checking to see if the thread is NULL is good enough to see if
> MCE handling is initialized.
>
> Signed-off-by: Corey Minyard <cminyard@mvista.com>
> ---
>   arch/x86/kernel/cpu/mcheck/mce.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c
> index aaf4b9b..cc70d98 100644
> --- a/arch/x86/kernel/cpu/mcheck/mce.c
> +++ b/arch/x86/kernel/cpu/mcheck/mce.c
> @@ -1391,7 +1391,8 @@ static int mce_notify_work_init(void)
>   
>   static void mce_notify_work(void)
>   {
> -	wake_up_process(mce_notify_helper);
> +	if (mce_notify_helper)
> +		wake_up_process(mce_notify_helper);
>   }
>   #else
>   static void mce_notify_work(void)


  reply	other threads:[~2016-07-06 20:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-06 18:55 [PATCH v2] x86: Fix an RT MCE crash minyard
2016-07-06 20:30 ` Corey Minyard [this message]
2016-07-11 17:34 ` Steven Rostedt
2016-07-11 18:12   ` Corey Minyard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=577D6A6A.6060709@acm.org \
    --to=minyard@acm.org \
    --cc=Luck@minyard.net \
    --cc=bigeasy@linutronix.de \
    --cc=bp@alien8.de \
    --cc=cminyard@mvista.com \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.