From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932846AbcGGAZU (ORCPT ); Wed, 6 Jul 2016 20:25:20 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:34518 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755811AbcGGAZS convert rfc822-to-8bit (ORCPT ); Wed, 6 Jul 2016 20:25:18 -0400 Subject: Re: [PATCH 1/1] usb: quirks: Add no-lpm quirk for Elan Microelectronics Touchpad To: Greg KH References: <20160706231058.GB22668@kroah.com> Cc: hdegoede@redhat.com, adrienverge@gmail.com, yaowen@google.com, vpalatin@chromium.org, stern@rowland.harvard.edu, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, stable@vger.kernel.org From: Joseph Salisbury Message-ID: <577DA132.9040204@canonical.com> Date: Wed, 6 Jul 2016 20:24:18 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <20160706231058.GB22668@kroah.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/06/2016 07:10 PM, Greg KH wrote: > On Wed, Jul 06, 2016 at 05:53:47PM -0400, Joseph Salisbury wrote: >> BugLink: http://bugs.launchpad.net/bugs/1498667 >> >> As reported in BugLink, this device has an issue with Linux Power Management so >> adding a quirk. This quirk was reccomended by Alan Stern: >> >> http://lkml.iu.edu/hypermail/linux/kernel/1606.2/05590.html >> >> Signed-off-by: Joseph Salisbury >> Cc: stable >> >> --- >> drivers/usb/core/quirks.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c >> index 944a6dc..a33d003 100644 >> --- a/drivers/usb/core/quirks.c >> +++ b/drivers/usb/core/quirks.c >> @@ -198,6 +198,9 @@ static const struct usb_device_id usb_quirk_list[] = { >> /* Protocol and OTG Electrical Test Device */ >> { USB_DEVICE(0x1a0a, 0x0200), .driver_info = >> USB_QUIRK_LINEAR_UFRAME_INTR_BINTERVAL }, >> + >> + /* ELAN Microelectronics Touchscreen */ >> + { USB_DEVICE(0x04f3, 0x0381), .driver_info = USB_QUIRK_NO_LPM }, > Please put this next to the other Elan touchscreen quirk entries, don't > put them in random order, it's a pain to maintain that way... > > thanks, > > greg k-h Sorry, I grouped it with the other USB_QUIRK_NO_LPM entries. I'll send a V2 patch and make a note to group by manufacturer from now on. Thanks, Joe