From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755888AbcGGBFp (ORCPT ); Wed, 6 Jul 2016 21:05:45 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:34994 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751186AbcGGBFo (ORCPT ); Wed, 6 Jul 2016 21:05:44 -0400 Subject: Re: [PATCH 1/1][V2] usb: quirks: Add no-lpm quirk for Elan To: Greg KH References: <55d9aba2e03fe625810ab01eb9d883ed81a3f13c.1467851482.git.joseph.salisbury@canonical.com> <20160707010248.GA20126@kroah.com> Cc: hdegoede@redhat.com, adrienverge@gmail.com, yaowen@google.com, vpalatin@chromium.org, stern@rowland.harvard.edu, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, stable@vger.kernel.org From: Joseph Salisbury Message-ID: <577DAAE4.4060600@canonical.com> Date: Wed, 6 Jul 2016 21:05:40 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <20160707010248.GA20126@kroah.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/06/2016 09:02 PM, Greg KH wrote: > On Wed, Jul 06, 2016 at 08:58:14PM -0400, Joseph Salisbury wrote: >> BugLink: http://bugs.launchpad.net/bugs/1498667 >> >> As reported in BugLink, this device has an issue with Linux Power >> Management so adding a quirk. This quirk was reccomended by Alan Stern: >> >> http://lkml.iu.edu/hypermail/linux/kernel/1606.2/05590.html >> >> Signed-off-by: Joseph Salisbury >> Cc: stable >> --- >> drivers/usb/core/quirks.c | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c >> index 944a6dc..f028cc5 100644 >> --- a/drivers/usb/core/quirks.c >> +++ b/drivers/usb/core/quirks.c >> @@ -127,10 +127,13 @@ static const struct usb_device_id usb_quirk_list[] = { >> >> { USB_DEVICE(0x04f3, 0x016f), .driver_info = >> USB_QUIRK_DEVICE_QUALIFIER }, >> + >> + { USB_DEVICE(0x04f3, 0x0381), .driver_info = >> + USB_QUIRK_NO_LPM }, >> >> { USB_DEVICE(0x04f3, 0x21b8), .driver_info = >> USB_QUIRK_DEVICE_QUALIFIER }, >> - >> + > This is odd, why remove and add a blank line for no reason? > That is odd and wasn't intentional, I'll send a V3.