From: Minkyu Kang <mk7.kang@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] dm: mmc: dwmmc: use the callback functions as static
Date: Thu, 07 Jul 2016 11:14:29 +0900 [thread overview]
Message-ID: <577DBB05.3020904@samsung.com> (raw)
In-Reply-To: <CAPnjgZ2cy7mJKu-XArhS1xADXe+Q9o3r4Wt0defEU_TY2LqNSQ@mail.gmail.com>
Hi,
On 01/07/16 04:53, Simon Glass wrote:
> Hi Jaehoon,
>
> On 28 June 2016 at 20:47, Jaehoon Chung <jh80.chung@samsung.com> wrote:
>> Hi Simon,
>>
>> On 06/29/2016 12:28 PM, Simon Glass wrote:
>>> Hi Jaehoon,
>>>
>>> On 27 June 2016 at 23:52, Jaehoon Chung <jh80.chung@samsung.com> wrote:
>>>> There are no places to call these functions.
>>>> It should be used the callback function.
>>>> Then it can be used as static functions.
>>>>
>>>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>>>> ---
>>>> drivers/mmc/dw_mmc.c | 4 ++--
>>>> include/dwmmc.h | 3 ---
>>>> 2 files changed, 2 insertions(+), 5 deletions(-)
>>>>
>>>> diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c
>>>> index 3411f95..f83a6bc 100644
>>>> --- a/drivers/mmc/dw_mmc.c
>>>> +++ b/drivers/mmc/dw_mmc.c
>>>> @@ -182,7 +182,7 @@ static int dwmci_set_transfer_mode(struct dwmci_host *host,
>>>> }
>>>>
>>>> #ifdef CONFIG_DM_MMC_OPS
>>>> -int dwmci_send_cmd(struct udevice *dev, struct mmc_cmd *cmd,
>>>
>>> >From what I can see this is already static. Which commit are you basing off?
>>
>> I'm checking with your 'blk-working' branch. I'm not sure what's correct.
>>
>> commit dee390a1250c17a4e71e359d6e461319a7cdea54
>> Author: Simon Glass <sjg@chromium.org>
>> Date: Sat Jun 11 19:01:49 2016 -0600
>>
>> dm: blk: Enable CONFIG_BLK if DM_MMC is enabled
>>
>> If i need to work with other branch, let me know,plz.
>> I have tested the DM with dw_mmc_exynos.c. (It's working fine.)
>>
>> I will send the patch-set for exynos dwmmc and sdhci controller.
>> So i need to know which repository and branch are correct. :)
>>
>> Then it's helpful to me for working dm. I think that i can help you for checking on mmc side with DM.
>
> OK I see, thanks.
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
>
This patch has been delegated to me, but cannot apply to u-boot-samsung.
should go to dm tree?
Thanks,
Minkyu Kang.
next prev parent reply other threads:[~2016-07-07 2:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-28 6:52 [U-Boot] [PATCH 0/2] dm: mmc: dwmmc: fix the minor things Jaehoon Chung
2016-06-28 6:52 ` [U-Boot] [PATCH 1/2] dm: mmc: dwmmc: fix the wrong explanation for clock values Jaehoon Chung
2016-06-29 3:28 ` Simon Glass
2016-06-28 6:52 ` [U-Boot] [PATCH 2/2] dm: mmc: dwmmc: use the callback functions as static Jaehoon Chung
2016-06-29 3:28 ` Simon Glass
2016-06-29 3:47 ` Jaehoon Chung
2016-06-30 19:53 ` Simon Glass
2016-07-07 2:14 ` Minkyu Kang [this message]
2016-07-07 16:11 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=577DBB05.3020904@samsung.com \
--to=mk7.kang@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.