From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45078) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bL41P-00059x-Gl for qemu-devel@nongnu.org; Thu, 07 Jul 2016 03:46:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bL41J-0008BQ-Mj for qemu-devel@nongnu.org; Thu, 07 Jul 2016 03:46:54 -0400 Received: from [59.151.112.132] (port=28924 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bL41I-00088o-ND for qemu-devel@nongnu.org; Thu, 07 Jul 2016 03:46:49 -0400 References: <1466681677-30487-1-git-send-email-zhangchen.fnst@cn.fujitsu.com> From: Zhang Chen Message-ID: <577E090E.4050002@cn.fujitsu.com> Date: Thu, 7 Jul 2016 15:47:26 +0800 MIME-Version: 1.0 In-Reply-To: <1466681677-30487-1-git-send-email-zhangchen.fnst@cn.fujitsu.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH V5 0/4] Introduce COLO-compare List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu devel , Jason Wang Cc: Li Zhijian , Wen Congyang , zhanghailiang , "eddie . dong" , "Dr . David Alan Gilbert" Hi~~ Jason~ Have any comments? By the way this patch set depend on the patch [RFC PATCH V2] qemu-char: Fix context for g_source_attach() but no one review it....any suggestion? Thanks Zhang Chen On 06/23/2016 07:34 PM, Zhang Chen wrote: > COLO-compare is a part of COLO project. It is used > to compare the network package to help COLO decide > whether to do checkpoint. > > the full version in this github: > https://github.com/zhangckid/qemu/tree/colo-v2.7-proxy-mode-compare-with-colo-base-jun20 > > v5: > p3: > - comments from Jason > we poll and handle chardev in comapre thread, > Through this way, there's no need for extra > synchronization with main loop > this depend on another patch: > qemu-char: Fix context for g_source_attach() > - remove QemuEvent > p2: > - remove conn->list_lock > p1: > - move compare_pri/sec_chr_in to p3 > - move compare_chr_send to p2 > > v4: > p4: > - add some comments > - fix some trace-events > - fix tcp compare error > p3: > - add rcu_read_lock(). > - fix trace name > - fix jason's other comments > - rebase some Dave's branch function > p2: > - colo_compare_connection() change g_queue_push_head() to > - g_queue_push_tail() match to sorted order. > - remove pkt->s > - move data structure to colo-base.h > - add colo-base.c reuse codes for filter-rewriter > - add some filter-rewriter needs struct > - depends on previous SocketReadState patch > p1: > - except move qemu_chr_add_handlers() > to colo thread > - remove class_finalize > - remove secondary arp codes > - depends on previous SocketReadState patch > > v3: > - rebase colo-compare to colo-frame v2.7 > - fix most of Dave's comments > (except RCU) > - add TCP,UDP,ICMP and other packet comparison > - add trace-event > - add some comments > - other bug fix > - add RFC index > - add usage in patch 1/4 > > v2: > - add jhash.h > > v1: > - initial patch > > > Zhang Chen (4): > colo-compare: introduce colo compare initialization > colo-compare: track connection and enqueue packet > colo-compare: introduce packet comparison thread > colo-compare: add TCP,UDP,ICMP packet comparison > > include/qemu/jhash.h | 61 +++++ > net/Makefile.objs | 2 + > net/colo-base.c | 195 ++++++++++++++ > net/colo-base.h | 91 +++++++ > net/colo-compare.c | 742 +++++++++++++++++++++++++++++++++++++++++++++++++++ > qemu-options.hx | 34 +++ > trace-events | 11 + > vl.c | 3 +- > 8 files changed, 1138 insertions(+), 1 deletion(-) > create mode 100644 include/qemu/jhash.h > create mode 100644 net/colo-base.c > create mode 100644 net/colo-base.h > create mode 100644 net/colo-compare.c > -- Thanks zhangchen