From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH -next v2] iommu/exynos: Fix return value check in exynos_iommu_of_setup() Date: Thu, 07 Jul 2016 11:43:30 +0200 Message-ID: <577E2442.4000002@samsung.com> References: <1467807354-26503-1-git-send-email-weiyj_lk@163.com> <1467860372-6940-1-git-send-email-weiyj_lk@163.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <1467860372-6940-1-git-send-email-weiyj_lk-9Onoh4P/yGk@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: weiyj_lk-9Onoh4P/yGk@public.gmane.org, Marek Szyprowski , Joerg Roedel , Kukjin Kim Cc: Wei Yongjun , linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: iommu@lists.linux-foundation.org On 07/07/2016 04:59 AM, weiyj_lk-9Onoh4P/yGk@public.gmane.org wrote: > From: Wei Yongjun > > In case of error, the function of_platform_device_create() returns > NULL pointer not ERR_PTR(). The IS_ERR() test in the return value > check should be replaced with NULL test. > > Signed-off-by: Wei Yongjun > --- > v1 -> v2: chenge the error code to -ENODEV > --- > drivers/iommu/exynos-iommu.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Why you didn't include mine and Dennis reviews? Why you ignored my comments - you don't agree with them? Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 From: k.kozlowski@samsung.com (Krzysztof Kozlowski) Date: Thu, 07 Jul 2016 11:43:30 +0200 Subject: [PATCH -next v2] iommu/exynos: Fix return value check in exynos_iommu_of_setup() In-Reply-To: <1467860372-6940-1-git-send-email-weiyj_lk@163.com> References: <1467807354-26503-1-git-send-email-weiyj_lk@163.com> <1467860372-6940-1-git-send-email-weiyj_lk@163.com> Message-ID: <577E2442.4000002@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 07/07/2016 04:59 AM, weiyj_lk at 163.com wrote: > From: Wei Yongjun > > In case of error, the function of_platform_device_create() returns > NULL pointer not ERR_PTR(). The IS_ERR() test in the return value > check should be replaced with NULL test. > > Signed-off-by: Wei Yongjun > --- > v1 -> v2: chenge the error code to -ENODEV > --- > drivers/iommu/exynos-iommu.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Why you didn't include mine and Dennis reviews? Why you ignored my comments - you don't agree with them? Best regards, Krzysztof