From: David Vrabel <david.vrabel@citrix.com>
To: Jan Beulich <JBeulich@suse.com>, <david.vrabel@citrix.com>,
<boris.ostrovsky@oracle.com>, Juergen Gross <JGross@suse.com>
Cc: <xen-devel@lists.xenproject.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [Xen-devel] [PATCH 1/2] xenbus: don't bail early from xenbus_dev_request_and_reply()
Date: Thu, 7 Jul 2016 12:36:48 +0100 [thread overview]
Message-ID: <577E3ED0.906@citrix.com> (raw)
In-Reply-To: <577E219402000078000FBDB6@prv-mh.provo.novell.com>
On 07/07/16 08:32, Jan Beulich wrote:
> We must not skip the transaction_end() call for a failed
> XS_TRANSACTION_START. The removed code fragment got introduced by
> commit 027bd7e899 ("xen/xenbus: Avoid synchronous wait on XenBus
> stalling shutdown/restart") without its description really indicating
> why it was added (and hence I can't identify whether a more complex
> change might be needed here).
If sending the XS_TRANSACTION_END message failed, then the transaction
is still open and transaction_end() should not be called.
However, if sending an XS_TRANSACTION_START failed, then
transaction_end() should be called.
So, yes a more complex fix is needed here.
David
next prev parent reply other threads:[~2016-07-07 11:36 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-07 7:25 [PATCH 0/2] xenbus: xenbus_dev_request_and_reply() adjustments Jan Beulich
2016-07-07 7:25 ` Jan Beulich
2016-07-07 7:32 ` [PATCH 1/2] xenbus: don't bail early from xenbus_dev_request_and_reply() Jan Beulich
2016-07-07 11:36 ` David Vrabel
2016-07-07 11:36 ` David Vrabel [this message]
2016-07-07 12:09 ` [Xen-devel] " Jan Beulich
2016-07-07 12:17 ` David Vrabel
2016-07-07 12:23 ` Jan Beulich
2016-07-07 12:23 ` [Xen-devel] " Jan Beulich
2016-07-07 13:13 ` David Vrabel
2016-07-07 13:13 ` [Xen-devel] " David Vrabel
2016-07-07 13:22 ` David Vrabel
2016-07-07 13:35 ` Jan Beulich
2016-07-07 13:35 ` Jan Beulich
2016-07-08 10:18 ` David Vrabel
2016-07-08 10:18 ` [Xen-devel] " David Vrabel
2016-07-07 13:22 ` David Vrabel
2016-07-07 12:17 ` David Vrabel
2016-07-07 12:09 ` Jan Beulich
2016-07-07 7:32 ` Jan Beulich
2016-07-07 7:32 ` [PATCH 2/2] xenbus: simplify xenbus_dev_request_and_reply() Jan Beulich
2016-07-07 7:32 ` Jan Beulich
2016-07-08 10:56 ` [PATCH 0/2] xenbus: xenbus_dev_request_and_reply() adjustments David Vrabel
2016-07-08 10:56 ` [Xen-devel] " David Vrabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=577E3ED0.906@citrix.com \
--to=david.vrabel@citrix.com \
--cc=JBeulich@suse.com \
--cc=JGross@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.