Re: [Qemu-devel] [PATCH v3 2/2] qapi: change QmpInputVisitor to QSLIST

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1056 bytes --]

On 07/07/2016 09:53 AM, Paolo Bonzini wrote:
> This saves a lot of memory compared to a statically-sized array,
> or at least 24kb could be considered a lot on an Atari ST.
> It also makes the code more similar to QmpOutputVisitor.
> 
> This removes the limit on the depth of a QObject that can be processed
> into a QAPI tree.  This is not a problem because QObjects can be
> considered truested; the text received on the QMP wire is untrusted

s/truested/trusted/

> input, but the JSON parser already takes pains to limit the QObject tree
> it creates.  We don't need the QMP input visitor to limit it again.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  qapi/qmp-input-visitor.c | 59 ++++++++++++++++++++++++------------------------
>  1 file changed, 29 insertions(+), 30 deletions(-)
> 

With commit message tweak here and comment tweak in 1/2,
Series:
Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]