From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yakir Yang Subject: Re: [PATCH v3 4/6] drm/panel: simple: Add support for Samsung LSN122DL01-C01 2560x1600 panel Date: Fri, 8 Jul 2016 09:51:43 +0800 Message-ID: <577F072F.6010608@rock-chips.com> References: <1465700010-13483-1-git-send-email-ykk@rock-chips.com> <1465700173-13671-1-git-send-email-ykk@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Doug Anderson Cc: Mark Rutland , "devicetree@vger.kernel.org" , Pawel Moll , Ian Campbell , Emil Velikov , "linux-kernel@vger.kernel.org" , Rob Herring , "dri-devel@lists.freedesktop.org" , Kumar Gala List-Id: devicetree@vger.kernel.org RG91ZywKCk9uIDA2LzE0LzIwMTYgMDE6MDAgQU0sIERvdWcgQW5kZXJzb24gd3JvdGU6Cj4gWWFr aXIsCj4KPiBPbiBTYXQsIEp1biAxMSwgMjAxNiBhdCA3OjU2IFBNLCBZYWtpciBZYW5nIDx5a2tA cm9jay1jaGlwcy5jb20+IHdyb3RlOgo+PiBUaGUgU2Ftc3VuZyBMU04xMjJETDAxLUMwMSBpcyBh biAxMi4yIiAyNTYweDE2MDAgKFdRWEdBKSBURlQtTENEIHBhbmVsCj4+IGNvbm5lY3RlZCB1c2lu ZyBlRFAgaW50ZXJmYWNlcy4KPj4KPj4gU2lnbmVkLW9mZi1ieTogWWFraXIgWWFuZyA8eWtrQHJv Y2stY2hpcHMuY29tPgo+PiAtLS0KPj4gQ2hhbmdlcyBpbiB2MzoKPj4gLSBDb3JyZWN0IHRoZSBz aXplIG9mIHBhbmVsX2Rlc2MgdG8gYWN0aXZlIGFyZWEgMjYybW14MTY0bW0gKEVtaWwsIFN0w6lw aGFuZSkKPj4KPj4gQ2hhbmdlcyBpbiB2MjogTm9uZQo+Pgo+PiAgIGRyaXZlcnMvZ3B1L2RybS9w YW5lbC9wYW5lbC1zaW1wbGUuYyB8IDI1ICsrKysrKysrKysrKysrKysrKysrKysrKysKPj4gICAx IGZpbGUgY2hhbmdlZCwgMjUgaW5zZXJ0aW9ucygrKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL3BhbmVsL3BhbmVsLXNpbXBsZS5jIGIvZHJpdmVycy9ncHUvZHJtL3BhbmVsL3Bh bmVsLXNpbXBsZS5jCj4+IGluZGV4IDJkNDBhMjEuLjE3Y2M5NzMgMTAwNjQ0Cj4+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9wYW5lbC9wYW5lbC1zaW1wbGUuYwo+PiArKysgYi9kcml2ZXJzL2dwdS9k cm0vcGFuZWwvcGFuZWwtc2ltcGxlLmMKPj4gQEAgLTEyNDYsNiArMTI0NiwyOCBAQCBzdGF0aWMg Y29uc3Qgc3RydWN0IHBhbmVsX2Rlc2MgcWQ0MzAwM2MwXzQwID0gewo+PiAgICAgICAgICAuYnVz X2Zvcm1hdCA9IE1FRElBX0JVU19GTVRfUkdCODg4XzFYMjQsCj4+ICAgfTsKPj4KPj4gK3N0YXRp YyBjb25zdCBzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSBzYW1zdW5nX2xzbjEyMmRsMDFfYzAxX21v ZGUgPSB7Cj4+ICsgICAgICAgLmNsb2NrID0gMjcxNTYwLAo+PiArICAgICAgIC5oZGlzcGxheSA9 IDI1NjAsCj4+ICsgICAgICAgLmhzeW5jX3N0YXJ0ID0gMjU2MCArIDQ4LAo+PiArICAgICAgIC5o c3luY19lbmQgPSAyNTYwICsgNDggKyAzMiwKPj4gKyAgICAgICAuaHRvdGFsID0gMjU2MCArIDQ4 ICsgMzIgKyA4MCwKPj4gKyAgICAgICAudmRpc3BsYXkgPSAxNjAwLAo+PiArICAgICAgIC52c3lu Y19zdGFydCA9IDE2MDAgKyAyLAo+PiArICAgICAgIC52c3luY19lbmQgPSAxNjAwICsgMiArIDUs Cj4+ICsgICAgICAgLnZ0b3RhbCA9IDE2MDAgKyAyICsgNSArIDU3LAo+PiArICAgICAgIC52cmVm cmVzaCA9IDYwLAo+PiArfTsKPj4gKwo+PiArc3RhdGljIGNvbnN0IHN0cnVjdCBwYW5lbF9kZXNj IHNhbXN1bmdfbHNuMTIyZGwwMV9jMDEgPSB7Cj4+ICsgICAgICAgLm1vZGVzID0gJnNhbXN1bmdf bHNuMTIyZGwwMV9jMDFfbW9kZSwKPj4gKyAgICAgICAubnVtX21vZGVzID0gMSwKPj4gKyAgICAg ICAuc2l6ZSA9IHsKPj4gKyAgICAgICAgICAgICAgIC53aWR0aCA9IDI2MiwKPj4gKyAgICAgICAg ICAgICAgIC5oZWlnaHQgPSAxNjQsCj4gRWFybGllciB5b3Ugc2FpZCB0aGF0IHRoZSBhY3RpdmUg YXJlYSBvZiB0aGlzIHBhbmVsIHdhczoKPgo+PiBEaXNwbGF5IGFyZWEgICAgIDI2Mi42NTYoSCkg WCAxNjQuMTYoVikgICAgICAgICAoMTIuMuKAnWRpYWdvbmFsKQo+IEluIG90aGVyIHBhbmVscyBJ IGxvb2tlZCBhdCB0aGUgRURJRCB0ZW5kZWQgdG8gcm91bmQgbnVtYmVycywgbm90Cj4gdHJ1bmNh dGUgdGhlbS4gIEZvciBpbnN0YW5jZSB0aGUgU3RhcnJ5IHBhbmVsIHRoYXQgSSBzZW50IHRoZSBw YXRjaAo+IGZvciBzYXlzIGluIHRoZSBtYW51YWwgIjI2Mi43NzEyIChIKSB4IDE2NC4yMzIgKFYp IiBidXQgdGhlbiB0aGUgRURJRAo+IHNheXMgIjI2MyB4IDE2NCIuCgpBaCwgZ290IGl0LCBkb25l LgoKVGhhbmtzLAotIFlha2lyCgo+IFRoYXQgd291bGQgbWVhbiB5b3VyIHdpZHRoIHNob3VsZCBi ZSAyNjMgbW0sIG5vdCAyNjIgbW0uCj4KPiAtRG91Zwo+Cj4KPgoKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJp LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753857AbcGHBvy (ORCPT ); Thu, 7 Jul 2016 21:51:54 -0400 Received: from lucky1.263xmail.com ([211.157.147.133]:56919 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753470AbcGHBvw (ORCPT ); Thu, 7 Jul 2016 21:51:52 -0400 X-263anti-spam: KSV:0;BIG:0;ABS:1;DNS:0;ATT:0;SPF:S; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ADDR-CHECKED: 0 X-RL-SENDER: ykk@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: ykk@rock-chips.com X-UNIQUE-TAG: <3a556501d6aa021e8006a82171c68cc6> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v3 4/6] drm/panel: simple: Add support for Samsung LSN122DL01-C01 2560x1600 panel To: Doug Anderson References: <1465700010-13483-1-git-send-email-ykk@rock-chips.com> <1465700173-13671-1-git-send-email-ykk@rock-chips.com> Cc: David Airlie , Thierry Reding , Rob Herring , Pawel Moll , Mark Rutland , Kumar Gala , Ian Campbell , Emil Velikov , "dri-devel@lists.freedesktop.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" From: Yakir Yang Message-ID: <577F072F.6010608@rock-chips.com> Date: Fri, 8 Jul 2016 09:51:43 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Doug, On 06/14/2016 01:00 AM, Doug Anderson wrote: > Yakir, > > On Sat, Jun 11, 2016 at 7:56 PM, Yakir Yang wrote: >> The Samsung LSN122DL01-C01 is an 12.2" 2560x1600 (WQXGA) TFT-LCD panel >> connected using eDP interfaces. >> >> Signed-off-by: Yakir Yang >> --- >> Changes in v3: >> - Correct the size of panel_desc to active area 262mmx164mm (Emil, Stéphane) >> >> Changes in v2: None >> >> drivers/gpu/drm/panel/panel-simple.c | 25 +++++++++++++++++++++++++ >> 1 file changed, 25 insertions(+) >> >> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c >> index 2d40a21..17cc973 100644 >> --- a/drivers/gpu/drm/panel/panel-simple.c >> +++ b/drivers/gpu/drm/panel/panel-simple.c >> @@ -1246,6 +1246,28 @@ static const struct panel_desc qd43003c0_40 = { >> .bus_format = MEDIA_BUS_FMT_RGB888_1X24, >> }; >> >> +static const struct drm_display_mode samsung_lsn122dl01_c01_mode = { >> + .clock = 271560, >> + .hdisplay = 2560, >> + .hsync_start = 2560 + 48, >> + .hsync_end = 2560 + 48 + 32, >> + .htotal = 2560 + 48 + 32 + 80, >> + .vdisplay = 1600, >> + .vsync_start = 1600 + 2, >> + .vsync_end = 1600 + 2 + 5, >> + .vtotal = 1600 + 2 + 5 + 57, >> + .vrefresh = 60, >> +}; >> + >> +static const struct panel_desc samsung_lsn122dl01_c01 = { >> + .modes = &samsung_lsn122dl01_c01_mode, >> + .num_modes = 1, >> + .size = { >> + .width = 262, >> + .height = 164, > Earlier you said that the active area of this panel was: > >> Display area 262.656(H) X 164.16(V) (12.2”diagonal) > In other panels I looked at the EDID tended to round numbers, not > truncate them. For instance the Starry panel that I sent the patch > for says in the manual "262.7712 (H) x 164.232 (V)" but then the EDID > says "263 x 164". Ah, got it, done. Thanks, - Yakir > That would mean your width should be 263 mm, not 262 mm. > > -Doug > > >