From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yakir Yang Subject: Re: [PATCH v3 1/4] drm/rockchip: vop: export line flag function Date: Fri, 8 Jul 2016 10:30:10 +0800 Message-ID: <577F1032.5040908@rock-chips.com> References: <1467364685-21390-1-git-send-email-ykk@rock-chips.com> <1467364745-21621-1-git-send-email-ykk@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sean Paul Cc: Krzysztof Kozlowski , linux-samsung-soc , linux-rockchip@lists.infradead.org, Mark Yao , Daniel Vetter , Emil Velikov , Doug Anderson , dri-devel , Tomasz Figa , Javier Martinez Canillas , Jingoo Han , =?UTF-8?Q?St=c3=a9phane_Marchesin?= , Thierry Reding , Linux Kernel Mailing List List-Id: linux-rockchip.vger.kernel.org U2VhbiwKCk9uIDA3LzAxLzIwMTYgMTE6MzIgUE0sIFNlYW4gUGF1bCB3cm90ZToKPiBPbiBGcmks IEp1bCAxLCAyMDE2IGF0IDExOjMwIEFNLCBTZWFuIFBhdWwgPHNlYW5wYXVsQGNocm9taXVtLm9y Zz4gd3JvdGU6Cj4+IE9uIEZyaSwgSnVsIDEsIDIwMTYgYXQgNToxOSBBTSwgWWFraXIgWWFuZyA8 eWtrQHJvY2stY2hpcHMuY29tPiB3cm90ZToKPj4+IFZPUCBoYXZlIGludGVncmF0ZWQgYSBoYXJk d2FyZSBjb3VudGVyIHdoaWNoIGluZGljYXRlIHRoZSBleGFjdCBkaXNwbGF5Cj4+PiBsaW5lIHRo YXQgdm9wIGlzIHNjYW5uaW5nLiBBbmQgaWYgd2UncmUgaW50ZXJlc3RlZCBpbiBhIHNwZWNpZmlj IGxpbmUsCj4+PiB3ZSBjYW4gc2V0IHRoZSBsaW5lIG51bWJlciB0byB2b3AgbGluZV9mbGFnIHJl Z2lzdGVyLCBhbmQgdGhlbiB2b3Agd291bGQKPj4+IGdlbmVyYXRlIGEgbGluZV9mbGFnIGludGVy cnVwdCBmb3IgaXQuCj4+Pgo+Pj4gRm9yIGV4YW1wbGUgZURQIFBTUiBmdW5jdGlvbiBpcyBpbnRl cmVzdGVkIGluIHRoZSB2ZXJ0aWNhbCBibGFua2luZwo+Pj4gcGVyaW9kLCB0aGVuIGRyaXZlciBj b3VsZCBzZXQgdGhlIGxpbmUgbnVtYmVyIHRvIHplcm8uCj4+Pgo+Pj4gVGhpcyBwYXRjaCBoYXZl IGV4cG9ydGVkIGEgc3ltYm9sIHRoYXQgYWxsb3cgb3RoZXIgZHJpdmVyIHRvIGxpc3RlbiB0aGUK Pj4+IGxpbmUgZmxhZyBldmVudCB3aXRoIGdpdmVuIHRpbWVvdXQgbGltaXQ6Cj4+PiAtICByb2Nr Y2hpcF9kcm1fd2FpdF9saW5lX2ZsYWcoKQo+Pj4KPj4+IFNpZ25lZC1vZmYtYnk6IFlha2lyIFlh bmcgPHlra0Byb2NrLWNoaXBzLmNvbT4KPj4+IC0tLQo+Pj4gQ2hhbmdlcyBpbiB2MzoKPj4+IC0g RXhwb3J0IHRoZSAncm9ja2NoaXBfZHJtX3dhaXRfbGluZV9mbGFnJyBzeW1ib2wsIGFuZCBkb2N1 bWVudCBpdC4KPj4+IC0gQWRkICdsaW5lX2ZsYWdfbnVtXzAnIGZvciBSSzMyODgvUkszMDM2Cj4+ PiAtIFJlbW92ZSB0aGUgbm90aWZ5IGZvciB3YWl0aW5nIGxpbmVfZmxhZyBldmVudCAoRGFuaWVs KQo+Pj4KPj4+IENoYW5nZXMgaW4gdjI6Cj4+PiAtIEludHJvZHVjZSBpbiB2Miwgc3BsaXQgVk9Q IGxpbmUgZmxhZyBjaGFuZ2VzIG91dAo+Pj4KPj4+ICAgZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlw L3JvY2tjaGlwX2RybV9kcnYuaCB8ICAgMyArCj4+PiAgIGRyaXZlcnMvZ3B1L2RybS9yb2NrY2hp cC9yb2NrY2hpcF9kcm1fdm9wLmMgfCAxMDMgKysrKysrKysrKysrKysrKysrKysrKysrKysrKwo+ Pj4gICBkcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvcm9ja2NoaXBfZHJtX3ZvcC5oIHwgICAzICsK Pj4+ICAgZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL3JvY2tjaGlwX3ZvcF9yZWcuYyB8ICAgNCAr Kwo+Pj4gICA0IGZpbGVzIGNoYW5nZWQsIDExMyBpbnNlcnRpb25zKCspCj4+Pgo+Pj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9yb2NrY2hpcF9kcm1fZHJ2LmggYi9kcml2 ZXJzL2dwdS9kcm0vcm9ja2NoaXAvcm9ja2NoaXBfZHJtX2Rydi5oCj4+PiBpbmRleCBlYTM5MzI5 Li4yMzliODMwIDEwMDY0NAo+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL3JvY2tj aGlwX2RybV9kcnYuaAo+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL3JvY2tjaGlw X2RybV9kcnYuaAo+Pj4gQEAgLTcwLDQgKzcwLDcgQEAgaW50IHJvY2tjaGlwX2RybV9kbWFfYXR0 YWNoX2RldmljZShzdHJ1Y3QgZHJtX2RldmljZSAqZHJtX2RldiwKPj4+ICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCBkZXZpY2UgKmRldik7Cj4+PiAgIHZvaWQgcm9j a2NoaXBfZHJtX2RtYV9kZXRhY2hfZGV2aWNlKHN0cnVjdCBkcm1fZGV2aWNlICpkcm1fZGV2LAo+ Pj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCBkZXZpY2UgKmRl dik7Cj4+PiAraW50IHJvY2tjaGlwX2RybV93YWl0X2xpbmVfZmxhZyhzdHJ1Y3QgZHJtX2NydGMg KmNydGMsIHVuc2lnbmVkIGludCBsaW5lX251bSwKPj4+ICsgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgdW5zaWduZWQgaW50IG1zdGltZW91dCk7Cj4+PiArCj4+PiAgICNlbmRpZiAvKiBf Uk9DS0NISVBfRFJNX0RSVl9IXyAqLwo+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9y b2NrY2hpcC9yb2NrY2hpcF9kcm1fdm9wLmMgYi9kcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvcm9j a2NoaXBfZHJtX3ZvcC5jCj4+PiBpbmRleCBjOGE2MmE4Li5jZDNjYWM1IDEwMDY0NAo+Pj4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL3JvY2tjaGlwX2RybV92b3AuYwo+Pj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL3JvY2tjaGlwX2RybV92b3AuYwo+Pj4gQEAgLTEyMSw2 ICsxMjEsOCBAQCBzdHJ1Y3Qgdm9wIHsKPj4+ICAgICAgICAgIC8qIHByb3RlY3RlZCBieSBkZXYt PmV2ZW50X2xvY2sgKi8KPj4+ICAgICAgICAgIHN0cnVjdCBkcm1fcGVuZGluZ192YmxhbmtfZXZl bnQgKmV2ZW50Owo+Pj4KPj4+ICsgICAgICAgc3RydWN0IGNvbXBsZXRpb24gbGluZV9mbGFnX2Nv bXBsZXRpb247Cj4+PiArCj4+PiAgICAgICAgICBjb25zdCBzdHJ1Y3Qgdm9wX2RhdGEgKmRhdGE7 Cj4+Pgo+Pj4gICAgICAgICAgdWludDMyX3QgKnJlZ3NiYWs7Cj4+PiBAQCAtNDMxLDYgKzQzMyw1 OSBAQCBzdGF0aWMgdm9pZCB2b3BfZHNwX2hvbGRfdmFsaWRfaXJxX2Rpc2FibGUoc3RydWN0IHZv cCAqdm9wKQo+Pj4gICAgICAgICAgc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgmdm9wLT5pcnFfbG9j aywgZmxhZ3MpOwo+Pj4gICB9Cj4+Pgo+Pj4gKy8qCj4+PiArICogKDEpIGVhY2ggZnJhbWUgc3Rh cnRzIGF0IHRoZSBzdGFydCBvZiB0aGUgVnN5bmMgcHVsc2Ugd2hpY2ggaXMgc2lnbmFsZWQgYnkK Pj4+ICsgKiAgICAgdGhlICJGUkFNRV9TWU5DIiBpbnRlcnJ1cHQuCj4+PiArICogKDIpIHRoZSBh Y3RpdmUgZGF0YSByZWdpb24gb2YgZWFjaCBmcmFtZSBlbmRzIGF0IGRzcF92YWN0X2VuZAo+Pj4g KyAqICgzKSB3ZSBzaG91bGQgcHJvZ3JhbSB0aGlzIHNhbWUgbnVtYmVyIChkc3BfdmFjdF9lbmQp IGludG8gZHNwX2xpbmVfZnJhZ19udW0sCj4+PiArICogICAgICB0byBnZXQgIkxJTkVfRkxBRyIg aW50ZXJydXB0IGF0IHRoZSBlbmQgb2YgdGhlIGFjdGl2ZSBvbiBzY3JlZW4gZGF0YS4KPj4+ICsg Kgo+Pj4gKyAqIFZPUF9JTlRSX0NUUkwwLmRzcF9saW5lX2ZyYWdfbnVtID0gVk9QX0RTUF9WQUNU X1NUX0VORC5kc3BfdmFjdF9lbmQKPj4+ICsgKiBJbnRlcnJ1cHRzCj4+PiArICogTElORV9GTEFH IC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0rCj4+PiArICogRlJBTUVfU1lOQyAtLS0t KyAgICAgICAgICAgICAgICAgICAgICAgICB8Cj4+PiArICogICAgICAgICAgICAgICAgfCAgICAg ICAgICAgICAgICAgICAgICAgICB8Cj4+PiArICogICAgICAgICAgICAgICAgdiAgICAgICAgICAg ICAgICAgICAgICAgICB2Cj4+PiArICogICAgICAgICAgICAgICAgfCBWc3luYyB8IFZicCB8ICBW YWN0aXZlICB8IFZmcCB8Cj4+PiArICogICAgICAgICAgICAgICAgICAgICAgICBeICAgICBeICAg ICAgICAgICBeICAgICBeCj4+PiArICogICAgICAgICAgICAgICAgICAgICAgICB8ICAgICB8ICAg ICAgICAgICB8ICAgICB8Cj4+PiArICogICAgICAgICAgICAgICAgICAgICAgICB8ICAgICB8ICAg ICAgICAgICB8ICAgICB8Cj4+PiArICogZHNwX3ZzX2VuZCAtLS0tLS0tLS0tLS0rICAgICB8ICAg ICAgICAgICB8ICAgICB8ICAgVk9QX0RTUF9WVE9UQUxfVlNfRU5ECj4+PiArICogZHNwX3ZhY3Rf c3RhcnQgLS0tLS0tLS0tLS0tLS0rICAgICAgICAgICB8ICAgICB8ICAgVk9QX0RTUF9WQUNUX1NU X0VORAo+Pj4gKyAqIGRzcF92YWN0X2VuZCAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tKyAg ICAgfCAgIFZPUF9EU1BfVkFDVF9TVF9FTkQKPj4+ICsgKiBkc3BfdG90YWwgLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLSsgICBWT1BfRFNQX1ZUT1RBTF9WU19FTkQKPj4+ICsg Ki8KPj4+ICsKPj4+ICtzdGF0aWMgdm9pZCB2b3BfbGluZV9mbGFnX2lycV9lbmFibGUoc3RydWN0 IHZvcCAqdm9wLCBpbnQgbGluZV9udW0pCj4+PiArewo+Pj4gKyAgICAgICB1bnNpZ25lZCBsb25n IGZsYWdzOwo+Pj4gKwo+Pj4gKyAgICAgICBpZiAoV0FSTl9PTighdm9wLT5pc19lbmFibGVkKSkK Pj4+ICsgICAgICAgICAgICAgICByZXR1cm47Cj4+PiArCj4+PiArICAgICAgIHNwaW5fbG9ja19p cnFzYXZlKCZ2b3AtPmlycV9sb2NrLCBmbGFncyk7Cj4+PiArCj4+PiArICAgICAgIFZPUF9DVFJM X1NFVCh2b3AsIGxpbmVfZmxhZ19udW1fMCwgbGluZV9udW0pOwo+Pj4gKyAgICAgICBWT1BfSU5U Ul9TRVRfVFlQRSh2b3AsIGVuYWJsZSwgTElORV9GTEFHX0lOVFIsIDEpOwo+Pj4gKyAgICAgICB2 b3BfY2ZnX2RvbmUodm9wKTsKPj4+ICsKPj4+ICsgICAgICAgc3Bpbl91bmxvY2tfaXJxcmVzdG9y ZSgmdm9wLT5pcnFfbG9jaywgZmxhZ3MpOwo+Pj4gK30KPj4+ICsKPj4+ICtzdGF0aWMgdm9pZCB2 b3BfbGluZV9mbGFnX2lycV9kaXNhYmxlKHN0cnVjdCB2b3AgKnZvcCkKPj4+ICt7Cj4+PiArICAg ICAgIHVuc2lnbmVkIGxvbmcgZmxhZ3M7Cj4+PiArCj4+PiArICAgICAgIGlmIChXQVJOX09OKCF2 b3AtPmlzX2VuYWJsZWQpKQo+Pj4gKyAgICAgICAgICAgICAgIHJldHVybjsKPj4+ICsKPj4+ICsg ICAgICAgc3Bpbl9sb2NrX2lycXNhdmUoJnZvcC0+aXJxX2xvY2ssIGZsYWdzKTsKPj4+ICsKPj4+ ICsgICAgICAgVk9QX0lOVFJfU0VUX1RZUEUodm9wLCBlbmFibGUsIExJTkVfRkxBR19JTlRSLCAw KTsKPj4+ICsKPj4+ICsgICAgICAgc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgmdm9wLT5pcnFfbG9j aywgZmxhZ3MpOwo+Pj4gK30KPj4+ICsKPj4+ICAgc3RhdGljIHZvaWQgdm9wX2VuYWJsZShzdHJ1 Y3QgZHJtX2NydGMgKmNydGMpCj4+PiAgIHsKPj4+ICAgICAgICAgIHN0cnVjdCB2b3AgKnZvcCA9 IHRvX3ZvcChjcnRjKTsKPj4+IEBAIC0xMTU3LDYgKzEyMTIsMTMgQEAgc3RhdGljIGlycXJldHVy bl90IHZvcF9pc3IoaW50IGlycSwgdm9pZCAqZGF0YSkKPj4+ICAgICAgICAgICAgICAgICAgcmV0 ID0gSVJRX0hBTkRMRUQ7Cj4+PiAgICAgICAgICB9Cj4+Pgo+Pj4gKyAgICAgICBpZiAoYWN0aXZl X2lycXMgJiBMSU5FX0ZMQUdfSU5UUikgewo+Pj4gKyAgICAgICAgICAgICAgIGlmICghY29tcGxl dGlvbl9kb25lKCZ2b3AtPmxpbmVfZmxhZ19jb21wbGV0aW9uKSkKPj4+ICsgICAgICAgICAgICAg ICAgICAgICAgIGNvbXBsZXRlKCZ2b3AtPmxpbmVfZmxhZ19jb21wbGV0aW9uKTsKPj4gSSB0aGlu ayB0aGVyZSdzIHBvdGVudGlhbCB0byBtaXNzIGZsYWdzIGhlcmUgaWYgdGhlIHRpbWluZyBpcyBq dXN0Cj4+IHJpZ2h0IGJlY2F1c2UgdGhlIGNvbXBsZXRpb25fZG9uZSBhbmQgY29tcGxldGUgYXJl IG5vdCBhdG9taWMgd3J0IHRoZQo+PiB3YWl0X2xpbmVfZmxhZyBmdW5jdGlvbi4gSSB0aGluayB5 b3UgbmVlZCBzb21lIGxvY2tpbmcgYXJvdW5kIHRoZQo+PiBjb21wbGV0aW9uIG9wZXJhdGlvbnMg dG8gZW5zdXJlIHRoZXkncmUgcHJvcGVybHkgc2VxdWVuY2VkLgo+Pgo+PiBGV0lXLCBpZiB5b3Un cmUgcmVpbml0aWFsaXppbmcgdGhlIGNvbXBsZXRpb24gZXZlcnkgdGltZSBpbgo+PiBkcm1fd2Fp dF9saW5lX2ZsYWcsIHlvdSBzaG91bGQgYmUgYWJsZSB0byBqdXN0IGNhbGwgY29tcGxldGUgKG9y Cj4+IGNvbXBsZXRlX2FsbCkgd2l0aG91dCBjaGVja2luZyBpZiB0aGVyZSBhcmUgYW55IHdhaXRl cnMuCj4+Cj4gSSBzaG91bGQgYWRkLCBpZiB5b3UganVzdCBjYWxsIGNvbXBsZXRlL2NvbXBsZXRl X2FsbCgpIGhlcmUsIHlvdQo+IHNob3VsZG4ndCBuZWVkIHRvIGFkZCBsb2NraW5nIChhc3N1bWlu ZyBvbmx5IG9uZSB3YWl0ZXIpLgoKWWVzLCBvbmx5IG9uZSB3YWl0ZXIuCgo+Pj4gKyAgICAgICAg ICAgICAgIGFjdGl2ZV9pcnFzICY9IH5MSU5FX0ZMQUdfSU5UUjsKPj4+ICsgICAgICAgICAgICAg ICByZXQgPSBJUlFfSEFORExFRDsKPj4+ICsgICAgICAgfQo+Pj4gKwo+Pj4gICAgICAgICAgaWYg KGFjdGl2ZV9pcnFzICYgRlNfSU5UUikgewo+Pj4gICAgICAgICAgICAgICAgICBkcm1fY3J0Y19o YW5kbGVfdmJsYW5rKGNydGMpOwo+Pj4gICAgICAgICAgICAgICAgICB2b3BfaGFuZGxlX3ZibGFu ayh2b3ApOwo+Pj4gQEAgLTEyNTUsNiArMTMxNyw3IEBAIHN0YXRpYyBpbnQgdm9wX2NyZWF0ZV9j cnRjKHN0cnVjdCB2b3AgKnZvcCkKPj4+Cj4+PiAgICAgICAgICBpbml0X2NvbXBsZXRpb24oJnZv cC0+ZHNwX2hvbGRfY29tcGxldGlvbik7Cj4+PiAgICAgICAgICBpbml0X2NvbXBsZXRpb24oJnZv cC0+d2FpdF91cGRhdGVfY29tcGxldGUpOwo+Pj4gKyAgICAgICBpbml0X2NvbXBsZXRpb24oJnZv cC0+bGluZV9mbGFnX2NvbXBsZXRpb24pOwo+Pj4gICAgICAgICAgY3J0Yy0+cG9ydCA9IHBvcnQ7 Cj4+PiAgICAgICAgICByb2NrY2hpcF9yZWdpc3Rlcl9jcnRjX2Z1bmNzKGNydGMsICZwcml2YXRl X2NydGNfZnVuY3MpOwo+Pj4KPj4+IEBAIC0xNDExLDYgKzE0NzQsNDYgQEAgc3RhdGljIHZvaWQg dm9wX3dpbl9pbml0KHN0cnVjdCB2b3AgKnZvcCkKPj4+ICAgICAgICAgIH0KPj4+ICAgfQo+Pj4K Pj4+ICsvKioKPj4+ICsgKiByb2NrY2hpcF9kcm1fd2FpdF9saW5lX2ZsYWcgLSBhY3FpdXJlIHRo ZSBnaXZlIGxpbmUgZmxhZyBldmVudAo+Pj4gKyAqIEBjcnRjOiBDUlRDIHRvIGVuYWJsZSBsaW5l IGZsYWcKPj4+ICsgKiBAbGluZV9udW06IGludGVyZXN0ZWQgbGluZSBudW1iZXIKPj4+ICsgKiBA bXN0aW1lb3V0OiBtaWxsaXNlY29uZCBmb3IgdGltZW91dAo+Pj4gKyAqCj4+PiArICogRHJpdmVy IHdvdWxkIGhvbGQgaGVyZSB1bnRpbCB0aGUgaW50ZXJlc3RlZCBsaW5lIGZsYWcgaW50ZXJydXB0 IGhhdmUKPj4+ICsgKiBoYXBwZW5lZCBvciB0aW1lb3V0IHRvIHdhaXQuCj4+PiArICoKPj4+ICsg KiBSZXR1cm5zOgo+Pj4gKyAqIFplcm8gb24gc3VjY2VzcywgbmVnYXRpdmUgZXJybm8gb24gZmFp bHVyZS4KPj4+ICsgKi8KPj4+ICtpbnQgcm9ja2NoaXBfZHJtX3dhaXRfbGluZV9mbGFnKHN0cnVj dCBkcm1fY3J0YyAqY3J0YywgdW5zaWduZWQgaW50IGxpbmVfbnVtLAo+Pj4gKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBpbnQgbXN0aW1lb3V0KQo+Pj4gK3sKPj4+ICsg ICAgICAgc3RydWN0IHZvcCAqdm9wID0gdG9fdm9wKGNydGMpOwo+Pj4gKyAgICAgICB1bnNpZ25l ZCBsb25nIGppZmZpZXNfbGVmdDsKPj4+ICsKPj4+ICsgICAgICAgaWYgKCFjcnRjIHx8ICF2b3At PmlzX2VuYWJsZWQpCj4+PiArICAgICAgICAgICAgICAgcmV0dXJuIC1FTk9ERVY7Cj4+PiArCj4+ PiArICAgICAgIGlmIChsaW5lX251bSA+IGNydGMtPm1vZGUudnRvdGFsIHx8IG1zdGltZW91dCA8 PSAwKQo+Pj4gKyAgICAgICAgICAgICAgIHJldHVybiAtRUlOVkFMOwo+Pj4gKwo+Pj4gKyAgICAg ICByZWluaXRfY29tcGxldGlvbigmdm9wLT5saW5lX2ZsYWdfY29tcGxldGlvbik7Cj4+PiArICAg ICAgIHZvcF9saW5lX2ZsYWdfaXJxX2VuYWJsZSh2b3AsIGxpbmVfbnVtKTsKPj4+ICsKPj4gVGhp cyB3aWxsIG9ubHkgd29yayBmb3Igb25lIHdhaXRlciBwZXIgdm9wLiBJcyBpdCB3b3J0aCBlbmZv cmNpbmcgdGhpcwo+PiBleHBsaWNpdGx5IHRvIGF2b2lkIHdlaXJkIGJlaGF2aW9yIHdoZW4gdGhl cmUgYXJlIG1vcmUgdGhhbiBvbmU/CgpZZXMsIHlvdSdyZSByaWdodCwgbmVlZCB0byBhdm9pZCB0 aGUgd2VpcmQgYmVoYXZpb3IgaGVyZS4KCj4+Cj4+PiArICAgICAgIGppZmZpZXNfbGVmdCA9IHdh aXRfZm9yX2NvbXBsZXRpb25fdGltZW91dCgmdm9wLT5saW5lX2ZsYWdfY29tcGxldGlvbiwKPj4+ ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG1zZWNz X3RvX2ppZmZpZXMobXN0aW1lb3V0KSk7Cj4+PiArICAgICAgIHZvcF9saW5lX2ZsYWdfaXJxX2Rp c2FibGUodm9wKTsKPj4+ICsKPj4+ICsgICAgICAgaWYgKGppZmZpZXNfbGVmdCA9PSAwKSB7Cj4+ PiArICAgICAgICAgICAgICAgZGV2X2Vycih2b3AtPmRldiwgIlRpbWVvdXQgd2FpdGluZyBmb3Ig SVJRXG4iKTsKPj4+ICsgICAgICAgICAgICAgICByZXR1cm4gLUVUSU1FRE9VVDsKPj4+ICsgICAg ICAgfQo+Pj4gKwo+Pj4gKyAgICAgICByZXR1cm4gMDsKPj4+ICt9Cj4+PiArRVhQT1JUX1NZTUJP TChyb2NrY2hpcF9kcm1fd2FpdF9saW5lX2ZsYWcpOwo+Pj4gKwo+Pj4gICBzdGF0aWMgaW50IHZv cF9iaW5kKHN0cnVjdCBkZXZpY2UgKmRldiwgc3RydWN0IGRldmljZSAqbWFzdGVyLCB2b2lkICpk YXRhKQo+Pj4gICB7Cj4+PiAgICAgICAgICBzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2ID0g dG9fcGxhdGZvcm1fZGV2aWNlKGRldik7Cj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L3JvY2tjaGlwL3JvY2tjaGlwX2RybV92b3AuaCBiL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9y b2NrY2hpcF9kcm1fdm9wLmgKPj4+IGluZGV4IGZmNGY1MmUuLjM0ZmNkMDMgMTAwNjQ0Cj4+PiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvcm9ja2NoaXBfZHJtX3ZvcC5oCj4+PiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvcm9ja2NoaXBfZHJtX3ZvcC5oCj4+PiBAQCAtNjEs NiArNjEsOSBAQCBzdHJ1Y3Qgdm9wX2N0cmwgewo+Pj4gICAgICAgICAgc3RydWN0IHZvcF9yZWcg aHBvc3Rfc3RfZW5kOwo+Pj4gICAgICAgICAgc3RydWN0IHZvcF9yZWcgdnBvc3Rfc3RfZW5kOwo+ Pj4KPj4+ICsgICAgICAgc3RydWN0IHZvcF9yZWcgbGluZV9mbGFnX251bV8wOwo+Pj4gKyAgICAg ICBzdHJ1Y3Qgdm9wX3JlZyBsaW5lX2ZsYWdfbnVtXzE7Cj4+PiArCj4+IG5pdDogeW91IGNvdWxk IG1ha2UgdGhpcyBhbiBhcnJheToKPj4KPj4gc3RydWN0IHZvcF9yZWcgbGluZV9mbGFnX251bVsy XTsKCkRvbmUsCgo+Pgo+Pj4gICAgICAgICAgc3RydWN0IHZvcF9yZWcgY2ZnX2RvbmU7Cj4+PiAg IH07Cj4+Pgo+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9yb2NrY2hp cF92b3BfcmVnLmMgYi9kcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvcm9ja2NoaXBfdm9wX3JlZy5j Cj4+PiBpbmRleCA2ZjQyZTU2Li5lOTIxMWM5IDEwMDY0NAo+Pj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL3JvY2tjaGlwL3JvY2tjaGlwX3ZvcF9yZWcuYwo+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJt L3JvY2tjaGlwL3JvY2tjaGlwX3ZvcF9yZWcuYwo+Pj4gQEAgLTEyMiw2ICsxMjIsNyBAQCBzdGF0 aWMgY29uc3Qgc3RydWN0IHZvcF9jdHJsIHJrMzAzNl9jdHJsX2RhdGEgPSB7Cj4+PiAgICAgICAg ICAuaGFjdF9zdF9lbmQgPSBWT1BfUkVHKFJLMzAzNl9EU1BfSEFDVF9TVF9FTkQsIDB4MWZmZjFm ZmYsIDApLAo+Pj4gICAgICAgICAgLnZ0b3RhbF9wdyA9IFZPUF9SRUcoUkszMDM2X0RTUF9WVE9U QUxfVlNfRU5ELCAweDFmZmYxZmZmLCAwKSwKPj4+ICAgICAgICAgIC52YWN0X3N0X2VuZCA9IFZP UF9SRUcoUkszMDM2X0RTUF9WQUNUX1NUX0VORCwgMHgxZmZmMWZmZiwgMCksCj4+PiArICAgICAg IC5saW5lX2ZsYWdfbnVtXzAgPSBWT1BfUkVHKFJLMzAzNl9JTlRfU1RBVFVTLCAweGZmZiwgMTIp LAo+Pj4gICAgICAgICAgLmNmZ19kb25lID0gVk9QX1JFRyhSSzMwMzZfUkVHX0NGR19ET05FLCAw eDEsIDApLAo+Pj4gICB9Owo+Pj4KPj4+IEBAIC0yMjEsNiArMjIyLDcgQEAgc3RhdGljIGNvbnN0 IHN0cnVjdCB2b3BfY3RybCByazMyODhfY3RybF9kYXRhID0gewo+Pj4gICAgICAgICAgLnZhY3Rf c3RfZW5kID0gVk9QX1JFRyhSSzMyODhfRFNQX1ZBQ1RfU1RfRU5ELCAweDFmZmYxZmZmLCAwKSwK Pj4+ICAgICAgICAgIC5ocG9zdF9zdF9lbmQgPSBWT1BfUkVHKFJLMzI4OF9QT1NUX0RTUF9IQUNU X0lORk8sIDB4MWZmZjFmZmYsIDApLAo+Pj4gICAgICAgICAgLnZwb3N0X3N0X2VuZCA9IFZPUF9S RUcoUkszMjg4X1BPU1RfRFNQX1ZBQ1RfSU5GTywgMHgxZmZmMWZmZiwgMCksCj4+PiArICAgICAg IC5saW5lX2ZsYWdfbnVtXzAgPSBWT1BfUkVHKFJLMzI4OF9JTlRSX0NUUkwwLCAweDFmZmYsIDEy KSwKPj4+ICAgICAgICAgIC5jZmdfZG9uZSA9IFZPUF9SRUcoUkszMjg4X1JFR19DRkdfRE9ORSwg MHgxLCAwKSwKPj4+ICAgfTsKPj4+Cj4+PiBAQCAtMjk5LDYgKzMwMSw4IEBAIHN0YXRpYyBjb25z dCBzdHJ1Y3Qgdm9wX2N0cmwgcmszMzk5X2N0cmxfZGF0YSA9IHsKPj4+ICAgICAgICAgIC52YWN0 X3N0X2VuZCA9IFZPUF9SRUcoUkszMzk5X0RTUF9WQUNUX1NUX0VORCwgMHgxZmZmMWZmZiwgMCks Cj4+PiAgICAgICAgICAuaHBvc3Rfc3RfZW5kID0gVk9QX1JFRyhSSzMzOTlfUE9TVF9EU1BfSEFD VF9JTkZPLCAweDFmZmYxZmZmLCAwKSwKPj4+ICAgICAgICAgIC52cG9zdF9zdF9lbmQgPSBWT1Bf UkVHKFJLMzM5OV9QT1NUX0RTUF9WQUNUX0lORk8sIDB4MWZmZjFmZmYsIDApLAo+Pj4gKyAgICAg ICAubGluZV9mbGFnX251bV8wID0gVk9QX1JFRyhSSzMzOTlfTElORV9GTEFHLCAweGZmZmYsIDAp LAo+Pj4gKyAgICAgICAubGluZV9mbGFnX251bV8xID0gVk9QX1JFRyhSSzMzOTlfTElORV9GTEFH LCAweGZmZmYsIDE2KSwKPj4+ICAgICAgICAgIC5jZmdfZG9uZSA9IFZPUF9SRUdfTUFTSyhSSzMz OTlfUkVHX0NGR19ET05FLCAweDEsIDApLAo+Pj4gICB9Owo+Pj4KPj4+IC0tCj4+PiAxLjkuMQo+ Pj4KPj4+Cj4KPgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZl bAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753955AbcGHCam (ORCPT ); Thu, 7 Jul 2016 22:30:42 -0400 Received: from lucky1.263xmail.com ([211.157.147.133]:52670 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753528AbcGHCac (ORCPT ); Thu, 7 Jul 2016 22:30:32 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: ykk@rock-chips.com X-FST-TO: linux-rockchip@lists.infradead.org X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: ykk@rock-chips.com X-UNIQUE-TAG: <9a610c0845b9e1080ae9e5524b0eac08> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v3 1/4] drm/rockchip: vop: export line flag function To: Sean Paul References: <1467364685-21390-1-git-send-email-ykk@rock-chips.com> <1467364745-21621-1-git-send-email-ykk@rock-chips.com> Cc: Mark Yao , Inki Dae , Jingoo Han , Heiko Stuebner , Daniel Vetter , =?UTF-8?Q?St=c3=a9phane_Marchesin?= , Tomasz Figa , Doug Anderson , Thierry Reding , Krzysztof Kozlowski , Javier Martinez Canillas , David Airlie , Emil Velikov , Linux Kernel Mailing List , dri-devel , linux-samsung-soc , linux-rockchip@lists.infradead.org From: Yakir Yang Message-ID: <577F1032.5040908@rock-chips.com> Date: Fri, 8 Jul 2016 10:30:10 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sean, On 07/01/2016 11:32 PM, Sean Paul wrote: > On Fri, Jul 1, 2016 at 11:30 AM, Sean Paul wrote: >> On Fri, Jul 1, 2016 at 5:19 AM, Yakir Yang wrote: >>> VOP have integrated a hardware counter which indicate the exact display >>> line that vop is scanning. And if we're interested in a specific line, >>> we can set the line number to vop line_flag register, and then vop would >>> generate a line_flag interrupt for it. >>> >>> For example eDP PSR function is interested in the vertical blanking >>> period, then driver could set the line number to zero. >>> >>> This patch have exported a symbol that allow other driver to listen the >>> line flag event with given timeout limit: >>> - rockchip_drm_wait_line_flag() >>> >>> Signed-off-by: Yakir Yang >>> --- >>> Changes in v3: >>> - Export the 'rockchip_drm_wait_line_flag' symbol, and document it. >>> - Add 'line_flag_num_0' for RK3288/RK3036 >>> - Remove the notify for waiting line_flag event (Daniel) >>> >>> Changes in v2: >>> - Introduce in v2, split VOP line flag changes out >>> >>> drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 3 + >>> drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 103 ++++++++++++++++++++++++++++ >>> drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 3 + >>> drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 4 ++ >>> 4 files changed, 113 insertions(+) >>> >>> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.h b/drivers/gpu/drm/rockchip/rockchip_drm_drv.h >>> index ea39329..239b830 100644 >>> --- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.h >>> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.h >>> @@ -70,4 +70,7 @@ int rockchip_drm_dma_attach_device(struct drm_device *drm_dev, >>> struct device *dev); >>> void rockchip_drm_dma_detach_device(struct drm_device *drm_dev, >>> struct device *dev); >>> +int rockchip_drm_wait_line_flag(struct drm_crtc *crtc, unsigned int line_num, >>> + unsigned int mstimeout); >>> + >>> #endif /* _ROCKCHIP_DRM_DRV_H_ */ >>> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c >>> index c8a62a8..cd3cac5 100644 >>> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c >>> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c >>> @@ -121,6 +121,8 @@ struct vop { >>> /* protected by dev->event_lock */ >>> struct drm_pending_vblank_event *event; >>> >>> + struct completion line_flag_completion; >>> + >>> const struct vop_data *data; >>> >>> uint32_t *regsbak; >>> @@ -431,6 +433,59 @@ static void vop_dsp_hold_valid_irq_disable(struct vop *vop) >>> spin_unlock_irqrestore(&vop->irq_lock, flags); >>> } >>> >>> +/* >>> + * (1) each frame starts at the start of the Vsync pulse which is signaled by >>> + * the "FRAME_SYNC" interrupt. >>> + * (2) the active data region of each frame ends at dsp_vact_end >>> + * (3) we should program this same number (dsp_vact_end) into dsp_line_frag_num, >>> + * to get "LINE_FLAG" interrupt at the end of the active on screen data. >>> + * >>> + * VOP_INTR_CTRL0.dsp_line_frag_num = VOP_DSP_VACT_ST_END.dsp_vact_end >>> + * Interrupts >>> + * LINE_FLAG -------------------------------+ >>> + * FRAME_SYNC ----+ | >>> + * | | >>> + * v v >>> + * | Vsync | Vbp | Vactive | Vfp | >>> + * ^ ^ ^ ^ >>> + * | | | | >>> + * | | | | >>> + * dsp_vs_end ------------+ | | | VOP_DSP_VTOTAL_VS_END >>> + * dsp_vact_start --------------+ | | VOP_DSP_VACT_ST_END >>> + * dsp_vact_end ----------------------------+ | VOP_DSP_VACT_ST_END >>> + * dsp_total -------------------------------------+ VOP_DSP_VTOTAL_VS_END >>> + */ >>> + >>> +static void vop_line_flag_irq_enable(struct vop *vop, int line_num) >>> +{ >>> + unsigned long flags; >>> + >>> + if (WARN_ON(!vop->is_enabled)) >>> + return; >>> + >>> + spin_lock_irqsave(&vop->irq_lock, flags); >>> + >>> + VOP_CTRL_SET(vop, line_flag_num_0, line_num); >>> + VOP_INTR_SET_TYPE(vop, enable, LINE_FLAG_INTR, 1); >>> + vop_cfg_done(vop); >>> + >>> + spin_unlock_irqrestore(&vop->irq_lock, flags); >>> +} >>> + >>> +static void vop_line_flag_irq_disable(struct vop *vop) >>> +{ >>> + unsigned long flags; >>> + >>> + if (WARN_ON(!vop->is_enabled)) >>> + return; >>> + >>> + spin_lock_irqsave(&vop->irq_lock, flags); >>> + >>> + VOP_INTR_SET_TYPE(vop, enable, LINE_FLAG_INTR, 0); >>> + >>> + spin_unlock_irqrestore(&vop->irq_lock, flags); >>> +} >>> + >>> static void vop_enable(struct drm_crtc *crtc) >>> { >>> struct vop *vop = to_vop(crtc); >>> @@ -1157,6 +1212,13 @@ static irqreturn_t vop_isr(int irq, void *data) >>> ret = IRQ_HANDLED; >>> } >>> >>> + if (active_irqs & LINE_FLAG_INTR) { >>> + if (!completion_done(&vop->line_flag_completion)) >>> + complete(&vop->line_flag_completion); >> I think there's potential to miss flags here if the timing is just >> right because the completion_done and complete are not atomic wrt the >> wait_line_flag function. I think you need some locking around the >> completion operations to ensure they're properly sequenced. >> >> FWIW, if you're reinitializing the completion every time in >> drm_wait_line_flag, you should be able to just call complete (or >> complete_all) without checking if there are any waiters. >> > I should add, if you just call complete/complete_all() here, you > shouldn't need to add locking (assuming only one waiter). Yes, only one waiter. >>> + active_irqs &= ~LINE_FLAG_INTR; >>> + ret = IRQ_HANDLED; >>> + } >>> + >>> if (active_irqs & FS_INTR) { >>> drm_crtc_handle_vblank(crtc); >>> vop_handle_vblank(vop); >>> @@ -1255,6 +1317,7 @@ static int vop_create_crtc(struct vop *vop) >>> >>> init_completion(&vop->dsp_hold_completion); >>> init_completion(&vop->wait_update_complete); >>> + init_completion(&vop->line_flag_completion); >>> crtc->port = port; >>> rockchip_register_crtc_funcs(crtc, &private_crtc_funcs); >>> >>> @@ -1411,6 +1474,46 @@ static void vop_win_init(struct vop *vop) >>> } >>> } >>> >>> +/** >>> + * rockchip_drm_wait_line_flag - acqiure the give line flag event >>> + * @crtc: CRTC to enable line flag >>> + * @line_num: interested line number >>> + * @mstimeout: millisecond for timeout >>> + * >>> + * Driver would hold here until the interested line flag interrupt have >>> + * happened or timeout to wait. >>> + * >>> + * Returns: >>> + * Zero on success, negative errno on failure. >>> + */ >>> +int rockchip_drm_wait_line_flag(struct drm_crtc *crtc, unsigned int line_num, >>> + unsigned int mstimeout) >>> +{ >>> + struct vop *vop = to_vop(crtc); >>> + unsigned long jiffies_left; >>> + >>> + if (!crtc || !vop->is_enabled) >>> + return -ENODEV; >>> + >>> + if (line_num > crtc->mode.vtotal || mstimeout <= 0) >>> + return -EINVAL; >>> + >>> + reinit_completion(&vop->line_flag_completion); >>> + vop_line_flag_irq_enable(vop, line_num); >>> + >> This will only work for one waiter per vop. Is it worth enforcing this >> explicitly to avoid weird behavior when there are more than one? Yes, you're right, need to avoid the weird behavior here. >> >>> + jiffies_left = wait_for_completion_timeout(&vop->line_flag_completion, >>> + msecs_to_jiffies(mstimeout)); >>> + vop_line_flag_irq_disable(vop); >>> + >>> + if (jiffies_left == 0) { >>> + dev_err(vop->dev, "Timeout waiting for IRQ\n"); >>> + return -ETIMEDOUT; >>> + } >>> + >>> + return 0; >>> +} >>> +EXPORT_SYMBOL(rockchip_drm_wait_line_flag); >>> + >>> static int vop_bind(struct device *dev, struct device *master, void *data) >>> { >>> struct platform_device *pdev = to_platform_device(dev); >>> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.h b/drivers/gpu/drm/rockchip/rockchip_drm_vop.h >>> index ff4f52e..34fcd03 100644 >>> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.h >>> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.h >>> @@ -61,6 +61,9 @@ struct vop_ctrl { >>> struct vop_reg hpost_st_end; >>> struct vop_reg vpost_st_end; >>> >>> + struct vop_reg line_flag_num_0; >>> + struct vop_reg line_flag_num_1; >>> + >> nit: you could make this an array: >> >> struct vop_reg line_flag_num[2]; Done, >> >>> struct vop_reg cfg_done; >>> }; >>> >>> diff --git a/drivers/gpu/drm/rockchip/rockchip_vop_reg.c b/drivers/gpu/drm/rockchip/rockchip_vop_reg.c >>> index 6f42e56..e9211c9 100644 >>> --- a/drivers/gpu/drm/rockchip/rockchip_vop_reg.c >>> +++ b/drivers/gpu/drm/rockchip/rockchip_vop_reg.c >>> @@ -122,6 +122,7 @@ static const struct vop_ctrl rk3036_ctrl_data = { >>> .hact_st_end = VOP_REG(RK3036_DSP_HACT_ST_END, 0x1fff1fff, 0), >>> .vtotal_pw = VOP_REG(RK3036_DSP_VTOTAL_VS_END, 0x1fff1fff, 0), >>> .vact_st_end = VOP_REG(RK3036_DSP_VACT_ST_END, 0x1fff1fff, 0), >>> + .line_flag_num_0 = VOP_REG(RK3036_INT_STATUS, 0xfff, 12), >>> .cfg_done = VOP_REG(RK3036_REG_CFG_DONE, 0x1, 0), >>> }; >>> >>> @@ -221,6 +222,7 @@ static const struct vop_ctrl rk3288_ctrl_data = { >>> .vact_st_end = VOP_REG(RK3288_DSP_VACT_ST_END, 0x1fff1fff, 0), >>> .hpost_st_end = VOP_REG(RK3288_POST_DSP_HACT_INFO, 0x1fff1fff, 0), >>> .vpost_st_end = VOP_REG(RK3288_POST_DSP_VACT_INFO, 0x1fff1fff, 0), >>> + .line_flag_num_0 = VOP_REG(RK3288_INTR_CTRL0, 0x1fff, 12), >>> .cfg_done = VOP_REG(RK3288_REG_CFG_DONE, 0x1, 0), >>> }; >>> >>> @@ -299,6 +301,8 @@ static const struct vop_ctrl rk3399_ctrl_data = { >>> .vact_st_end = VOP_REG(RK3399_DSP_VACT_ST_END, 0x1fff1fff, 0), >>> .hpost_st_end = VOP_REG(RK3399_POST_DSP_HACT_INFO, 0x1fff1fff, 0), >>> .vpost_st_end = VOP_REG(RK3399_POST_DSP_VACT_INFO, 0x1fff1fff, 0), >>> + .line_flag_num_0 = VOP_REG(RK3399_LINE_FLAG, 0xffff, 0), >>> + .line_flag_num_1 = VOP_REG(RK3399_LINE_FLAG, 0xffff, 16), >>> .cfg_done = VOP_REG_MASK(RK3399_REG_CFG_DONE, 0x1, 0), >>> }; >>> >>> -- >>> 1.9.1 >>> >>> > >