From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
To: Eric Dumazet <eric.dumazet@gmail.com>,
Masashi Honma <masashi.honma@gmail.com>,
David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] ipv4: do not abuse GFP_ATOMIC in inet_netconf_notify_devconf()
Date: Fri, 8 Jul 2016 09:54:08 +0200 [thread overview]
Message-ID: <577F5C20.4050201@6wind.com> (raw)
In-Reply-To: <1467947904.1273.56.camel@edumazet-glaptop3.roam.corp.google.com>
Le 08/07/2016 05:18, Eric Dumazet a écrit :
> From: Eric Dumazet <edumazet@google.com>
>
> inet_forward_change() runs with RTNL held.
> We are allowed to sleep if required.
>
> If we use __in_dev_get_rtnl() instead of __in_dev_get_rcu(),
> we no longer have to use GFP_ATOMIC allocations in
> inet_netconf_notify_devconf(), meaning we are less likely to miss
> notifications under memory pressure, and wont touch precious memory
> reserves either and risk dropping incoming packets.
>
> inet_netconf_get_devconf() can also use GFP_KERNEL allocation.
>
> Fixes: edc9e748934c ("rtnl/ipv4: use netconf msg to advertise forwarding status")
> Fixes: 9e5511106f99 ("rtnl/ipv4: add support of RTM_GETNETCONF")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Acked-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Nice catch, thank you!
next prev parent reply other threads:[~2016-07-08 7:54 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-06 0:28 [Cluster-devel] [RFC 0/7] netlink: Add allocation flag to netlink_unicast() Masashi Honma
2016-07-06 0:28 ` Masashi Honma
2016-07-06 0:28 ` Masashi Honma
2016-07-06 0:28 ` [Cluster-devel] [RFC 1/7] " Masashi Honma
2016-07-06 0:28 ` Masashi Honma
2016-07-06 0:28 ` [Cluster-devel] [RFC 2/7] netfilter: Add allocation flag to nfnetlink_unicast() Masashi Honma
2016-07-06 0:28 ` Masashi Honma
2016-07-06 0:28 ` [Cluster-devel] [RFC 3/7] netlink: Add allocation flag to nlmsg_unicast() Masashi Honma
2016-07-06 0:28 ` Masashi Honma
2016-07-06 0:28 ` Masashi Honma
2016-07-06 0:28 ` [Cluster-devel] [RFC 4/7] infiniband: Add allocation flag to ibnl_unicast() Masashi Honma
2016-07-06 0:28 ` Masashi Honma
2016-07-06 0:28 ` [Cluster-devel] [RFC 5/7] net: Add allocation flag to rtnl_unicast() Masashi Honma
2016-07-06 0:28 ` Masashi Honma
2016-07-08 2:56 ` [Cluster-devel] " Eric Dumazet
2016-07-08 2:56 ` Eric Dumazet
2016-07-08 3:15 ` [Cluster-devel] " Masashi Honma
2016-07-08 3:15 ` Masashi Honma
2016-07-08 4:00 ` [Cluster-devel] " Eric Dumazet
2016-07-08 4:00 ` Eric Dumazet
2016-07-08 4:00 ` Eric Dumazet
2016-07-08 3:18 ` [PATCH net-next] ipv4: do not abuse GFP_ATOMIC in inet_netconf_notify_devconf() Eric Dumazet
2016-07-08 3:46 ` [PATCH net-next] ipv6: do not abuse GFP_ATOMIC in inet6_netconf_notify_devconf() Eric Dumazet
2016-07-08 7:58 ` Nicolas Dichtel
2016-07-09 22:14 ` David Miller
2016-07-08 7:54 ` Nicolas Dichtel [this message]
2016-07-09 22:12 ` [PATCH net-next] ipv4: do not abuse GFP_ATOMIC in inet_netconf_notify_devconf() David Miller
2016-07-06 0:28 ` [Cluster-devel] [RFC 6/7] genetlink: Add allocation flag to genlmsg_unicast() Masashi Honma
2016-07-06 0:28 ` Masashi Honma
2016-07-06 0:28 ` Masashi Honma
2016-07-06 0:28 ` [Cluster-devel] [RFC 7/7] genetlink: Add allocation flag to genlmsg_reply() Masashi Honma
2016-07-06 0:28 ` Masashi Honma
2016-07-06 0:28 ` Masashi Honma
2016-07-06 3:22 ` [Cluster-devel] [RFC 0/7] netlink: Add allocation flag to netlink_unicast() David Miller
2016-07-06 3:22 ` David Miller
2016-07-06 3:22 ` David Miller
2016-07-07 0:35 ` [Cluster-devel] " Masashi Honma
2016-07-07 0:35 ` Masashi Honma
[not found] ` <20160708160821.GA2048@redhat.com>
2016-07-09 3:52 ` [Cluster-devel] " Masashi Honma
2016-07-09 3:52 ` Masashi Honma
2016-07-09 3:52 ` Masashi Honma
2016-07-09 3:54 ` [Cluster-devel] " Masashi Honma
2016-07-09 3:54 ` Masashi Honma
2016-07-09 3:54 ` Masashi Honma
2016-07-09 3:59 ` [PATCH v2 net-next] rtnl: Add GFP flag argument to rtnl_unicast() Masashi Honma
2016-07-11 20:01 ` David Miller
2016-07-12 4:23 ` Masashi Honma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=577F5C20.4050201@6wind.com \
--to=nicolas.dichtel@6wind.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=masashi.honma@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.