From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v3 00/11] Fix build errors related to
 exported headers
Date: Fri, 8 Jul 2016 10:56:57 +0100
Message-ID: <577F78E9.8020705@intel.com>
References: <cover.1467715254.git.adrien.mazarguil@6wind.com>
 <cover.1467905466.git.adrien.mazarguil@6wind.com>
 <10B01822-557C-400A-A6BE-DBFF60AF90E4@intel.com>
 <20160708080543.GB7621@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
To: "Wiles, Keith" <keith.wiles@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 1A3915921
 for <dev@dpdk.org>; Fri,  8 Jul 2016 11:57:02 +0200 (CEST)
In-Reply-To: <20160708080543.GB7621@6wind.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 7/8/2016 9:05 AM, Adrien Mazarguil wrote:
> On Thu, Jul 07, 2016 at 06:33:17PM +0000, Wiles, Keith wrote:
>>
>>> On Jul 7, 2016, at 10:49 AM, Adrien Mazarguil <adrien.mazarguil@6wind.com> wrote:
>>>
>>> DPDK uses GNU C language extensions in most of its code base. This is fine
>>> for internal source files whose compilation flags are controlled by DPDK,
>>> however user applications that use exported "public" headers may experience
>>> compilation failures when enabling strict error/standard checks (-std and
>>> -pedantic for instance).
>>
>> Do you try compiling these changes with CLANG and/or ICC compilers?
> 
> clang/clang++ yes, works fine. I did not try with ICC however.

I tested with icc, getting following error [1], compiler warning seems
valid, but didn't investigate what in your patch cause this.

[1]
.../app/test/test_table_acl.c(487): error #2405: array of elements
containing a flexible array member is nonstandard
                struct rte_pipeline_table_entry entries[5];
                                                ^

.../app/test/test_table_acl.c(492): error #2405: array of elements
containing a flexible array member is nonstandard
                struct rte_pipeline_table_entry entries_ptr[5];

> 
> Note that considering "({ ... })" is a GNU extension, compilers that do
> support this syntax also support the GNU __extension__ keyword. As a result,
> those that do not support this keyword most likely already cannot compile
> DPDK at all.
>