All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/2] openmpi: add Fortran support for MIPS32
Date: Fri, 8 Jul 2016 12:11:56 +0200	[thread overview]
Message-ID: <577F7C6C.8050708@imgtec.com> (raw)
In-Reply-To: <20160708105624.534d353c@free-electrons.com>

Hello Thomas,

On 08/07/16 10:56, Thomas Petazzoni wrote:
> Hello,
>
> On Thu, 7 Jul 2016 16:47:33 +0100, Vicente Olivert Riera wrote:
>> We include a file containing cached values for Fortran tests that are
>> performed at the configure step. These tests fail when cross-compiling
>> and this is known upstream. See:
>>
>> https://www.open-mpi.org/community/lists/users/2013/01/21186.php
>>
>> In that thread the upstream maintainer admits that "cross compiling
>> OpenMPI is a known issue" and the way to workaround this is to
>> "pre-populate configure's answers to the Fortran tests (so that it
>> doesn't actually have to run anything)"
>>
>> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
>
> After discussing with Yann, we have changed your solution to use the
> "config cache" mechanism of autoconf, which allows to preseed in a file
> a number of configuration variables. It makes the whole thing a little
> bit cleaner. It looks like this:
>
> # Enabling Fortran support requires pre-seeding the configure script
> # with various values that cannot be guessed, so we provide cache
> # files for various architectures.
>
> ifeq ($(BR2_TOOLCHAIN_HAS_FORTRAN),y)
> ifeq ($(BR2_mips)$(BR2_mipsel),y)
> OPENMPI_FORTRAN_CONF_CACHE = package/openmpi/openmpi-mips32-fortran.cache
> else ifeq ($(BR2_mips64)$(BR2_mips64el),y)
> OPENMPI_FORTRAN_CONF_CACHE = package/openmpi/openmpi-mips64-fortran.cache
> endif
> endif
>
> ifneq ($(OPENMPI_FORTRAN_CONF_CACHE),)
> define OPENMPI_COPY_FORTRAN_CACHE
>          cp $(OPENMPI_FORTRAN_CONF_CACHE) $(@D)/openmpi-config.cache
> endef
>
> OPENMPI_POST_PATCH_HOOKS += OPENMPI_COPY_FORTRAN_CACHE
> OPENMPI_CONF_OPTS += \
>          --enable-mpi-fortran=yes \
>          --cache-file=$(@D)/openmpi-config.cache
> else
> OPENMPI_CONF_OPTS += --enable-mpi-fortran=no
> endif
>
> And the openmpi-mips*-fortran.cache simply contain the list of
> variables.
>
> I've adjusted your two commits to this mechanism, and applied.

ok, perfect. Thanks a lot.

Regards,

Vincent.

> Thanks!
>
> Thomas
>

      reply	other threads:[~2016-07-08 10:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-07 15:47 [Buildroot] [PATCH v2 1/2] openmpi: add Fortran support for MIPS32 Vicente Olivert Riera
2016-07-07 15:47 ` [Buildroot] [PATCH v2 2/2] openmpi: add Fortran support for MIPS64 Vicente Olivert Riera
2016-07-07 20:40 ` [Buildroot] [PATCH v2 1/2] openmpi: add Fortran support for MIPS32 Yann E. MORIN
2016-07-08  8:56 ` Thomas Petazzoni
2016-07-08 10:11   ` Vicente Olivert Riera [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=577F7C6C.8050708@imgtec.com \
    --to=vincent.riera@imgtec.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.